-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v12 #10060
v12 #10060
Commits on Aug 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 919895f - Browse repository at this point
Copy the full SHA 919895fView commit details
Commits on Aug 18, 2023
-
Rename vertical stack to block stack (#10032)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Part of #9984 Documentation improvement will be done in a follow up <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for cfb3054 - Browse repository at this point
Copy the full SHA cfb3054View commit details -
[Select] consolidate se23 styles (#10081)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9963 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> - Change control-height to be 32px - `Select` consolidate se23 styles ### How to 🎩 * [Storybook](https://5d559397bae39100201eedc1-oiuqenxfoy.chromatic.com/?path=/story/all-components-select--all) * [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-select--all) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 28f4165 - Browse repository at this point
Copy the full SHA 28f4165View commit details -
Textfield add variant prop (#10036)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10033 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Deprecates `borderless` prop in favor of `variant='borderless'`
Configuration menu - View commit details
-
Copy full SHA for 359614c - Browse repository at this point
Copy the full SHA 359614cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 454bdd5 - Browse repository at this point
Copy the full SHA 454bdd5View commit details -
[Layout] Consolidate se23 logic and styles (#10093)
### WHY are these changes introduced? Fixes #9943 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `Layout` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-layout--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-afpqefhquh.chromatic.com/?path=/story/all-components-layout--annotated)
Configuration menu - View commit details
-
Copy full SHA for 2bc5c45 - Browse repository at this point
Copy the full SHA 2bc5c45View commit details -
[FormLayout] Consolidate se23 logic and styles (#10105)
### WHY are these changes introduced? Fixes #9935 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `FormLayout` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-formlayout--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-uozkfkbgfn.chromatic.com/?path=/story/all-components-formlayout--all)
Configuration menu - View commit details
-
Copy full SHA for f24db12 - Browse repository at this point
Copy the full SHA f24db12View commit details -
[Listbox] Consolidate se23 styles and logic (#10117)
### WHY are these changes introduced? Resolves #9949 . ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Listbox`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-dojywcrcgy.chromatic.com/?path=/story/all-components-listbox--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-listbox--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 88f6962 - Browse repository at this point
Copy the full SHA 88f6962View commit details -
[DropZone] Consolidate se23 logic and styles (#10111)
### WHY are these changes introduced? Fixes #9932 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `DropZone` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-dropzone--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-qvidvpjgoo.chromatic.com/?path=/story/all-components-dropzone--default)
Configuration menu - View commit details
-
Copy full SHA for 10f8336 - Browse repository at this point
Copy the full SHA 10f8336View commit details -
Rename HorizontalGrid to InlineGrid (#10116)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Part of #9985 <!-- Context about the problem that’s being addressed. -->
Configuration menu - View commit details
-
Copy full SHA for 962d70a - Browse repository at this point
Copy the full SHA 962d70aView commit details
Commits on Aug 21, 2023
-
[Link] consolidate se23 styles (#10113)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9947 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> - consolidate se23 styles ### How to 🎩 * [Storybook](https://5d559397bae39100201eedc1-vcnbnkugpz.chromatic.com/?path=/story/all-components-link--default) * [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-link--default&globals=polarisSummerEditions2023:true) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for ea3223b - Browse repository at this point
Copy the full SHA ea3223bView commit details -
[List] Consolidate se23 styles (#10118)
### WHY are these changes introduced? Resolves #9948. ### WHAT is this pull request doing? Consolidates se23 beta styles for `List`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-yvvnglksbe.chromatic.com/?path=/story/all-components-list--bulleted) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-list--bulleted&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for cd9667f - Browse repository at this point
Copy the full SHA cd9667fView commit details -
[DatePicker] Consolidate se23 logic and styles (#10120)
### WHY are these changes introduced? Fixes #9931 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `DatePicker` Component Add story delay for datepicker since the "All" test hasn't been rendering in time on some PRs ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datepicker--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-pxozkstezh.chromatic.com/?path=/story/all-components-datepicker--all)
Configuration menu - View commit details
-
Copy full SHA for 1ff9918 - Browse repository at this point
Copy the full SHA 1ff9918View commit details -
[MediaCard] Consolidate se23 logic and styles (#10124)
### WHY are these changes introduced? Fixes #9950 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `MediaCard` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-mediacard--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-tugvkbzhsc.chromatic.com/?path=/story/all-components-mediacard--default)
Configuration menu - View commit details
-
Copy full SHA for a0c1b72 - Browse repository at this point
Copy the full SHA a0c1b72View commit details -
[Labelled] Consolidate se23 logic and styles (#10125)
### WHY are these changes introduced? Fixes #9942 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `Labelled` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--with-help-text&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-spdehluzut.chromatic.com/?path=/story/all-components-textfield--with-help-text)
Configuration menu - View commit details
-
Copy full SHA for 1a35468 - Browse repository at this point
Copy the full SHA 1a35468View commit details -
[InlineError] Consolidate se23 logic and styles (#10127)
### WHY are these changes introduced? Fixes #9940 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `InlineError` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-inlineerror--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-aqogixplqr.chromatic.com/?path=/story/all-components-inlineerror--default)
Configuration menu - View commit details
-
Copy full SHA for 896dd5b - Browse repository at this point
Copy the full SHA 896dd5bView commit details -
[PageActions] Consolidate se23 logic and styles (#10129)
### WHY are these changes introduced? Fixes #9955 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `PageActions` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-pageactions--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-ddfrdxnifw.chromatic.com/?path=/story/all-components-pageactions--default)
Configuration menu - View commit details
-
Copy full SHA for 7f64668 - Browse repository at this point
Copy the full SHA 7f64668View commit details -
[ProgressBar] Consolidate se23 logic and styles (#10130)
### WHY are these changes introduced? Fixes #9959 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `PageActions` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-progressbar--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-lasqorkejk.chromatic.com/?path=/story/all-components-progressbar--default)
Configuration menu - View commit details
-
Copy full SHA for 3e8b30f - Browse repository at this point
Copy the full SHA 3e8b30fView commit details -
[SettingAction] Consolidate se23 logic and styles (#10131)
### WHY are these changes introduced? Fixes #9964 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `SettingAction` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-settingtoggle--with-deprecated-component&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-iqwftdxoka.chromatic.com/?path=/story/all-components-settingtoggle--with-deprecated-component)
Configuration menu - View commit details
-
Copy full SHA for 27422af - Browse repository at this point
Copy the full SHA 27422afView commit details -
[Modal] Consolidate se23 styles and logic (#10139)
### WHY are these changes introduced? Resolves #9951. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Modal`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-tqhardweqn.chromatic.com/?path=/story/all-components-modal--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-modal--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 310b34b - Browse repository at this point
Copy the full SHA 310b34bView commit details -
[Tag] Consolidate se23 styles (#10141)
### WHY are these changes introduced? Resolves #9970. ### WHAT is this pull request doing? Consolidates se23 beta styles for `Tag`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-mobppokpoq.chromatic.com/?path=/story/all-components-tag--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tag--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 8d82cc4 - Browse repository at this point
Copy the full SHA 8d82cc4View commit details -
[Avatar] Remove
shape
(#10122)### WHY are these changes introduced? Fixes #9977 ### WHAT is this pull request doing? - Removes the `shape` prop from `Avatar` as now there is only the squircle shape - Cleaned up the `Avatar` stories
Configuration menu - View commit details
-
Copy full SHA for 43b42ae - Browse repository at this point
Copy the full SHA 43b42aeView commit details -
[Popover] consolidate se23 styles and logic (#10114)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9958 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - `Popover` consolidate se23 logic - `Popover` consolidate se23 styles ### How to 🎩 - [Storybook](https://5d559397bae39100201eedc1-qinvshnolg.chromatic.com/?path=/story/all-components-popover--all) - [Production storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-popover--all&globals=polarisSummerEditions2023:true) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 3ed1146 - Browse repository at this point
Copy the full SHA 3ed1146View commit details
Commits on Aug 22, 2023
-
[TextField] consolidate se23 styles and logic (#10134)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9972 ### WHAT is this pull request doing? - `TextField` consolidate se23 logic - `TextField` consolidate se23 styles ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [Storybook](https://5d559397bae39100201eedc1-ijxwodqxyd.chromatic.com/?path=/story/all-components-textfield--all) - [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--all&globals=polarisSummerEditions2023:true)
Configuration menu - View commit details
-
Copy full SHA for 210f212 - Browse repository at this point
Copy the full SHA 210f212View commit details -
[ShadowBevel] Consolidate conditional logic (#10144)
### WHY are these changes introduced? Fixes #9965 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `ShadowBevel` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same * `polarisSummerEditions2023ShadowBevelOptOut` toggle shouldn't do anything now [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-shadowbevel--default&globals=polarisSummerEditions2023:true) [This PR]()
Configuration menu - View commit details
-
Copy full SHA for 4de0f6a - Browse repository at this point
Copy the full SHA 4de0f6aView commit details -
[Tabs] Consolidate se23 logic and styles (#10158)
### WHY are these changes introduced? Resolves #9969. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Tabs`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-wlmykaxxmr.chromatic.com/?path=/story/all-components-tabs--all) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tabs--all&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 92c3d96 - Browse repository at this point
Copy the full SHA 92c3d96View commit details -
[Button] Replace booleans with new props (#10090)
### WHY are these changes introduced? Fixes #10047 ### WHAT is this pull request doing? - Adds `variant` and `tone` props - Removes `primary`, `outline`, `plain`, `monochrome`, and `primarySuccess` booleans - Updates props on usages of `Button` - Renames `primaryPlain` variant to `tertiary`
Configuration menu - View commit details
-
Copy full SHA for 4caed28 - Browse repository at this point
Copy the full SHA 4caed28View commit details -
[Pagination/ButtonGroup] Consolidate se23 logic and styles (#10160)
### WHY are these changes introduced? Resolves #9957. Fixes #10159. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Pagination`. Fixes focus ring issue on ButtonGroup due to `clip-path` styles. ### How to 🎩 [Pagination Storybook](https://5d559397bae39100201eedc1-yzawhweukw.chromatic.com/?path=/story/all-components-pagination--default) [Pagination Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-pagination--default&globals=polarisSummerEditions2023:true) [ButtonGroup Storybook](https://5d559397bae39100201eedc1-yzawhweukw.chromatic.com/?path=/story/all-components-buttongroup--with-segmented-buttons) [ButtonGroup Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-buttongroup--with-segmented-buttons&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 2599024 - Browse repository at this point
Copy the full SHA 2599024View commit details -
[VideoThumbnail] Consolidate se23 styles (#10162)
### WHY are these changes introduced? Resolves #9976. ### WHAT is this pull request doing? Consolidates se23 beta styles for `VideoThumbanil`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-haozjmfzql.chromatic.com/?path=/story/all-components-videothumbnail--all) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-videothumbnail--all&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 3f622e0 - Browse repository at this point
Copy the full SHA 3f622e0View commit details
Commits on Aug 23, 2023
-
[TooltipOverlay] Consolidate se23 styles and logic (#10167)
### WHY are these changes introduced? Resolves #9974. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `TooltipOverlay`. Updates copy for keyboard nav tooltips in `Pagination` to match copy in admin. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-tewmslxdlb.chromatic.com/?path=/story/all-components-tooltip--all) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tooltip--all&globals=polarisSummerEditions2023:true) [Pagination Storybook](https://5d559397bae39100201eedc1-tewmslxdlb.chromatic.com/?path=/story/all-components-pagination--with-keyboard-navigation) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 747da30 - Browse repository at this point
Copy the full SHA 747da30View commit details -
[Button] Remove
destructive
boolean (#10164)### WHY are these changes introduced? Fixes #0000 <!-- link to issue if one exists --> ### WHAT is this pull request doing? Removes `destructive` boolean prop from `Button`
Configuration menu - View commit details
-
Copy full SHA for af9f264 - Browse repository at this point
Copy the full SHA af9f264View commit details -
[FullscreenBar] Consolidate conditional logic (#10173)
### WHY are these changes introduced? Fixes #9937 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `FullscreenBar` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-fullscreenbar--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-duqojrtsgy.chromatic.com/?path=/story/all-components-fullscreenbar--all)
Configuration menu - View commit details
-
Copy full SHA for b3b6c2e - Browse repository at this point
Copy the full SHA b3b6c2eView commit details -
[ResourceItem] Consolidate conditional logic (#10172)
### WHY are these changes introduced? Fixes #9961 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `ResourceItem` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-ganribjzxv.chromatic.com/?path=/story/all-components-resourceitem--default)
Configuration menu - View commit details
-
Copy full SHA for ac25410 - Browse repository at this point
Copy the full SHA ac25410View commit details -
[Thumbnail] Consolidate conditional logic (#10171)
### WHY are these changes introduced? Fixes #9973 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `Thumbnail` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-thumbnail--all&globals=polarisSummerEditions2023:true) [This PR]()
Configuration menu - View commit details
-
Copy full SHA for ee95a57 - Browse repository at this point
Copy the full SHA ee95a57View commit details -
[DataTable] Consolidate conditional logic (#10169)
### WHY are these changes introduced? Fixes #9930 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for `DataTable` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datatable--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-bhdulauigv.chromatic.com/?path=/story/all-components-datatable--default)
Configuration menu - View commit details
-
Copy full SHA for 3a19bb9 - Browse repository at this point
Copy the full SHA 3a19bb9View commit details -
[Page] Consolidate se23 styles and logic (#10187)
### WHY are these changes introduced? Resolves #9954. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Page`. Removes `divider` prop as the styles were modified to reset pre-uplift styles in an earlier [PR](#9537). ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-rojuobnovi.chromatic.com/?path=/story/all-components-page--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 8755b46 - Browse repository at this point
Copy the full SHA 8755b46View commit details
Commits on Aug 24, 2023
-
[OptionList] consolidate se23 styles and logic (#10177)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9953 Fixes #10197 ### WHAT is this pull request doing? - `OptionList` consolidate se23 logic - `OptionList` consolidate se23 styles - Remove custom `Checkbox` component in favour of the standard Polaris Checkbox - Removes the `optionRole` prop from the `OptionList` component. This is presently being used to toggle the `presentation` role on the custom checkbox input. This PR removes this prop for a few reasons: - Its no longer used, since the custom Checkbox has been deleted. - The functionality it was providing (toggling presentation role) doesn't seem to be [supported by browsers](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/presentation_role). The browser ignores the `presentation` role on all focusable elements (including inputs). See excerpt from MDN below - A cursory [Grokt](https://grokt.shopify.io/results?q=optionRole) search, rules out internal usage of this prop ![Screenshot 2023-08-23 at 10 16 07 am](https://github.com/Shopify/polaris/assets/12119389/fbf6718b-ad35-46ee-ad00-6c79840ff02b) ### How to 🎩 - Storybook - Prod storybook ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 9621658 - Browse repository at this point
Copy the full SHA 9621658View commit details -
[Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196)
### WHY are these changes introduced? Fixes #9936 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `Frame` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-frame--in-an-application&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-rtnpgpgkqd.chromatic.com/?path=/story/all-components-frame--in-an-application)
Configuration menu - View commit details
-
Copy full SHA for aeee471 - Browse repository at this point
Copy the full SHA aeee471View commit details -
[Navigation] Consolidate se23 logic and styles (#10213)
### WHY are these changes introduced? Resolves #9952. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Navigation`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-lecmsuzwza.chromatic.com/?path=/story/all-components-navigation--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-navigation--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 9122832 - Browse repository at this point
Copy the full SHA 9122832View commit details -
[LegacyCard] Consolidate se23 styles and logic (#10207)
### WHY are these changes introduced? Fixes #9944 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `LegacyCard` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-legacycard--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-uabmwvpwiv.chromatic.com/?path=/story/all-components-legacycard--all)
Configuration menu - View commit details
-
Copy full SHA for b585808 - Browse repository at this point
Copy the full SHA b585808View commit details -
[Button] Remove connectedDisclosure (#10182)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10126 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes all code related to connectedDisclosure Updates the split example to use Popover, ActionList, and ButtonGroup
Configuration menu - View commit details
-
Copy full SHA for e814c0e - Browse repository at this point
Copy the full SHA e814c0eView commit details -
[ButtonGroup] Update variant plain prop name (#10222)
### WHAT is this pull request doing? Update `ButtonGroup` variant styles to match the changes from #10090 ### How to 🎩 Check that this story is getting the plain button group item variant |Next branch|This PR|Production| |-|-|-| |<img width="321" alt="Screenshot 2023-08-24 at 2 36 27 PM" src="https://github.com/Shopify/polaris/assets/20652326/54bff50b-f4b1-4540-a891-7f3c4a7afaf7">|<img width="306" alt="Screenshot 2023-08-24 at 2 37 27 PM" src="https://github.com/Shopify/polaris/assets/20652326/3dd5578e-51ad-4469-82fe-61db3440b936">|<img width="303" alt="Screenshot 2023-08-24 at 2 37 12 PM" src="https://github.com/Shopify/polaris/assets/20652326/7141b6a8-9589-4746-a7d7-eb9229a6c61d">|
Configuration menu - View commit details
-
Copy full SHA for 039578a - Browse repository at this point
Copy the full SHA 039578aView commit details -
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10208 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Removes `backdrop` * Replaces `color` with `tone` * Matches warning tone to warning icon color <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> --------- Co-authored-by: Sara Hill <sara.hill@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 2b0cdb2 - Browse repository at this point
Copy the full SHA 2b0cdb2View commit details -
[Filters] consolidate se23 logic and styles (#10178)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9934 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - consolidate se23 logic - consolidate se23 styles ### How to 🎩 - [Storybook](https://5d559397bae39100201eedc1-avqvvftkub.chromatic.com/?path=/story/all-components-filters--with-a-resource-list) - [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-filters--with-a-resource-list&globals=polarisSummerEditions2023:true) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 2c718dc - Browse repository at this point
Copy the full SHA 2c718dcView commit details
Commits on Aug 25, 2023
-
[TopBar] Consolidate se23 styles and logic (#10221)
### WHY are these changes introduced? Resolves #9975. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `TopBar`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-hkusscolus.chromatic.com/?path=/story/all-components-topbar--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-topbar--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 617154e - Browse repository at this point
Copy the full SHA 617154eView commit details -
Replace icon highlight color in box stories (#10226)
Didn't save the file
Configuration menu - View commit details
-
Copy full SHA for c865eff - Browse repository at this point
Copy the full SHA c865effView commit details -
[Banner] Change status prop to tone (#10206)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10050 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Changes the status prop on banner to tone
Configuration menu - View commit details
-
Copy full SHA for dad09bd - Browse repository at this point
Copy the full SHA dad09bdView commit details -
[LegacyFilters] Consolidate se23 styles and logic (#10217)
### WHY are these changes introduced? Fixes #9945 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for the `LegacyFilters` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-legacyfilters--with-a-resource-list&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-vzjpjlwiop.chromatic.com/?path=/story/all-components-legacyfilters--with-a-resource-list)
Configuration menu - View commit details
-
Copy full SHA for 3fef646 - Browse repository at this point
Copy the full SHA 3fef646View commit details -
[v12] Update changesets (#10232)
### WHY are these changes introduced? Resolves #10035. Updates existing `tall-chickens-repeat` changeset with all the component consolidation work (included any in progress/ready for review/up next/backlog PRs as well). Adds changesets for [OptionList](#10177) `optionRole` and [Page](#10187) `divider` prop removal.
Configuration menu - View commit details
-
Copy full SHA for eb2c203 - Browse repository at this point
Copy the full SHA eb2c203View commit details -
[LegacyTabs] Consolidate se23 styles and logic (#10231)
### WHY are these changes introduced? Resolves #9946. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `LegacyTabs`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-yxlghuvhen.chromatic.com/?path=/story/all-components-legacytabs--all) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-legacytabs--all&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 776f28a - Browse repository at this point
Copy the full SHA 776f28aView commit details -
[ButtonGroup] Removed
segmented
boolean prop and replaced with `var……iant` (#9997) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9981 Removing boolean props from various components. Renaming spacing prop to `gap` for consistency <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Replaces the `segmented` boolean prop with a `variant='segmented'` prop * Updates `ButtonGroup` story * Updates css attributed selector in `Button` to match `variant='segmented'` * Renames `spacing` to `gap` <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 Review in storybook, there should be no visual changes 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: kyledurand <kyle.durand@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for b59fc9e - Browse repository at this point
Copy the full SHA b59fc9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8774e04 - Browse repository at this point
Copy the full SHA 8774e04View commit details -
Remove shadow-bevel opt out logic (#10234)
### WHY are these changes introduced? Resolves #10194. Removes shadow bevel opt out logic (except for storybook as that's a separate issue). ### How to 🎩 [Banner Storybook](https://5d559397bae39100201eedc1-tnqlfybcue.chromatic.com/?path=/story/all-components-banner--all) [Banner Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-banner--all&globals=polarisSummerEditions2023:true) [AppProvider Storybook](https://5d559397bae39100201eedc1-tnqlfybcue.chromatic.com/?path=/story/all-components-appprovider--default) [AppProvider Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-appprovider--default&globals=polarisSummerEditions2023:true) > Note: small spacing diff in Banner all story is expected because it was updated in `next`. Story matches what's in `next`. 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for b8060ac - Browse repository at this point
Copy the full SHA b8060acView commit details -
[v11.13.0] Update
next
branch with changes frommain
(#10238)Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jess Telford <jess.telford@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Joel Warrington <joel.warrington@shopify.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Lavoie <44816587+m4thieulavoie@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Ash <siavash.etemadieh@shopify.com> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxime Cloutier <maxime.cloutier@shopify.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Peter Lazzarino <peter.lazzarino@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for b17d23d - Browse repository at this point
Copy the full SHA b17d23dView commit details -
Consolidate se23 in the rest of stories (#10241)
Some `.stories` files had left over se23 logic. This cleans them up!
Configuration menu - View commit details
-
Copy full SHA for 296ebcf - Browse repository at this point
Copy the full SHA 296ebcfView commit details -
[SkeletonThumbnail][SkeletonPage] Consolidate se23 conditional logic (#…
…10143) ### WHY are these changes introduced? Fixes #9966 Fixes #9967 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for `SkeletonThumbnail` Component * Consolidate se23 logic and styles for `SkeletonPage` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production skeleton page](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonpage--with-dynamic-content&globals=polarisSummerEditions2023:true) [This PR skeleton page](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonpage--with-dynamic-content) [Production skeleton thumbnail](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonthumbnail--all&globals=polarisSummerEditions2023:true) [This PR skeleton thumbnail](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonthumbnail--all)
Configuration menu - View commit details
-
Copy full SHA for 075cf34 - Browse repository at this point
Copy the full SHA 075cf34View commit details -
Consolidate the rest of se23 scss styles (#10239)
### WHAT is this pull request doing? * Consolidates `se23` styles in scss files that were either missed or added back in as part of bad rebases * Renames stylelint comments that include `se23` ### How to 🎩 Tophatting links are in the file changes per component
Configuration menu - View commit details
-
Copy full SHA for b14efbb - Browse repository at this point
Copy the full SHA b14efbbView commit details
Commits on Aug 28, 2023
-
Update changeset config to reflect changes from main (#10253)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? #10238 merged in changes from main, inclusive of removing the `polaris-cli` and `polaris-codemods` packages. Unfortunately these changes were not reflected in the changeset config resulting in errors when running `yarn changeset` due to ignores being set up for the aforementioned removed packages. Error: ![Screenshot 2023-08-28 at 11 06 56 am](https://github.com/Shopify/polaris/assets/12119389/143d9e19-375d-4f37-a591-dd2d46511cca) <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Removes removed packages (`polaris-cli` `polaris-codemods`) from changest config ignore. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 Run `yarn changeset` locally on branch.
Configuration menu - View commit details
-
Copy full SHA for 7aef08b - Browse repository at this point
Copy the full SHA 7aef08bView commit details -
Filters
remove unused disabled states and styles from FilterPill (#……10228) Fixes #10227 ### WHAT is this pull request doing? * Removes unused disabled states in `FilterPill.scss` * Removes unused disabled states in `FilterPill.tsx` <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for e18ca90 - Browse repository at this point
Copy the full SHA e18ca90View commit details -
[IndexFilters] consolidate se23 styles and logic (#10230)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9938 ### WHAT is this pull request doing? * Consolidate se23 styles * Consolidate se23 logic * Remove custom `FilterButton` and replace it with direct invocations of the Polaris Button instead. This seems safe to do because: * even though we export `FilterButton` from the root of `IndexFilters`, we do not actually expose it directly from the `polaris-react` [entrypoint](https://github.com/Shopify/polaris/blob/2c718dc3ecf9393119cd1e08c387b648db78449a/polaris-react/src/index.ts#L190). * AFAIK, noone is reaching into our cjs/esm builds to grab`FilterButton` (see [grokt](https://grokt.shopify.io/results?q=%40shopify%2Fpolaris%2F.*%2Fcomponents%2FIndexFilters)) * Just to be sure, also doesn't look like anyone is importing `FilterButton` from @shopify/polaris either. (see [grokt](https://grokt.shopify.io/results?q=FilterButton)) * That said I can see an argument being made for providing convenience wrappers to alleviate repetitive config, so deferring to the team. 👍 Happy to revert if necessary 👍 ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for a573e55 - Browse repository at this point
Copy the full SHA a573e55View commit details -
[CI][Tests] Consolidate se23 tests (#10243)
### WHY are these changes introduced? Part of #10191 ### WHAT is this pull request doing? - Force test providers to `polarisSummerEditions2023: true`, this is temporary until we clean up the AppProvider - Delete `.github/workflows/ci.yml` - Rename `.github/workflows/ci-experimental.yml` to `.github/workflows/ci.yml` - Consolidate any tests that use the flag ### Tophat - Make sure there isn't an experimental CI check anymore and that CI passes
Configuration menu - View commit details
-
Copy full SHA for b18e92b - Browse repository at this point
Copy the full SHA b18e92bView commit details -
[Storybook] Consolidate se23 feature toggles (#10242)
### WHY are these changes introduced? Part of #10191 <img width="1276" alt="Screenshot 2023-08-25 at 1 28 07 PM" src="https://github.com/Shopify/polaris/assets/20652326/9e245dd7-ebab-4225-92c7-4438f2f986e2"> ### WHAT is this pull request doing? - Delete`.github/workflows/ci-a11y-vrt.yml` - Rename `.github/workflows/ci-a11y-vrt-experimental.yml` to `.github/workflows/ci-a11y-vrt.yml` - Removes feature toggles from storybook > Note: I kept the panel and features object so that we can easily add them back in the future ### Tophat - Make sure storybook on the PR is with the feature flag on - Make sure the toggles are not there anymore - Make sure there isn't an experimental Accessibility and visual regression check anymore and that CI passes
Configuration menu - View commit details
-
Copy full SHA for cdd0ba0 - Browse repository at this point
Copy the full SHA cdd0ba0View commit details -
Consolidate the rest of se23 jsx logic (#10244)
### WHAT is this pull request doing? * Consolidates `se23` logic in tsx files that were either missed or added back in as part of bad rebases ### How to 🎩 Tophatting links are in the file changes per component
Configuration menu - View commit details
-
Copy full SHA for 695fb28 - Browse repository at this point
Copy the full SHA 695fb28View commit details
Commits on Aug 29, 2023
-
[Styles] Consolidate se23 styles (#10255)
### WHY are these changes introduced? Resolves #10254. ### WHAT is this pull request doing? Clean up .scss files that were still referencing se23 in stylelint comments. Clean up old variables in ResourceItem that were created for se23 but we can just use the values directly now. Consolidate se23 logic for **new ActionList subcomponent SearchField** (didn't exist when we previously consolidated ActionList): - Clean up se23 logic in SearchField.scss - Add new story to show ActionList with search field - Fix focus-ring issue on SearchField ### How to 🎩 [New ActionList with Search story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-actionlist--with-search) [ResourceItem story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-resourceitem--default) [ResourceItem story prod](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 15447ec - Browse repository at this point
Copy the full SHA 15447ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a10b94 - Browse repository at this point
Copy the full SHA 1a10b94View commit details -
[Text] Rename color prop as tone (#10266)
Closes #10267 - [x] Change color to tone - [x] Map warning to caution
Configuration menu - View commit details
-
Copy full SHA for 22a51ea - Browse repository at this point
Copy the full SHA 22a51eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for abeef7a - Browse repository at this point
Copy the full SHA abeef7aView commit details
Commits on Aug 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b9bcaef - Browse repository at this point
Copy the full SHA b9bcaefView commit details -
[Page Header] Remove additionalNavigation prop (#10271)
Closes #10247 Low hanging fruit, not used in web, not mentioned in coverage site either https://coverage.polaris.shopify.io/usage/component?repo=shopify%2Fweb&type=components&element=%3CPage%3E
Configuration menu - View commit details
-
Copy full SHA for 1125087 - Browse repository at this point
Copy the full SHA 1125087View commit details -
[ResourceItem] Fix broken focus ring styles (#10268)
### WHY are these changes introduced? Resolves #10175. Focus ring was broken on ResourceItem prior to uplift and was flagged during se23 clean up. ### WHAT is this pull request doing? Fixes minor issue on ResourceList.stories.tsx where LegacyCard was not using the correct border radius on xs screens (should match IndexTable where border-radius is set to `0` for xs screens). Fixes focus ring styles by opting to use `offset` property as opposed to the `focus-ring` mixin. <details> <summary>ResourceItem focus state — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/0f2fc337-34d5-483d-b62b-df907277ff22" alt="ResourceItem focus state — before"> </details> <details> <summary>ResourceItem focus state — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/383eb27e-0c2b-40d4-ab90-52205312ce73" alt="ResourceItem focus state — after"> </details> ### How to 🎩 [ResourceItem Storybook](https://5d559397bae39100201eedc1-egkosgfazl.chromatic.com/?path=/story/all-components-resourceitem--default) [ResourceItem Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) [BulkActions Storybook](https://5d559397bae39100201eedc1-egkosgfazl.chromatic.com/?path=/story/all-components-resourcelist--with-bulk-actions) [BulkActions Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-resourcelist--with-bulk-actions&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for dbe3d9e - Browse repository at this point
Copy the full SHA dbe3d9eView commit details
Commits on Aug 31, 2023
-
Replace custom field with TextField (#10262)
### WHY are these changes introduced? Closes Shopify/app-ui#395 This implementation was initially done using a custom SearchField because TextField caused a circular dependency in ActionList. This is no longer a problem so I switched the custom SearchField for the TextField to delete duplication ### How to 🎩 - Run the playground and add items to the "more actions" of the DetailsPage so it reaches more than 8 - Make sure the search input still displays properly and filters the items as expected
Configuration menu - View commit details
-
Copy full SHA for f6e6606 - Browse repository at this point
Copy the full SHA f6e6606View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d3c00 - Browse repository at this point
Copy the full SHA 10d3c00View commit details
Commits on Sep 1, 2023
-
Button
deprecate props (#10299)### WHY are these changes introduced? We are moving away from the boolean props for `Button` styling in favour of variants ### WHAT is this pull request doing? Deprecates the `removeUnderline` prop
Configuration menu - View commit details
-
Copy full SHA for f180999 - Browse repository at this point
Copy the full SHA f180999View commit details
Commits on Sep 5, 2023
-
[Badge] Update props and tokens (#10307)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes https://github.com/Shopify/polaris/issues/10277ds <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Replaces status prop with tone Removes experimental prefix from values
Configuration menu - View commit details
-
Copy full SHA for e2b4d2c - Browse repository at this point
Copy the full SHA e2b4d2cView commit details
Commits on Sep 6, 2023
-
Update translations: #10307 (#10346)
This PR adds async translations requested in #10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for dd16b5a - Browse repository at this point
Copy the full SHA dd16b5aView commit details -
Add
Button
migration instructions (#10295)### WHY are these changes introduced? Part of #10161 ### WHAT is this pull request doing? Adds instructions to run the `Button` migration
Configuration menu - View commit details
-
Copy full SHA for 37670dd - Browse repository at this point
Copy the full SHA 37670ddView commit details
Commits on Sep 7, 2023
-
Update translations: #10307 (#10359)
This PR adds async translations requested in #10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 926626c - Browse repository at this point
Copy the full SHA 926626cView commit details -
[polaris.shopify.com] Use
MDX
to render markdown (#10214)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? We want to leverage MDX to support richer content in our documentation site. MDX will allow us to easily create and use customized components to be used in `.md` files, and greatly simplifies our rendering and templating process. ###
⚠️ Disclaimer⚠️ This is merging into the `next` branch in order to minimize merge conflicts with `v12` work We want to merge in this PR in its current state in order to unblock documentation writing for component updates. In order to get things unblocked as quickly as possible, we are leaving some pages/builds broken intentionally while we complete the migration. Known issues include: * parts of some patterns pages are broken because they are referencing the names of old layout components that are in the process of renaming and api changes * some styling throughout the site may be a bit wonky while we migrate scss files and components To see a list of minor issues please refer to the [project backlog](https://github.com/orgs/Shopify/projects/2250/views/118?type=beta) <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * replacing `react-markdown` with `next-mdx-remote` for our markdown renderer * removing most of the old `<!-- [component] -->` usages and swapping them out for mdx components ``` <!-- dodont --> // becomes <DoDont></DoDont> // in .md files ``` * makes various content changes to `.md` files to make sure they are compatible with MDX * Start to replace/rebuild/create some components using `polaris-react` layout primitives <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 1. Run the `dev` process for the website 2. Click through the website and make sure pages are working 3. Make note of the above known issues. If you discover another issue that isn't already documented please open an issue in the [backlog](https://github.com/orgs/Shopify/projects/2250/views/118?type=beta) and leave a comment in the PR 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Jess Telford <jess.telford@shopify.com> Co-authored-by: Charles Lee <charles.lee@shopify.com> Co-authored-by: Lo Kim <lo.kim@shopify.com>Configuration menu - View commit details
-
Copy full SHA for 315fd36 - Browse repository at this point
Copy the full SHA 315fd36View commit details
Commits on Sep 8, 2023
-
[Docs] Component index pages rendered with generic MDX route (#10377)
Fixes #10364 Removing more unnecessary route handlers now that we have generic MDX rendering on `pages/[...slug]` 🎉 Also picked up a couple little fixes (as seperate commits in this PR) along the way. `/components` <img width="581" alt="Screenshot 2023-09-08 at 4 34 23 pm" src="https://github.com/Shopify/polaris/assets/612020/849e5832-e49e-422d-8d1b-b2811fe98de9"> `/components/<category>` <img width="586" alt="Screenshot 2023-09-08 at 4 34 43 pm" src="https://github.com/Shopify/polaris/assets/612020/c741dfcf-6b8a-4f15-82aa-d51c612b47f3">
Configuration menu - View commit details
-
Copy full SHA for 7e0aa71 - Browse repository at this point
Copy the full SHA 7e0aa71View commit details
Commits on Sep 11, 2023
-
[v11.16.0] Update
next
branch with changes frommain
(#10382)Updates `next` branch with latest changes from `main`. - Resolves conflicts - Updates renamed components or breaking prop changes ([commit](fb5bc9b)) - Updates any new se23 styles or logic ([commit](e6784cd)) > 🚨 Please verify that changes in the last linked commit above look as expected in [storybook](https://5d559397bae39100201eedc1-autktgiyhr.chromatic.com/?path=/story/playground--details-page). --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jess Telford <jess.telford@shopify.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Joel Warrington <joel.warrington@shopify.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: Matt Lavoie <44816587+m4thieulavoie@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Ash <siavash.etemadieh@shopify.com> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxime Cloutier <maxime.cloutier@shopify.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Peter Lazzarino <peter.lazzarino@shopify.com> Co-authored-by: James Highfield <james.highfield@shopify.com> Co-authored-by: Marten Bjork <marten.bjork@shopify.com> Co-authored-by: Joe Thomas <joe.thomas@shopify.com> Co-authored-by: zak warsame <42528878+zakwarsame@users.noreply.github.com> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Marc Thomas <marc.thomas@shopify.com> Co-authored-by: Laura Griffee <laura@mailzone.com>
Configuration menu - View commit details
-
Copy full SHA for 86d4040 - Browse repository at this point
Copy the full SHA 86d4040View commit details -
[polaris.shopify.com] Fix
/patterns
page styling (#10384)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10366 - replace `VerticalStack` with `BlockStack` in patterns examples <!-- link to issue if one exists --> Also fixes: * `/patterns` status banner spacing * hydration error due to whitespace in second Lede <!-- Context about the problem that’s being addressed. --> <img width="2032" alt="Screenshot 2023-09-08 at 12 59 59 PM" src="https://github.com/Shopify/polaris/assets/4642404/3ca77108-34cf-491e-8cf4-b052c6fa547d"> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Lo Kim <lo.kim@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for e86b2ff - Browse repository at this point
Copy the full SHA e86b2ffView commit details
Commits on Sep 12, 2023
-
[IndexTable] consolidate se23 styles and logic (#10340)
### WHY are these changes introduced? Fixes #9939 ### WHAT is this pull request doing? - `IndexTable` consolidate se23 logic - `IndexTable` consolidate se23 styles ### How to 🎩 - [Storybook](https://5d559397bae39100201eedc1-jsgyqvgaeb.chromatic.com/?path=/story/all-components-indextable--with-all-of-its-elements) - [Production storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-indextable--with-all-of-its-elements&globals=polarisSummerEditions2023:true) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 50dd08b - Browse repository at this point
Copy the full SHA 50dd08bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8be536 - Browse repository at this point
Copy the full SHA c8be536View commit details -
Configuration menu - View commit details
-
Copy full SHA for 356f373 - Browse repository at this point
Copy the full SHA 356f373View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab62159 - Browse repository at this point
Copy the full SHA ab62159View commit details -
Stabilize layout components (#10381)
### WHY are these changes introduced? Fixes #9978
Configuration menu - View commit details
-
Copy full SHA for 4bda94f - Browse repository at this point
Copy the full SHA 4bda94fView commit details -
Replace
<!-- colors -->
withColors
MDX component (#10401)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10146 <!-- link to issue if one exists --> <img width="2032" alt="Screenshot 2023-09-11 at 4 16 37 PM" src="https://github.com/Shopify/polaris/assets/4642404/f4f7865b-4d01-47ea-87b4-efc38d7c0585"> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Migrating the `<!-- colors -->` directive from `makdown.mjs` to MDX renderer <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 1. `yarn run dev` 2. navigate to [`/design/colors`](http://localhost:3000/design/colors) 3. The color palette should load on the page.
⚠️ The `<h3>` styling of the color titles doesn't currently match what's on prod. We'll fix this in a bigger sweep of styling regressions in a future PR 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Jess Telford <jess.telford@shopify.com>Configuration menu - View commit details
-
Copy full SHA for f16ea4a - Browse repository at this point
Copy the full SHA f16ea4aView commit details
Commits on Sep 13, 2023
-
Add some documentation about polaris.shopify.com (#10424)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? A very small bit of documentation to start introducing the concepts of how polaris.shopify.com content writing/rendering works <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Lo Kim <lo.kim@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 1b5d10e - Browse repository at this point
Copy the full SHA 1b5d10eView commit details -
Use markdown
img
in/design/space
(#10431)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes https://github.com/Shopify/polaris/issues/10348<!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Converting the html image to a markdown image. HTML images do not receive markdown styling so converting to markdown applies the expected styling <img width="2032" alt="Screenshot 2023-09-13 at 10 11 17 AM" src="https://github.com/Shopify/polaris/assets/4642404/863abce8-498e-4582-90be-041e6b30a242"> <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for 3bd5b65 - Browse repository at this point
Copy the full SHA 3bd5b65View commit details -
Add Table of Contents to top-level
index.md
content files (#10452)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10367 <!-- link to issue if one exists --> Not all `index.md` files need to show the TOC, but there are a few that do so we're going to pass a new `showTOC` prop in the frontmatter to enable this <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * add TOC prop to .md frontmatter * pass showTOC prop to catchAllTemplate <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for 4f6bb6a - Browse repository at this point
Copy the full SHA 4f6bb6aView commit details
Commits on Sep 14, 2023
-
Fix renamed component redirects (#10408)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10107
Configuration menu - View commit details
-
Copy full SHA for 3d218e5 - Browse repository at this point
Copy the full SHA 3d218e5View commit details -
[TOC] Fix bug to render TOC on section content pages (#10473)
### WHY are these changes introduced? Fixes #10472. Fixes issue where Table of Contents was not rendering on content pages. ### WHAT is this pull request doing? Updates conditional logic to render TOC on content pages. Adds in missing title and description on Polaris-Migrator page. Resolves console warning regarding source element `srcset` attribute. <details> <summary>Warning example</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/d68f9e91-5871-40bf-8f08-d40c9632bd76" alt="Warning example"> </details> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 810212d - Browse repository at this point
Copy the full SHA 810212dView commit details -
[Avatar] Remove customer prop and experiemntal values (#10283)
### WHY are these changes introduced? Fixes #9977 ### WHAT is this pull request doing? - [x] Remove `customer` boolean prop (make the default) - [x] Remove `-experimental` from `size` prop - [x] Update Avatar stories - [x] Update Avatar documentation examples - [x] Update `v12` migration guide - [x] Write migration for `Avatar` prop changes - [x] remove `customer` prop - [x] `size` prop mapping ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 42ee9f4 - Browse repository at this point
Copy the full SHA 42ee9f4View commit details -
Remove
max-width
from Lede (#10449)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10154 <!-- link to issue if one exists --> This change matches what is currently on prod <img width="2032" alt="Screenshot 2023-09-13 at 1 01 12 PM" src="https://github.com/Shopify/polaris/assets/4642404/e45d2aa2-7baa-4c6f-b83a-e9aa14250870"> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 46627ec - Browse repository at this point
Copy the full SHA 46627ecView commit details -
[Docs] fix pattern page spacing (#10425)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10198 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Overrides components specified in Markdown.tsx, with `NoMargin` classname applied in `PatternPage.tsx`. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for dea82b6 - Browse repository at this point
Copy the full SHA dea82b6View commit details
Commits on Sep 15, 2023
-
Docs
update CodeVisibilityProvider to properly inherit from parent ……context (#10467) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10400 <!-- link to issue if one exists --> ### WHAT is this pull request doing? Change the type signature of CodeVisibilityContext values ```diff - [bool, (arg: bool) => void] + { showCode?: bool, setShowCode?: (arg: bool) => void } ``` This is to ensure that we don't end up always inheriting the default values set by our createContext invocation for `CodeVisibilityContext` Changed the value instantiation for the CodeVisiblityProvider in Markdown.tsx ```diff -[ - codeVisibleFromContext ?? showCode, - setShowCodeFromContext ?? setShowCode -] +{ + showCode: typeof codeVisibleFromContext !== undefined ?? showCode, + setShowCode: setShowCodeFromContext ?? setShowCode, +} ``` To ensure that we also respect and inherit explicit `false` values when set in the parent context. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 4e884ee - Browse repository at this point
Copy the full SHA 4e884eeView commit details -
[Docs][Patterns] Fix
dl
styling inDefinitionTable
(#10469)### WHY are these changes introduced? Fixes #10369. ### WHAT is this pull request doing? Fixes selector for `dl` styling inside `DefinitionTable` class for patterns pages. <details> <summary>Before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/119e5370-3810-488a-93a5-8f09a3b7fb19" alt="Before"> </details> <details> <summary>After</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/3b7d9d5a-1146-49ca-8e2d-1c9f3709ef50" alt="After"> </details> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for c6f8221 - Browse repository at this point
Copy the full SHA c6f8221View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0407409 - Browse repository at this point
Copy the full SHA 0407409View commit details
Commits on Sep 18, 2023
-
Move level 3 nav items to page subnav (#10509)
Closes #10151 Creates a `Subnav` component that will inject subnav items into the MDX. We could also probably add this to the `Lede` component, but it is currently a standalone component. > [!Note] > The styles aren't updated, but are scaffolded to be quickly updated with the Uplift colors and Figma spec ```mdx <Lede>{title}</Ledel> <Subnav /> ``` ### Screenshot example using Typography <img width="1471" alt="subnav-proto" src="https://github.com/Shopify/polaris/assets/11774595/270a00d8-15f9-484b-a5d5-de8fd162eb6f">
Configuration menu - View commit details
-
Copy full SHA for de5b7fa - Browse repository at this point
Copy the full SHA de5b7faView commit details -
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10150 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> Create a light-weight card component with the following: * responsive prop for `padding` * optional `className` prop for overrides. ### Things I've left out: * `roundedAbove` breakpoints are subtly different in polaris-react vs polaris.shopify.com, so porting this functionality over is not a straightforward exercise. I think the right call is to get the MVP lightweight card in so we can start using and iterating. We can add breakpoint parity in in a separate PR. * `backgroundColor`, not sure we need this one given the screenshots and designs in the linked issue, but happy to add this in later if I'm mistaken 👍 ### Things that are subtly different: * In polaris-react `padding` is just a mirror of the responsiveProp functionality in`Box`, in this PR I've chosen to have that functionality localized to `Card` for now, to avoid having to worry about accidentally breaking `polaris.shopify.com` Box usage in other areas of the docs. (not a strongly held opinion though) ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 4839088 - Browse repository at this point
Copy the full SHA 4839088View commit details
Commits on Sep 19, 2023
-
Remove nav level rule (#10568)
Remove the max level rule in the Frame nav and use the `hideChildren` boolean in frontmatter
Configuration menu - View commit details
-
Copy full SHA for 4aee4f5 - Browse repository at this point
Copy the full SHA 4aee4f5View commit details -
[Docs] Update Table of Contents (#10542)
### WHY are these changes introduced? Resolves #10463. Updates TOC styling based off [Figma](https://www.figma.com/file/vO0wToyBpYjeIwr8doAAWT/Uplift-polaris.shopify.com?type=design&node-id=53%3A2996&mode=design&t=RwCrRixcmvNZ3XHy-1). ### WHAT is this pull request doing? Updates TOC styling. Uses polaris tokens where applicable (instead of style guide tokens) <details> <summary>TOC — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/1060d9ed-8941-4dd2-bdd1-9a3f066394e5" alt="TOC — before"> </details> <details> <summary>TOC — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/f9e3d48f-022b-4b23-ba4b-2a07e48253ee" alt="TOC — after"> </details> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 95444e1 - Browse repository at this point
Copy the full SHA 95444e1View commit details -
[Docs] Update StatusBadge (#10562)
### WHY are these changes introduced? Resolves #10457. Updates StatusBadge component to align with uplifted Polaris Badge component. ### WHAT is this pull request doing? Updated the existing StatusBadge component. The original intent was to replace it with the Polaris Badge component, but it requires wrapping StatusBadge in an AppProvider so I've updated the StatusBadge to align with the Polaris Badge component instead. StatusBadge was also updated to use polaris-tokens wherever applicable instead of style guide tokens. <details> <summary>Example of all status badges for testing purposes</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/3859176c-01ef-4339-938c-e69ca7d64c9e" alt="Example of all status badges"> </details> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 9be8b40 - Browse repository at this point
Copy the full SHA 9be8b40View commit details -
Tjonx/add color section (#10578)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #0000 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for f833921 - Browse repository at this point
Copy the full SHA f833921View commit details
Commits on Sep 20, 2023
-
Update
next
branch with changes frommain
(#10572)Updates `next` branch with latest changes from `main`. 1. `git merge main` into a `next` branch 2. Resolve conflicts by manually going through `main` commits and `next` commits to gain context and take what was needed 3. Solved any typescript errors including net new migrated components (e.g. I renamed net new `HorizontalStack`s to `InlineStack`, any net new button props I manually migrated) 4. Consolidated net new se23 styles 5. Made sure storybook ran as expected 6. Made sure doc website ran as expected > 🚨 Please verify that changes in the last linked commit above look as expected in storybook (see CI for link)
Configuration menu - View commit details
-
Copy full SHA for d78a7e2 - Browse repository at this point
Copy the full SHA d78a7e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02c15b3 - Browse repository at this point
Copy the full SHA 02c15b3View commit details -
Update
Button
examples with new variants (#10543)### WHY are these changes introduced? Fixes #10165 ### WHAT is this pull request doing? Removes `Button` examples for `plain monochrome` and `destructive` and adds examples for `tertiary` and `primary critical`.
Configuration menu - View commit details
-
Copy full SHA for b3c83f9 - Browse repository at this point
Copy the full SHA b3c83f9View commit details -
[Avatar] Add back
customer
prop (#10584)Added back the `customer` prop to support the gray + customer icon combination.
Configuration menu - View commit details
-
Copy full SHA for 08a0f2f - Browse repository at this point
Copy the full SHA 08a0f2fView commit details -
Remove
featured
item fromWhat's New
(#10593)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? We don't need a `featured` treatment so let's revert it to the older layout <img width="2032" alt="Screenshot 2023-09-20 at 11 28 06 AM" src="https://github.com/Shopify/polaris/assets/4642404/80142a4c-0b26-43aa-a9aa-9c4d81f293f3"> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for adab435 - Browse repository at this point
Copy the full SHA adab435View commit details -
Docs
DirectiveCard and DoDont refactor (#10581)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10571 ### WHAT is this pull request doing? - `Docs` Add DirectiveCard component, and refactor DoDont components as a composition of the DirectiveCard - `Docs` update Card styles to override last-child margin of *all* children With Image: <img width="450" alt="Screenshot 2023-09-20 at 4 21 31 pm" src="https://github.com/Shopify/polaris/assets/12119389/dd05c87c-7e99-4eee-85da-16c84b80e931"> Do Don't: <img width="894" alt="Screenshot 2023-09-20 at 4 22 04 pm" src="https://github.com/Shopify/polaris/assets/12119389/b6a53b61-f6f1-4315-ab67-2e08e75f6884"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for d505fa4 - Browse repository at this point
Copy the full SHA d505fa4View commit details -
[next] Add multi-theme support to Polaris (#10423)
Continuation of #10290 This PR contains breaking changes in both Polaris and Polaris tokens to enable global multi-theme support. ### Polaris changes: - Updated the `AppProvider` component - **Breaking:** Removed `features` class name toggle from `setRootAttributes` - Added a new `theme` prop which accepts a Polaris tokens `ThemeName`. This prop is used for: - Toggling the theme class names on the root element, and - Setting the theme object on the root `ThemeContext.Provider` - Added global theme toggle to Storybook ### Polaris tokens changes: - **Breaking:** Moved the `light-uplift` overrides to base token groups (e.g. `light-uplift` is now the default theme) - Normalized specificity of the default theme > [!NOTE] > Currently, our browser support requirements don't allow us to use the `:where()` selector to flatten our theme class name specificity to `0`. Therefore, I'm proposing a solution that normalizes the specificity to `11`. **Theme selector breakdown:** - `:root, html.p-<default-variant-theme>{...}` - The generated stylesheet outputs the default theme custom properties to both the `:root` selector and a dedicated `html.p-*` selector. This allows the page to apply the default theme via `:root` initially (specificity `10`) and then `html.p-*` when the `AppProvider` initializes (specificity `11`) - `html.p-<variant-theme-1>{...}html.p-<variant-theme-2> {...}html.p-...` - All other variant themes have specificity `11` - Thus, theme classes in the Admin should always have specificity `11` after rendering the `AppProvider` **Example** theme selector output: ![Screenshot 2023-09-12 at 3 12 07 PM](https://github.com/Shopify/polaris/assets/32409546/88166226-512c-4cd5-a1d0-b77305929d5b) - Initialized a new `light-high-contrast-experimental` theme https://github.com/Shopify/polaris/assets/32409546/ad228532-e277-4107-af5c-95511f3e3297 --------- Co-authored-by: Lo Kim <lo.kim@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 73d0fbe - Browse repository at this point
Copy the full SHA 73d0fbeView commit details
Commits on Sep 21, 2023
-
[Docs] Allow opting out of auto margin/padding with the .margin-consi…
…dered-harmful class
Configuration menu - View commit details
-
Copy full SHA for 0a4e5d6 - Browse repository at this point
Copy the full SHA 0a4e5d6View commit details -
[polaris.shopify.com] Fix subnav on small screens, add icons (#10592)
Fixes #10589 Items will now be stacked until they hit the tablet breakpoint where they go inline and wrap if necessary [Figma](https://www.figma.com/file/vO0wToyBpYjeIwr8doAAWT/Uplift-polaris.shopify.com?type=design&node-id=1033-5403&mode=design&t=e4EHp1DsbLlzqHbG-4) https://github.com/Shopify/polaris/assets/6844391/31928f7f-4c1a-4e01-a975-f04202018629
Configuration menu - View commit details
-
Copy full SHA for 907c1a6 - Browse repository at this point
Copy the full SHA 907c1a6View commit details -
Use the Do/Dont components in /design/colors and remove custom card s… (
#10597) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Swap out the custom do/dont for the new `DoDont` components with the updated styling <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Broken <img width="1624" alt="Screenshot 2023-09-20 at 2 23 26 PM" src="https://github.com/Shopify/polaris/assets/4642404/64e12bb9-b629-47f2-8ea1-f511d2709750"> After <img width="1624" alt="Screenshot 2023-09-20 at 2 24 10 PM" src="https://github.com/Shopify/polaris/assets/4642404/c83fd21e-e539-42bb-92e9-950c5b86927f"> <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 51a3cf3 - Browse repository at this point
Copy the full SHA 51a3cf3View commit details -
Docs
Box padding prop + remove text-extra-padding class (#10603)### WHY are these changes introduced? Reducing the amount of global styles we have, also improves content authoring experience, since the Box component is now closer to the Polaris implementation API and we can refer to documented token usage, rather than an undocumented global class. ### WHAT is this pull request doing? - `Docs` Move responsive padding prop implementation from Card to Box - `Docs` replace text-extra-padding class application with corresponding padding prop value on Box ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for dd56487 - Browse repository at this point
Copy the full SHA dd56487View commit details -
Add AppProvider instructions to migration guide (#10606)
Resolves #10451 I could make a migration to remove the `features` attribute from `AppProvider` but since consumers should only have a few app providers at most, a migration may be overkill. Just added a note to the migration guide instead.
Configuration menu - View commit details
-
Copy full SHA for 437a895 - Browse repository at this point
Copy the full SHA 437a895View commit details -
Add darkmode to Table of Contents (#10610)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10595 <!-- link to issue if one exists --> Matching the subnav color scheme https://github.com/Shopify/polaris/assets/4642404/8b28e8e2-be85-4332-bef8-6cf287971300 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 4248bd4 - Browse repository at this point
Copy the full SHA 4248bd4View commit details -
### WHY are these changes introduced? Resolves #10569. Follow up to feedback from recent TOC updates. ### WHAT is this pull request doing? Refactors TOC to: - use the style guide Box component instead of the Polaris Box component - use html text elements instead of the Text component Verified there are no visual differences with these changes. <details> <summary>TOC with light/dark mode</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/409cc38e-c465-4b41-8266-528231eb08d5" alt="TOC with light/dark mode"> </details> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 3f509b7 - Browse repository at this point
Copy the full SHA 3f509b7View commit details -
[polaris.shopify.com] Fix directive card image rendering (#10611)
Fixes #10607 ![localhost_3000_design_colors](https://github.com/Shopify/polaris/assets/6844391/af13c933-9438-420b-b53f-0b5c38f68c41)
Configuration menu - View commit details
-
Copy full SHA for 95b4bf5 - Browse repository at this point
Copy the full SHA 95b4bf5View commit details -
Add TOC to
design/colors/index.md
(#10612)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The TOC only shows up if the page `!isContentPage` or explicitly sets the `showTOC` prop in the frontmatter. `isContentPage` is true of any files that is not an `index.md` file (since this is how our site used to be set up). Now we have more `index.md` files that are actually content pages, including all of our `/design/topic/index.md` pages. If needed we can revisit this approach with something that is automatic <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedSep 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 27b2512 - Browse repository at this point
Copy the full SHA 27b2512View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe02c6c - Browse repository at this point
Copy the full SHA fe02c6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5043e97 - Browse repository at this point
Copy the full SHA 5043e97View commit details -
Configuration menu - View commit details
-
Copy full SHA for b037ca7 - Browse repository at this point
Copy the full SHA b037ca7View commit details
Commits on Sep 22, 2023
-
[AppProvider] Consolidate se23 logic (#10635)
### WHY are these changes introduced? Resolves #9915. Resolves #10189. Resolves #10190. Resolves #10192. Resolves #10193. Consolidates se23 logic (passing in `polarisSummerEditions2023` to `features`) in AppProvider and related components. ### WHAT is this pull request doing? Removes se23 flag from features and consolidates se23 comments. Adds comment with warning to discourage use of `se23` flag in `_common.scss`. ### How to 🎩 [Storybook]() [Next branch storybook](https://5d559397bae39100201eedc1-kzivkxiyci.chromatic.com/?path=/story/playground--details-page) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 340e36e - Browse repository at this point
Copy the full SHA 340e36eView commit details -
[Docs] Fix hydration errors (#10644)
### WHY are these changes introduced? Resolves #10629. Fixes hydration error on component page refresh or navigation from another component page. > [!NOTE] > There may be ramifications in terms of accessibility for `/design`, `/foundations`, etc pages where the <Lede> renders its children as plain text but [we have a separate issue to look into that post v12](#10645). ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for a5aa56a - Browse repository at this point
Copy the full SHA a5aa56aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc22e13 - Browse repository at this point
Copy the full SHA bc22e13View commit details
Commits on Sep 25, 2023
-
Docs
Directive Card should fill vertical space (#10652)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10634 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Add `min-height` `max-width` and `min-width` prop support to the `Box` component in docs * Allow props spreading from the `DirectiveCard` and `Card` components down to the respective `Box` component. * `Do` and `Dont` components both now have a minHeight value of `100%`. This seems like the best way to solve this within the context of the docs, the other alternative is to make adjustments to the Grid.Cell component such that its children always expand to fill its height. However that'd be an update to the Grid component which seems out of scope for this block of work. This resolves the issue as below. Before: ![Screenshot 2023-09-25 at 4 25 34 pm](https://github.com/Shopify/polaris/assets/12119389/5969bff5-53d5-4ac2-9ebb-e362cc06fab8) After: ![Screenshot 2023-09-25 at 4 28 41 pm](https://github.com/Shopify/polaris/assets/12119389/4779556c-3143-4da9-a9cc-bb3316753780) However also means that in certain layouts, due to how we're using Grid, these components will blow out to the size of the tallest Grid.Cell Before: ![Screenshot 2023-09-25 at 4 25 30 pm](https://github.com/Shopify/polaris/assets/12119389/3064992e-6904-420a-b54e-88791b406697) After: ![Screenshot 2023-09-25 at 4 28 37 pm](https://github.com/Shopify/polaris/assets/12119389/9f909bc3-bbff-445d-a13c-e0f9210f67d6) <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 870c6ee - Browse repository at this point
Copy the full SHA 870c6eeView commit details -
Docs
update Anti-pattern dodont usage in error-message page (#10651)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10624 ### WHAT is this pull request doing? * Antipattern `dont` components now render in a 2x2 Grid * Adjsuted content on the anti-pattern section such that don't text content matches the corresponding img. Before: ![Screenshot 2023-09-25 at 11 00 41 am](https://github.com/Shopify/polaris/assets/12119389/aad8a616-34a0-43b2-8082-2712368635ae) After: ![Screenshot 2023-09-25 at 11 00 48 am](https://github.com/Shopify/polaris/assets/12119389/641df9d5-6aa7-4827-8167-19bb43cd2366) ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for b8ef7a6 - Browse repository at this point
Copy the full SHA b8ef7a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ea503 - Browse repository at this point
Copy the full SHA c1ea503View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for afe81fb - Browse repository at this point
Copy the full SHA afe81fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4379cdc - Browse repository at this point
Copy the full SHA 4379cdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8468c07 - Browse repository at this point
Copy the full SHA 8468c07View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9fa9ea - Browse repository at this point
Copy the full SHA d9fa9eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ada660a - Browse repository at this point
Copy the full SHA ada660aView commit details -
[IndexTable] Fix style regressions for table with subheaders (#10683)
### WHY are these changes introduced? Resolves #10682. Resolves style regressions on IndexTable in `next` branch. ### WHAT is this pull request doing? Fixes styles for IndexTable with subheaders. <details> <summary>IndexTable subheaders — `main` branch</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/62447394-bdb6-4b3c-9497-553957a97eb7" alt="IndexTable subheaders — main branch"> </details> <details> <summary>IndexTable subheaders — `next` branch broken</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/b9955c4a-87f3-4f07-8e73-0c56b625b377" alt="IndexTable subheaders — next branch broken"> </details> <details> <summary>IndexTable subheaders — `next` branch fixed</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/e7966000-8dac-4b08-bad1-ad4b224c3bd8" alt="IndexTable subheaders — next branch fixed"> </details> ### How to 🎩 [PR storybook](https://5d559397bae39100201eedc1-lhxzpkkgvh.chromatic.com/) [Main storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-indextable--with-sub-headers&globals=polarisSummerEditions2023:true) [Next storybook](https://5d559397bae39100201eedc1-ypsjivaehn.chromatic.com/?path=/story/all-components-indextable--with-sub-headers) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide Co-authored-by: Sophie Schneider <sophie.schneider@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 50bb9a2 - Browse repository at this point
Copy the full SHA 50bb9a2View commit details -
Merge
main
at1c4bea3
intonext
(#10690)Merge `main` at `1c4bea36cc067d227d157cc4247297ae66daf7f7` into `next` following [this process](#10594) ## Commits merged from main - 1c4bea3 @sam-b-rose - 629b2ec @sam-b-rose --------- Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 63d198b - Browse repository at this point
Copy the full SHA 63d198bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f20bff0 - Browse repository at this point
Copy the full SHA f20bff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc64cd - Browse repository at this point
Copy the full SHA 0fc64cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7f7d4c - Browse repository at this point
Copy the full SHA a7f7d4cView commit details -
Merge
main
atc75c87d
intonext
(#10704)Merge `main` at `c75c87dff58bd08ec2532de9ea694f256cc07377` into `next` following [this process](#10594) ## Commits merged from main - 4ab148e @fabiormoura - 3987c0e @aveline - c75c87d @aaronccasanova --------- Co-authored-by: Fabio Maia <fabioromm@gmail.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2e610cb - Browse repository at this point
Copy the full SHA 2e610cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcdca19 - Browse repository at this point
Copy the full SHA bcdca19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6425433 - Browse repository at this point
Copy the full SHA 6425433View commit details
Commits on Sep 27, 2023
-
Banner
color token updates (#10678)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10352 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Replaces `-on-color` and `-text-[tone]-strong` tokens with `-on-bg-fill` tokens <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-sxhearubxs.chromatic.com/?path=/story/all-components-banner--all) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sara Hill <sara.hill@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 21aa79d - Browse repository at this point
Copy the full SHA 21aa79dView commit details -
### WHY are these changes introduced? Fixes #10350 ### WHAT is this pull request doing? - update color-icon-critical to colors.red[12] - `Badge` update strong and error colors @sarahill in the issue it mentions `critical-icon` as the token with a value of red[12], I'm assuming this was meant to be icon-critical, so I've updated the icon-critical token to have the value of red[12] (previously red[11]) Likewise the issue mentions: Token | Value -- | -- info-text-onfill | azure-16 success-text-onfill | green-01 caution-text-onfill | yellow-15 warning-text-onfill | orange-16 critical-text-onfill | red-01 I'm assuming you're referring to: * text-info-on-bg-fill * text-success-on-bg-fill * text-caution-on-bg-fill * text-warning-on-bg-fill * text-critical-on-bg-fill All of which have matching corresponding values. If this is not the case let me know and I'm happy to adjust 👍 ### How to 🎩 * [Storybook](https://5d559397bae39100201eedc1-kmtisnmdpu.chromatic.com/?path=/story/all-components-badge--all) <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sara Hill <sara.hill@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 4d4bf8c - Browse repository at this point
Copy the full SHA 4d4bf8cView commit details -
Docs
fix Box implementation to use more specific padding values fir……st before defaulting to the overarching padding value
Configuration menu - View commit details
-
Copy full SHA for 5f47953 - Browse repository at this point
Copy the full SHA 5f47953View commit details -
Version Packages (beta) (#10264)
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.
⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @shopify/polaris@12.0.0-beta.1 ### Major Changes - [#10122](#10122) [`43b42aefed`](43b42ae) Thanks [@aveline](https://github.com/aveline)! - Removed `shape` prop on `Avatar` component - [#10270](#10270) [`b9bcaef41`](b9bcaef) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `spacing` prop to `gap` on `List` and `DescriptionList` - [#9997](#9997) [`b59fc9e27`](b59fc9e) Thanks [@yurm04](https://github.com/yurm04)! - [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant`. Replaced `spacing` prop with `gap` - [#10100](#10100) [`4c7b2d4858`](4c7b2d4) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated `borderRadius` props to match web spec - [#10051](#10051) [`69edd97ceb`](69edd97) Thanks [@aveline](https://github.com/aveline)! - Renamed `color` prop to `tone` for `ProgressBar` component - [#10182](#10182) [`e814c0ee1a`](e814c0e) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed connectedDislosure prop on button - [#10283](#10283) [`42ee9f407`](42ee9f4) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Renamed `size` prop values for the Avatar component. See the following table for the new prop mappings. | Before | After | | ------------------------- | ----------- | | `size="extraSmall"` | `size="xs"` | | `size="small"` | `size="sm"` | | `size="medium"` | `size="md"` | | `size="large"` | `size="lg"` | | `size="xl-experimental"` | `size="xl"` | | `size="2xl-experimental"` | `size="xl"` | - [#10232](#10232) [`eb2c2035c`](eb2c203) Thanks [@laurkim](https://github.com/laurkim)! - Removed `divider` prop from `Page` component - [#10271](#10271) [`1125087b5`](1125087) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed deprecated additionalNavigation prop on Page Header - [#10164](#10164) [`af9f264b9a`](af9f264) Thanks [@aveline](https://github.com/aveline)! - Renamed `destructive` prop to `tone` for `Button` component - [#10261](#10261) [`abeef7ad0`](abeef7a) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `small`, `large`, and `fullScreen` props with `size` prop - [#10206](#10206) [`dad09bde9`](dad09bd) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `status` prop on `Banner` to `tone` - [#10220](#10220) [`2b0cdb2fbf`](2b0cdb2) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `color` prop on `Icon` to `tone` - [#10036](#10036) [`359614cf83`](359614c) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `borderless` prop with `variant` on TextField Migration: `npx @shopify/polaris-migrator react-rename-component-prop <path> --componentName="TextField" --from="borderless" --to="variant" --newValue="borderless"` - [#10635](#10635) [`340e36e7d`](340e36e) Thanks [@laurkim](https://github.com/laurkim)! - Removed `polarisSummerEditions2023` feature flag from AppProvider context - [#10090](#10090) [`4caed28a77`](4caed28) Thanks [@aveline](https://github.com/aveline)! - Consolidated boolean `Button` props into `variant` prop - [#10041](#10041) [`8f927f7622`](8f927f7) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced boolean props: `secondary`, `fullWidth`, `oneHalf`, `oneThird` on Layout.Section with `variant` - [#10266](#10266) [`22a51eae2`](22a51ea) Thanks [@kyledurand](https://github.com/kyledurand)! - Renamed `color` prop on Text to `tone` - [#9993](#9993) [`66f5c8df3e`](66f5c8d) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Removed Summer Editions experimental styles and code for the following components: `AppProvider`, `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`, `Autocomplete`, `Badge`, `Banner`, `Breadcrumbs`, `BulkActions`, `Button`, `ButtonGroup`, `CalloutCard`, `Card`, `CheckableButton`, `Checkbox`, `Choice`, `Connected`, `DataTable`, `DatePicker`, `DropZone`, `EmptyState`, `Filters`, `FormLayout`, `Frame`, `FullscreenBar`, `IndexFilters`, `IndexTable`, `InlineError`, `KeyboardKey`, `Labelled`, `Layout`, `LegacyCard`, `LegacyFilters`, `LegacyTabs`, `Link`, `List`, `Listbox`, `MediaCard`, `Modal`, `Navigation`, `OptionList`, `Page`, `PageActions`, `Pagination`, `Popover`, `ProgressBar`, `RadioButton`, `ResourceItem`, `ResourceList`, `Select`, `SettingAction`, `ShadowBevel`, `SkeletonPage`, `SkeletonThumbnail`, `Spinner`, `Tabs`, `Tag`, `Text`, `TextField`, `Thumbnail`, `TooltipOverlay`, `TopBar`, and `VideoThumbnail` - [#10232](#10232) [`eb2c2035c`](eb2c203) Thanks [@laurkim](https://github.com/laurkim)! - Removed `optionRole` prop from `OptionList` component ### Minor Changes - [#10238](#10238) [`b17d23d69`](b17d23d) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [#10228](#10228) [`e18ca907e`](e18ca90) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `Filters` Remove unused disabled states in `FilterPill` - [#10268](#10268) [`dbe3d9ece`](dbe3d9e) Thanks [@laurkim](https://github.com/laurkim)! - Fixed broken focus ring styles on `ResourceItem` component - [#10238](#10238) [`b17d23d69`](b17d23d) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [#10230](#10230) [`a573e55d0`](a573e55) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `IndexFilter` remove custom `FilterButton` in favor of directly invoking the Polaris `Button` component. - Updated dependencies \[[`86d4040c0`](86d4040)]: - @shopify/polaris-tokens@7.13.0-beta.0 ## @shopify/polaris-tokens@7.13.0-beta.0 ### Minor Changes - [#10382](#10382) [`86d4040c0`](86d4040) Thanks [@laurkim](https://github.com/laurkim)! - Renamed `ThemeVariant` to `Theme` and exposed `Theme` type ## @shopify/stylelint-polaris@14.1.2-beta.0 ### Patch Changes - Updated dependencies \[[`86d4040c0`](86d4040)]: - @shopify/polaris-tokens@7.13.0-beta.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Configuration menu - View commit details
-
Copy full SHA for d9966ec - Browse repository at this point
Copy the full SHA d9966ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for d929dd1 - Browse repository at this point
Copy the full SHA d929dd1View commit details -
[Link] Manually migrate
color
custom properties for v11 to v12 (#10710) ### WHY are these changes introduced? Resolves #10487. ### WHAT is this pull request doing? Manually migrates `Link` component `color` custom properties. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-kbsevctiyw.chromatic.com/) [Next branch storybook](https://5d559397bae39100201eedc1-bpilwyaavo.chromatic.com/?path=/story/all-components-link--default) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 4ab868e - Browse repository at this point
Copy the full SHA 4ab868eView commit details -
[ExceptionList] Manually migrate
color
custom properties for v11 to…… v12 (#10713) ### WHY are these changes introduced? Resolves #10392. ### WHAT is this pull request doing? Manually migrates `ExceptionList` component `color` custom properties. <details> <summary>ExceptionList — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/4f99eaa5-4471-4a7b-9940-d4b6f742215b" alt="ExceptionList — before"> </details> <details> <summary>ExceptionList — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/18de7848-25a8-4761-b848-779e6702ec3a" alt="ExceptionList — after"> </details> ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-vhfinvbqwa.chromatic.com/?path=/story/all-components-exceptionlist--all) [Next branch storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-exceptionlist--all) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for a3c9bfa - Browse repository at this point
Copy the full SHA a3c9bfaView commit details -
[InlineError] Manually migrate
color
custom properties for v11 to v……12 (#10714) ### WHY are these changes introduced? Resolves #10391. ### WHAT is this pull request doing? Manually migrates `InlineError` component `color` custom properties. <details> <summary>InlineError — before</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/f9f2ea44-f058-4ef0-9c35-71017ca7f6fe" alt="InlineError — before"> </details> <details> <summary>InlineError — after</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/4cb1f673-6c1a-4dc4-8c10-28c2b904339c" alt="InlineError — after"> </details> ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-uoggaugpto.chromatic.com/?path=/story/all-components-inlineerror--default) [Next branch storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-inlineerror--default) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 48ca178 - Browse repository at this point
Copy the full SHA 48ca178View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10fe13f - Browse repository at this point
Copy the full SHA 10fe13fView commit details -
[TopBar] Manually migrate
color
custom properties for v11 to v12 (#……10715) ### WHY are these changes introduced? Resolves #10388. ### WHAT is this pull request doing? Manually migrates `TopBar` component `color` custom properties. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-prihtemvap.chromatic.com/?path=/story/all-components-topbar--default) [Next branch storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-topbar--default) ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 71fe3cc - Browse repository at this point
Copy the full SHA 71fe3ccView commit details -
Add changeset for
space
migration (#10727)### WHY are these changes introduced? Forgot to add a changeset when I merged [this](#10585) into `next`.
Configuration menu - View commit details
-
Copy full SHA for 179b481 - Browse repository at this point
Copy the full SHA 179b481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22130fc - Browse repository at this point
Copy the full SHA 22130fcView commit details -
Update
font
token values (#10673)### WHY are these changes introduced? Fixes #10476 Fixes #10516 ### WHAT is this pull request doing? This pull request is making breaking change updates to font token values: | Token | New Value | | ------------------------- | ------------------------ | | `--p-font-size-300` | `size[300]` | | `--p-font-size-400` | `size[400]` | | `--p-font-size-500` | `size[500]` | | `--p-font-size-600` | `size[600]` | | `--p-font-weight-regular` | `450` | | `--p-font-weight-medium` | `550` | | `--p-font-weight-semibold` | `650` |
Configuration menu - View commit details
-
Copy full SHA for 08aaf11 - Browse repository at this point
Copy the full SHA 08aaf11View commit details -
Merge
main
atfc563df
intonext
(#10735)Merge `main` at `fc563df3ae9b73b1e79f8a9f2f2deab3260e6797` into `next` following [this process](#10594) ## Commits merged from main f0cd703 @chloerice 30555a9 @aaronccasanova fc563df @aaronccasanova --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 63314a1 - Browse repository at this point
Copy the full SHA 63314a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f724a0 - Browse repository at this point
Copy the full SHA 1f724a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9192f8 - Browse repository at this point
Copy the full SHA e9192f8View commit details -
[Icon] Add support for
emphasis
andtext
tones and migrated `colo……r` custom properties (#10722) ### WHY are these changes introduced? Resolves #10486. Adds support for net new tones on `Icon` component `tone` prop. ### WHAT is this pull request doing? Adds `emphasis` and `text` tones to `Icon`. Migrates `primary` and `subdued` color custom properties. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-sbgcrlbgjk.chromatic.com/?path=/story/all-components-icon--colored) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 14a9496 - Browse repository at this point
Copy the full SHA 14a9496View commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b7e945f - Browse repository at this point
Copy the full SHA b7e945fView commit details -
Migrate
border
custom properties from v11 to v12 (#10741)### WHY are these changes introduced? Resolves #10525. ### WHAT is this pull request doing? Runs the following migration to migrate `border` custom properties from v11 to v12 with updated border migration snapshot that includes breaking changes. More detailed steps for migration process can be found in [#10519](#10519). ```script npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230927173749 \ v12-styles-replace-custom-property-border \ 'src/**/*.scss' ``` ### How to 🎩 #### Replacement maps | Deprecated CSS Custom Property | Replacement Value | | ----------------------------------------- | ---------------------------------- | | `--p-border-radius-0-experimental` | `--p-border-radius-0` | | `--p-border-radius-05` | `--p-border-radius-050` | | `--p-border-radius-1` | `--p-border-radius-100` | | `--p-border-radius-1_5-experimental` | `--p-border-radius-150` | | `--p-border-radius-2` | `--p-border-radius-200` | | `--p-border-radius-3` | `--p-border-radius-300` | | `--p-border-radius-4` | `--p-border-radius-400` | | `--p-border-radius-5` | `--p-border-radius-500` | | `--p-border-radius-6` | `--p-border-radius-750` | | `--p-border-width-1` | `--p-border-width-025` | | `--p-border-width-1-experimental` | `--p-border-width-0165` | | `--p-border-width-2` | `--p-border-width-050` | | `--p-border-width-2-experimental` | `--p-border-width-025` | | `--p-border-width-3` | `--p-border-width-050` | | `--p-border-width-4` | `--p-border-width-100` | | `--p-border-width-5` | `--p-border-width-100` | 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 2c2bb0e - Browse repository at this point
Copy the full SHA 2c2bb0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ef1922 - Browse repository at this point
Copy the full SHA 8ef1922View commit details -
ActionList
OptionList
Listbox
color updates (#10732)### WHY are these changes introduced? Fixes #10371 ### WHAT is this pull request doing? Updates color values for selected, hover and active states for `ActionList`, `OptionList` and `Listbox` ### How to 🎩 - Verify changes in Storybook
Configuration menu - View commit details
-
Copy full SHA for 52d98fd - Browse repository at this point
Copy the full SHA 52d98fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc5ebc2 - Browse repository at this point
Copy the full SHA cc5ebc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e211cb3 - Browse repository at this point
Copy the full SHA e211cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fa0c1e - Browse repository at this point
Copy the full SHA 7fa0c1eView commit details -
Update shadow tokens to new values (#10760)
### WHY are these changes introduced? Fixes #10738 ### WHAT is this pull request doing? Updates shadow tokens to the following corrected values: | New Token | Value | | ------------------------- | ------------------------ | | `--p-shadow-0` | `none` | | `--p-shadow-100` | `0 1px 0 0 rgba(26, 26, 26, 0.07)` | | `--p-shadow-200` | `0 3px 1px -1px rgba(26, 26, 26, 0.07)` | | `--p-shadow-300` | `0 4px 6px -2px rgba(26, 26, 26, 0.20)` | | `--p-shadow-400` | `0 8px 16px -4px rgba(26, 26, 26, 0.22)` | | `--p-shadow-500` | `0 12px 20px -8px rgba(26, 26, 26, 0.24)` | | `--p-shadow-600` | `0 20px 20px -8px rgba(26, 26, 26, 0.28)` | | `--p-shadow-bevel-100` | `0 1px 0 0 rgba(208, 208, 208, 0.40) inset, 1px 0 0 0 #E3E3E3 inset, -1px 0 0 0 #E3E3E3 inset, 0 -1px 0 0 #D4D4D4 inset` | | `--p-shadow-inset-100` | `0 1px 2px 0 rgba(26, 26, 26, 0.15) inset, 0 1px 1px 0px rgba(26, 26, 26, 0.15) inset` | | `--p-shadow-inset-200` | `0 2px 1px 0 rgba(26, 26, 26, 0.20) inset, 1px 0 1px 0 rgba(26, 26, 26, 0.12) inset, -1px 0 1px 0 rgba(26, 26, 26, 0.12) inset` | | `--p-shadow-button` | `0 1px 0 0 #E3E3E3 inset, 1px 0 0 0 #E3E3E3 inset, -1px 0 0 0 #E3E3E3 inset, 0 -1px 0 0 #B5B5B5 inset` | | `--p-shadow-button-hover` | `0 1px 0 0 #EBEBEB inset, -1px 0 0 0 #EBEBEB inset, 1px 0 0 0 #EBEBEB inset, 0 -1px 0 0 #CCC inset` | | `--p-shadow-button-inset` | `0 2px 1px 0 rgba(26, 26, 26, 0.20) inset, 1px 0 1px 0 rgba(26, 26, 26, 0.12) inset, -1px 0 1px 0 rgba(26, 26, 26, 0.12) inset` | | `--p-shadow-button-primary` | `0 1px 0 0 rgba(255, 255, 255, 0.24) inset, 1px 0 0 0 rgba(255, 255, 255, 0.20) inset, -1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 0 -1px 0 0 #000 inset, 0 -1px 0 1px #1A1A1A` | | `--p-shadow-button-primary-inset` | `0 3px 0 0 #000 inset` | | `--p-shadow-button-primary-hover` | `0 1px 0 0 rgba(255, 255, 255, 0.24) inset, 1px 0 0 0 rgba(255, 255, 255, 0.20) inset, -1px 0 0 0px rgba(255, 255, 255, 0.20) inset, 0 -1px 0 0 #000 inset, 0 -1px 0 1px #1A1A1A` | | `--p-shadow-button-primary-critical` | `0 1px 0 0 rgba(255, 255, 255, 0.48) inset, -1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 0 -1.5px 0 0 rgba(0, 0, 0, 0.25) inset` | | `--p-shadow-button-primary-critical-hover` | `0 1px 0 0 rgba(255, 255, 255, 0.48) inset, 1px 0 0 0 rgba(255, 255, 255, 0.20) inset, -1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 0 -1.5px 0 0 rgba(0, 0, 0, 0.25) inset` | | `--p-shadow-button-primary-critical-inset` | `0 2px 0 0 rgba(0, 0, 0, 0.60) inset, 1px 0 1px 0 rgba(0, 0, 0, 0.20) inset, -1px 0 1px 0 rgba(0, 0, 0, 0.20) inset` | | `--p-shadow-button-primary-success` | `0 1px 0 0 rgba(255, 255, 255, 0.48) inset, -1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 0 -1.5px 0 0 rgba(0, 0, 0, 0.25) inset` | | `--p-shadow-button-primary-success-hover` | `0 1px 0 0 rgba(255, 255, 255, 0.48) inset, 1px 0 0 0 rgba(255, 255, 255, 0.20) inset, -1px 0 0 0 rgba(255, 255, 255, 0.20) inset, 0 -1.5px 0 0 rgba(0, 0, 0, 0.25) inset` | | `--p-shadow-button-primary-success-inset` | `0 2px 0 0 rgba(0, 0, 0, 0.60) inset, 1px 0 1px 0 rgba(0, 0, 0, 0.20) inset, -1px 0 1px 0 rgba(0, 0, 0, 0.20) inset` | | `--p-shadow-border-inset` | `0 0 0 1px rgba(0, 0, 0, 0.08) inset` | </details>
Configuration menu - View commit details
-
Copy full SHA for 2a46724 - Browse repository at this point
Copy the full SHA 2a46724View commit details -
[polaris.shopify.com] Update content for v12 release (#10740)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? This is the content that needs to be updated for the v12 release. More details in GSD #36550 Fixes #10691 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Updates outdated content / do's and don'ts in some components - Adds new content to the `Design` section to introduce our new Design Language Principles - Adds a 'coming soon' disclaimer in other sections under `Design` ### Notes Some assets are currently static images, and will be updated to be animations. <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 9bd7fe9 - Browse repository at this point
Copy the full SHA 9bd7fe9View commit details -
Add v12 whats new page (#10766)
Moved over from #10730 * Delete beta page * Make whats new v12 page with content for each of our initiatives <img width="1480" alt="Screenshot 2023-09-28 at 10 53 36 AM" src="https://github.com/Shopify/polaris/assets/20652326/3c9fdf6b-5cf1-4e4f-b984-9bcf2c6a6e9c"> * Update landing page to new promo |Before|After| |-|-| |<img width="1175" alt="Screenshot 2023-09-27 at 5 54 08 PM" src="https://github.com/Shopify/polaris/assets/20652326/b173a34f-90b4-4b78-b3c5-ae28a79c69c4">|<img width="1178" alt="Screenshot 2023-09-27 at 5 53 57 PM" src="https://github.com/Shopify/polaris/assets/20652326/1b069531-47e5-4fd5-83a5-8a5966162647">| * Add new version guides section with link to old guides in github and our v11 to v12 guide <img width="1475" alt="Screenshot 2023-09-27 at 5 57 16 PM" src="https://github.com/Shopify/polaris/assets/20652326/f6513585-9034-45a8-b78c-028a6c1d5f43"> <img width="1463" alt="Screenshot 2023-09-27 at 5 57 06 PM" src="https://github.com/Shopify/polaris/assets/20652326/03b0c194-5341-492a-be5f-c7ac1d9da1fe"> * Add Inter font code block to the quick start polaris-react guide
Configuration menu - View commit details
-
Copy full SHA for 86058e3 - Browse repository at this point
Copy the full SHA 86058e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd66c7d - Browse repository at this point
Copy the full SHA dd66c7dView commit details -
### WHY are these changes introduced? Fixes #10386
Configuration menu - View commit details
-
Copy full SHA for 56fa276 - Browse repository at this point
Copy the full SHA 56fa276View commit details -
Migrate
font
custom properties from v11 to v12 (#10762)### WHY are these changes introduced? Resolves #10532. Migrates `font` custom properties. Updates body and heading variants in `Text` components to use text composite tokens where applicable. > [!Important] > Font migration needed to be run in 4 sequential steps due to overlapping `font-size` token names. ### WHAT is this pull request doing? ## Step 1 ```script npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230928163203 \ v12-styles-replace-custom-property-font \ './**/*.scss' --step=1 ``` ```sh # Stage all migrated files git add . # Format staged files only git diff --staged --name-only | xargs npx prettier --write # Commit automated migrations git commit -m "Migrate `font` custom properties from Polaris v11 to v12 — step [1/2/3/4]“ ``` ### Post-migration validation <details> <summary>[v12] Check RegExp for hardcoded <code>font</code> custom properties in step 1 across all file types </summary> ``` (?:--p-font-size-70-experimental|--p-font-size-80-experimental|--p-font-size-100|--p-font-size-700|--p-font-line-height-075-experimental|--p-font-line-height-1|--p-font-line-height-2|--p-font-line-height-3|--p-font-line-height-4|--p-font-line-height-5|--p-font-line-height-6|--p-font-line-height-7)(?![\w-]) ``` </details> ## Step 2 ```script # Run migration npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230928163203 \ v12-styles-replace-custom-property-font \ './**/*.scss' --step=2 # Repeat process in step 1 to commit automated migrations ``` ### Post-migration validation <details> <summary>[v12] Check RegExp for hardcoded <code>font</code> custom properties in step 2 across all file types </summary> ``` (?:--p-font-size-500|--p-font-size-600)(?![\w-]) ``` </details> ## Step 3 ```script # Run migration npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230928163203 \ v12-styles-replace-custom-property-font \ './**/*.scss' --step=3 # Repeat process in step 1 to commit automated migrations ``` ### Post-migration validation <details> <summary>[v12] Check RegExp for hardcoded <code>font</code> custom properties in step 3 across all file types </summary> </details> ``` (?:--p-font-size-300|--p-font-size-400)(?![\w-]) ``` </details> ## Step 4 ```script # Run migration npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230928163203 \ v12-styles-replace-custom-property-font \ './**/*.scss' --step=4 # Repeat process in step 1 to commit automated migrations ``` ### Post-migration validation <details> <summary>[v12] Check RegExp for hardcoded <code>font</code> custom properties in step 4 across all file types </summary> ``` (?:--p-font-size-75|--p-font-size-200)(?![\w-]) ``` </details> #### Replacement maps | Deprecated CSS Custom Property | Replacement Value | | ---------------- | ----------------- | | `--p-font-size-70-experimental` | `--p-font-size-275` | | `--p-font-size-75` | `--p-font-size-300` | | `--p-font-size-80-experimental` | `--p-font-size-325` | | `--p-font-size-100` | `--p-font-size-350` | | `--p-font-size-200` | `--p-font-size-400` | | `--p-font-size-300` | `--p-font-size-500` | | `--p-font-size-400` | `--p-font-size-600` | | `--p-font-size-500` | `--p-font-size-750` | | `--p-font-size-600` | `--p-font-size-900` | | `--p-font-size-700` | `--p-font-size-1000` | | `--p-font-line-height-075-experimental` | `--p-font-line-height-300` | | `--p-font-line-height-1` | `--p-font-line-height-400` | | `--p-font-line-height-2` | `--p-font-line-height-500` | | `--p-font-line-height-3` | `--p-font-line-height-600` | | `--p-font-line-height-4` | `--p-font-line-height-700` | | `--p-font-line-height-5` | `--p-font-line-height-800` | | `--p-font-line-height-6` | `--p-font-line-height-1000` | | `--p-font-line-height-7` | `--p-font-line-height-1200` | ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 1ef7116 - Browse repository at this point
Copy the full SHA 1ef7116View commit details -
[Text] Remove
headingXs
andheading4xl
and migrate usage (#10771)### WHY are these changes introduced? Resolves #10770. With the recent changes to `Text` to use the composite text tokens, we are removing the `headingXs` and `heading4xl` variants. ### Mapping | Old `variant` Prop Value | Replacement Value | | ------------------------ | ----------------- | | `headingXs` | `headingSm` | | `heading4xl` | `heading3xl` | ### WHAT is this pull request doing? Removes `headingXs` and `heading4xl` and manually migrates usage. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 24d6d76 - Browse repository at this point
Copy the full SHA 24d6d76View commit details -
Update semantic
border-radius
token layer (#10669)### WHY are these changes introduced? Fixes #10421 ### WHAT is this pull request doing? - Added `border-radius-full` to a new `BorderRadiusAlias` type - Created `BorderRadiusAliasOrScale` combining `BorderRadiusScale` and `BorderRadiusAlias` - Updated component token prop types to `BorderWidthAliasOrScale`
Configuration menu - View commit details
-
Copy full SHA for 794d1f5 - Browse repository at this point
Copy the full SHA 794d1f5View commit details -
### WHY are these changes introduced? Fixes #0000 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for f6bc29a - Browse repository at this point
Copy the full SHA f6bc29aView commit details -
Update doc site token pages (#10719)
### WHY are these changes introduced? Fixes #10660 ### WHAT is this pull request doing? - Removes truncation of token table cell data - Removes logic to filter out experimental tokens - Temporarily hides Figma token table column until we have Figma vars listed - Updates table column headers - Aligns `—` symbols so they are consistent across token groups - Converts token table values to px - Adds new token groups to doc site - Removes legacy token group page on doc site - Adds token previews for new token groups - Adds new token groups to token tabs - Updates tab styling to accommodate more tabs
Configuration menu - View commit details
-
Copy full SHA for cf26411 - Browse repository at this point
Copy the full SHA cf26411View commit details -
Token migration guidance (#10300)
Fixes #10302 --------- Co-authored-by: Sophie Schneider <thesophieschneider@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for abd00a5 - Browse repository at this point
Copy the full SHA abd00a5View commit details
Commits on Sep 29, 2023
-
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #0000 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 8c6b762 - Browse repository at this point
Copy the full SHA 8c6b762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c32433 - Browse repository at this point
Copy the full SHA 3c32433View commit details -
Update Index table colors (#10755)
### WHY are these changes introduced? Fixes #10362 ### WHAT is this pull request doing? This updates some Index table row colors as well as the color value for the `color-bg-surface-selected` token
Configuration menu - View commit details
-
Copy full SHA for d6c7682 - Browse repository at this point
Copy the full SHA d6c7682View commit details -
### WHY are these changes introduced? Fixes #10373
Configuration menu - View commit details
-
Copy full SHA for a95ed6c - Browse repository at this point
Copy the full SHA a95ed6cView commit details -
[TextField] Remove disable1Password prop (#10744)
Removes the deprecated `disable1Password` prop. ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Jess Telford <jess.telford@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for a4f5e7d - Browse repository at this point
Copy the full SHA a4f5e7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 380ff50 - Browse repository at this point
Copy the full SHA 380ff50View commit details -
Migrate deprecated v11 tokens in stylelint docs (#10777)
### WHY are these changes introduced? Removes any deprecated v11 tokens from our polaris.shopify.com stylelint-polaris docs. ### WHAT is this pull request doing? Manually migrates values based on our deprecated token maps.
Configuration menu - View commit details
-
Copy full SHA for b70f090 - Browse repository at this point
Copy the full SHA b70f090View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25171a8 - Browse repository at this point
Copy the full SHA 25171a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ca53ca - Browse repository at this point
Copy the full SHA 9ca53caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7082428 - Browse repository at this point
Copy the full SHA 7082428View commit details -
[Button] Manual color and -on-color token migrations (#10782)
### WHY are these changes introduced? Fixes #10353 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR manually replaces the deprecated color CSS custom properties with v12 semantic color CSS custom properties ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sophie Schneider <thesophieschneider@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 49b66dc - Browse repository at this point
Copy the full SHA 49b66dcView commit details -
[Docs] Document
Text
heading variants removal in migration guide (#……10793) ### WHY are these changes introduced? Documents changes from #10771. <details> <summary>Docs</summary> <img src="https://github.com/Shopify/polaris/assets/26749317/a599b2ab-93fc-4e61-a1e3-3becfaeba41d" alt="Docs"> </details> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 838d0b3 - Browse repository at this point
Copy the full SHA 838d0b3View commit details -
[IndexFilters] Remove IndexFiltersManager, reinstate useSetIndexFilte…
…rsMode (#10745) ### WHY are these changes introduced? We recently removed the logic to disable page actions when in filtering mode, so the work to extract the filtering state into global context is no longer required, and should be cleaned up. This PR reverts things to how they were before https://github.com/Shopify/polaris/pull/10490/files merged. ### WHAT is this pull request doing? ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for a4205ee - Browse repository at this point
Copy the full SHA a4205eeView commit details -
Cleanup changeset entries (#10791)
### WHY are these changes introduced? Fixes Shopify/web#105446 This is a first pass at general cleanup. Let me know if there's anything else you want addressed in here @chloerice @sophschneider --------- Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7556055 - Browse repository at this point
Copy the full SHA 7556055View commit details -
Migrate
shadow
custom properties from v11 to v12 (#10778)### WHY are these changes introduced? Resolves #10641. Migrates `shadow` custom properties from v11 to v12. Updates types on Box component `shadow` prop and ShadowBevel component `boxShadow` prop. ### WHAT is this pull request doing? To migrate `shadow` custom properties, the flow was to: - Handle automatic migrations ```sh # Space migration npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230922144839 \ v12-styles-replace-custom-property-shadow \ 'src/**/*.scss' # Stage all migrated files git add . # Format staged files only git diff --staged --name-only | xargs npx prettier --write # Commit automated migrations git commit -m "Migrate shadow custom properties from v11 to v12" ``` - Handle manual migrations ```sh # Bring back the files with "polaris-migrator:" comments git stash pop ``` - Search for "polaris-migrator:" comments and handle manual migrations - Search for and handle manual migrations (e.g. <Box shadow="md">) <br> ```sh # Stage all manually migrated files git add . # Format staged files only git diff --staged --name-only | xargs npx prettier --write # Commit manual migrations git commit -m "Manually migrate shadow custom properties from v11 to v12" ``` - Check for errors after all custom property migrations are finished ```sh # Run stylelint against polaris-react npx stylelint 'polaris-react/src/**/*.scss' ``` ### How to 🎩 #### Post-migration validation After migrating use the following RegExp to check for any additional instances of `space` custom properties across all file types: <details> <summary>[V12] Check RegExp for hardcoded <code>shadow</code> custom properties across all file types</summary> ``` (?:--p-shadow-inset-lg|--p-shadow-inset-md|--p-shadow-inset-sm|--p-shadow-none|--p-shadow-xs|--p-shadow-sm|--p-shadow-md|--p-shadow-lg|--p-shadow-xl|--p-shadow-2xl|--p-shadow-bevel-experimental|--p-shadow-card-sm-experimental|--p-shadow-card-md-experimental|--p-shadow-card-lg-experimental|--p-shadow-button-experimental|--p-shadow-button-hover-experimental|--p-shadow-button-disabled-experimental|--p-shadow-button-primary-strong-experimental|--p-shadow-button-primary-strong-inset-experimental|--p-shadow-button-primary-strong-hover-experimental|--p-shadow-border-inset-experimental|--p-shadow-button-primary-experimental|--p-shadow-button-primary-hover-experimental|--p-shadow-button-inset-experimental)(?![\w-]) ``` </details> <details> <summary>Check RegExp for outdated <code><Box shadow="..." /></code> props</summary> ``` <Box[^>\w](?:[^>]|\n)*?shadow ``` </details> <details> <summary>Check RegExp for outdated <code><ShadowBevel boxShadow="..." /></code> props</summary> ``` <ShadowBevel[^>\w](?:[^>]|\n)*?boxShadow ``` </details> #### Replacement maps | Deprecated CSS Custom Property | Replacement Value | | ---------------- | ----------------- | | `--p-shadow-inset-lg` | `--p-shadow-inset-200` | | `--p-shadow-inset-md` | `--p-shadow-inset-200` | | `--p-shadow-inset-sm` | `--p-shadow-inset-100` | | `--p-shadow-none` | `--p-shadow-0` | | `--p-shadow-xs` | `--p-shadow-100` | | `--p-shadow-sm` | `--p-shadow-200` | | `--p-shadow-md` | `--p-shadow-300` | | `--p-shadow-lg` | `--p-shadow-400` | | `--p-shadow-xl` | `--p-shadow-500` | | `--p-shadow-2xl` | `--p-shadow-600` | | `--p-shadow-bevel-experimental` | `--p-shadow-bevel-100` | | `--p-shadow-card-sm-experimental` | `--p-shadow-100` | | `--p-shadow-card-md-experimental` | `--p-shadow-200` | | `--p-shadow-card-lg-experimental` | `--p-shadow-300` | | `--p-shadow-button-experimental` | `--p-shadow-button` | | `--p-shadow-button-hover-experimental` | `--p-shadow-button-hover` | | `--p-shadow-button-disabled-experimental` | `inset 0 0 0 1px rgba(227, 227, 227, 1)` | | `--p-shadow-button-primary-strong-experimental` | `--p-shadow-button-primary` | | `--p-shadow-button-primary-strong-inset-experimental` | `--p-shadow-button-primary-inset` | | `--p-shadow-button-primary-strong-hover-experimental` | `--p-shadow-button-primary-hover` | | `--p-shadow-border-inset-experimental` | `--p-shadow-border-inset` | > [!IMPORTANT] > The following values were manually migrated based on context: | Deprecated CSS Custom Property | Replacement Value | | ------------------------- | ------------------------ | | `--p-shadow-button-primary-experimental` | `--p-shadow-button-primary-critical`<br>`--p-shadow-button-primary-success` | | `--p-shadow-button-primary-hover-experimental` | `--p-shadow-button-primary-critical-hover`<br>`--p-shadow-button-primary-success-hover` | | `--p-shadow-button-inset-experimental` | `--p-shadow-button-primary-critical-inset`<br>`--p-shadow-button-primary-success-inset` | ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for b126f64 - Browse repository at this point
Copy the full SHA b126f64View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaa11c2 - Browse repository at this point
Copy the full SHA aaa11c2View commit details
Commits on Oct 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4c44ac9 - Browse repository at this point
Copy the full SHA 4c44ac9View commit details -
Migrate
color
custom properties from Polaris v11 to v12 (#10797)### WHY are these changes introduced? Closes #10636 Migrates `color` custom properties. > [!Important] > Color migration needed to be run in 2 sequential steps due to overlapping `color-bg` and `color-bg-app` token names. ### WHAT is this pull request doing? ## Step 1 ```script npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230929171751 \ --step 1 \ v12-styles-replace-custom-property-color \ '**/*' ``` ```sh # Stage all migrated files git add . # Format staged files only git diff --staged --name-only | xargs npx prettier --write # Commit automated migrations git commit -m "Migrate color custom properties from Polaris v11 to v12 (step 1)" ``` ## Step 2 ```script npx @shopify/polaris-migrator@0.0.0-snapshot-release-20230929171751 \ --step 2 \ v12-styles-replace-custom-property-color \ '**/*' ``` ```sh # Stage all migrated files git add . # Format staged files only git diff --staged --name-only | xargs npx prettier --write # Commit automated migrations git commit -m "Migrate color custom properties from Polaris v11 to v12 (step 2)" ``` #### Step 1 replacement map | Deprecated CSS Custom Property | Replacement Value | | ---------------- | ----------------- | | `--p-color-avatar-background-experimental` | `--p-color-avatar-bg-fill` | | `--p-color-avatar-color-experimental` | `--p-color-avatar-text-on-bg-fill` | | `--p-color-avatar-style-five-background-experimental` | `--p-color-avatar-five-bg-fill` | | `--p-color-avatar-style-five-color-experimental` | `--p-color-avatar-five-text-on-bg-fill` | | `--p-color-avatar-style-four-background-experimental` | `--p-color-avatar-four-bg-fill` | | `--p-color-avatar-style-four-color-experimental` | `--p-color-avatar-four-text-on-bg-fill` | | `--p-color-avatar-style-one-background-experimental` | `--p-color-avatar-one-bg-fill` | | `--p-color-avatar-style-one-color-experimental` | `--p-color-avatar-one-text-on-bg-fill` | | `--p-color-avatar-style-three-background-experimental` | `--p-color-avatar-three-bg-fill` | | `--p-color-avatar-style-three-color-experimental` | `--p-color-avatar-three-text-on-bg-fill` | | `--p-color-avatar-style-two-background-experimental` | `--p-color-avatar-two-bg-fill` | | `--p-color-avatar-style-two-color-experimental` | `--p-color-avatar-two-text-on-bg-fill` | | `--p-color-bg-active` | `--p-color-bg-surface-active` | | `--p-color-bg-app-active` | `--p-color-bg-surface-active` | | `--p-color-bg-app-selected` | `--p-color-bg-surface-selected` | | `--p-color-bg-backdrop-experimental` | `--p-color-backdrop-bg` | | `--p-color-bg-caution-strong` | `--p-color-bg-fill-caution` | | `--p-color-bg-caution-subdued-active` | `--p-color-bg-surface-caution-active` | | `--p-color-bg-caution-subdued-hover` | `--p-color-bg-surface-caution-hover` | | `--p-color-bg-caution-subdued` | `--p-color-bg-surface-caution` | | `--p-color-bg-caution` | `--p-color-bg-fill-caution-secondary` | | `--p-color-bg-critical-strong-active` | `--p-color-bg-fill-critical-active` | | `--p-color-bg-critical-strong-hover` | `--p-color-bg-fill-critical-hover` | | `--p-color-bg-critical-strong` | `--p-color-bg-fill-critical` | | `--p-color-bg-critical-subdued-active` | `--p-color-bg-surface-critical-active` | | `--p-color-bg-critical-subdued-hover` | `--p-color-bg-surface-critical-hover` | | `--p-color-bg-critical-subdued` | `--p-color-bg-surface-critical` | | `--p-color-bg-critical` | `--p-color-bg-fill-critical-secondary` | | `--p-color-bg-disabled` | `--p-color-bg-surface-disabled` | | `--p-color-bg-hover` | `--p-color-bg-surface-hover` | | `--p-color-bg-info-strong` | `--p-color-bg-fill-info` | | `--p-color-bg-info-subdued-active` | `--p-color-bg-surface-info-active` | | `--p-color-bg-info-subdued-hover` | `--p-color-bg-surface-info-hover` | | `--p-color-bg-info-subdued` | `--p-color-bg-surface-info` | | `--p-color-bg-info` | `--p-color-bg-fill-info-secondary` | | `--p-color-bg-input-active-experimental` | `--p-color-input-bg-surface-active` | | `--p-color-bg-input-hover-experimental` | `--p-color-input-bg-surface-hover` | | `--p-color-bg-input` | `--p-color-input-bg-surface` | | `--p-color-bg-inset-strong` | `--p-color-bg-fill-inverse` | | `--p-color-bg-inset` | `--p-color-bg-fill-secondary` | | `--p-color-bg-inverse-active` | `--p-color-bg-fill-inverse-active` | | `--p-color-bg-inverse-hover` | `--p-color-bg-fill-inverse-hover` | | `--p-color-bg-magic-active` | `--p-color-bg-fill-magic-secondary-active` | | `--p-color-bg-magic-hover` | `--p-color-bg-fill-magic-secondary-hover` | | `--p-color-bg-magic-strong` | `--p-color-bg-fill-magic` | | `--p-color-bg-magic-subdued-hover` | `--p-color-bg-surface-magic-hover` | | `--p-color-bg-magic-subdued` | `--p-color-bg-surface-magic` | | `--p-color-bg-magic` | `--p-color-bg-fill-magic-secondary` | | `--p-color-bg-primary-active` | `--p-color-bg-fill-brand-active` | | `--p-color-bg-primary-disabled-experimental` | `--p-color-bg-fill-brand-disabled` | | `--p-color-bg-primary-hover` | `--p-color-bg-fill-brand-hover` | | `--p-color-bg-primary-subdued-active` | `--p-color-bg-surface-brand-active` | | `--p-color-bg-primary-subdued-hover` | `--p-color-bg-surface-brand-hover` | | `--p-color-bg-primary-subdued-selected` | `--p-color-bg-surface-brand-selected` | | `--p-color-bg-primary-subdued` | `--p-color-bg-surface-brand` | | `--p-color-bg-primary` | `--p-color-bg-fill-brand` | | `--p-color-bg-secondary-experimental` | `--p-color-bg-surface-tertiary` | | `--p-color-bg-strong-active` | `--p-color-bg-fill-tertiary-active` | | `--p-color-bg-strong-hover` | `--p-color-bg-fill-tertiary-hover` | | `--p-color-bg-strong` | `--p-color-bg-fill-tertiary` | | `--p-color-bg-subdued-active` | `--p-color-bg-surface-secondary-active` | | `--p-color-bg-subdued-hover` | `--p-color-bg-surface-secondary-hover` | | `--p-color-bg-subdued` | `--p-color-bg-surface-secondary` | | `--p-color-bg-success-strong-active-experimental` | `--p-color-bg-fill-success-active` | | `--p-color-bg-success-strong-hover-experimental` | `--p-color-bg-fill-success-hover` | | `--p-color-bg-success-strong` | `--p-color-bg-fill-success` | | `--p-color-bg-success-subdued-active` | `--p-color-bg-surface-success-active` | | `--p-color-bg-success-subdued-hover` | `--p-color-bg-surface-success-hover` | | `--p-color-bg-success-subdued` | `--p-color-bg-surface-success` | | `--p-color-bg-success` | `--p-color-bg-fill-success-secondary` | | `--p-color-bg-transparent-active-experimental` | `--p-color-bg-fill-transparent-active` | | `--p-color-bg-transparent-disabled-experimental` | `--p-color-bg-fill-disabled` | | `--p-color-bg-transparent-experimental` | `--p-color-bg-surface-transparent` | | `--p-color-bg-transparent-hover-experimental` | `--p-color-bg-fill-transparent-hover` | | `--p-color-bg-transparent-primary-disabled-experimental` | `--p-color-bg-fill-brand-disabled` | | `--p-color-bg-transparent-subdued-experimental` | `--p-color-bg-fill-transparent-secondary` | | `--p-color-bg-warning-strong-experimental` | `--p-color-bg-fill-warning` | | `--p-color-bg-warning-subdued-experimental` | `--p-color-bg-surface-warning` | | `--p-color-bg-warning` | `--p-color-bg-fill-warning-secondary` | | `--p-color-bg` | `--p-color-bg-surface` | | `--p-color-border-caution-subdued` | `--p-color-border-caution` | | `--p-color-border-critical-active` | `--p-color-border-critical` | | `--p-color-border-critical-hover` | `--p-color-border-critical` | | `--p-color-border-critical-strong-experimental` | `--p-color-border-critical-secondary` | | `--p-color-border-critical-subdued` | `--p-color-border-critical` | | `--p-color-border-info-subdued` | `--p-color-border-info` | | `--p-color-border-input-active-experimental` | `--p-color-input-border-active` | | `--p-color-border-input-hover` | `--p-color-input-border-hover` | | `--p-color-border-input` | `--p-color-input-border` | | `--p-color-border-interactive-active` | `--p-color-border-emphasis-active` | | `--p-color-border-interactive-disabled` | `--p-color-border-disabled` | | `--p-color-border-interactive-focus` | `--p-color-border-focus` | | `--p-color-border-interactive-hover` | `--p-color-border-emphasis-hover` | | `--p-color-border-interactive` | `--p-color-border-emphasis` | | `--p-color-border-magic-strong` | `--p-color-border-magic-secondary` | | `--p-color-border-primary` | `--p-color-border-brand` | | `--p-color-border-strong` | `--p-color-border-tertiary` | | `--p-color-border-subdued` | `--p-color-border-secondary` | | `--p-color-border-success-subdued` | `--p-color-border-success` | | `--p-color-icon-critical-strong-active-experimental` | `--p-color-text-critical-active` | | `--p-color-icon-critical-strong-experimental` | `--p-color-text-critical` | | `--p-color-icon-info-strong-experimental` | `--p-color-text-info` | | `--p-color-icon-interactive-active` | `--p-color-icon-emphasis-active` | | `--p-color-icon-interactive-disabled` | `--p-color-icon-disabled` | | `--p-color-icon-interactive-hover` | `--p-color-icon-emphasis-hover` | | `--p-color-icon-interactive` | `--p-color-icon-emphasis` | | `--p-color-icon-primary` | `--p-color-icon-brand` | | `--p-color-icon-subdued` | `--p-color-icon-secondary` | | `--p-color-icon-success-strong-experimental` | `--p-color-text-success` | | `--p-color-icon-warning-strong-experimental` | `--p-color-text-warning` | | `--p-color-text-caution-strong` | `--p-color-text-caution` | | `--p-color-text-critical-hover-experimental` | `--p-color-text-critical-hover` | | `--p-color-text-critical-strong` | `--p-color-text-critical` | | `--p-color-text-info-strong` | `--p-color-text-info-on-bg-fill` | | `--p-color-text-interactive-active` | `--p-color-text-emphasis-active` | | `--p-color-text-interactive-disabled` | `--p-color-text-disabled` | | `--p-color-text-interactive-hover` | `--p-color-text-emphasis-hover` | | `--p-color-text-interactive-inverse` | `--p-color-text-link-inverse` | | `--p-color-text-interactive` | `--p-color-text-emphasis` | | `--p-color-text-inverse-subdued` | `--p-color-text-inverse-secondary` | | `--p-color-text-magic-strong` | `--p-color-text-magic` | | `--p-color-text-primary-hover` | `--p-color-text-brand-hover` | | `--p-color-text-primary` | `--p-color-text-brand` | | `--p-color-text-subdued` | `--p-color-text-secondary` | | `--p-color-text-success-strong` | `--p-color-text-success` | | `--p-color-text-warning-experimental` | `--p-color-text-warning` | #### Step 2 replacement map | Deprecated CSS Custom Property | Replacement Value | | ---------------- | ----------------- | | `--p-color-bg-app` | `--p-color-bg` | #### Manual replacement map | Deprecated CSS Custom Property | Replacement Value | | ---------------- | ----------------- | | `--p-color-icon-on-color` | `rgba(255, 255, 255, 1)` | | `--p-color-text-on-color` | `rgba(255, 255, 255, 1)` | | `--p-color-bg-transparent-primary-experimental` | `rgba(0, 0, 0, 0.62)` | ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for d740c37 - Browse repository at this point
Copy the full SHA d740c37View commit details
Commits on Oct 3, 2023
-
[Docs] Add in
color
replacement maps in v12 migration guide (#10809)### WHY are these changes introduced? I added some missing color tokens in this [migration PR](#10779). I'm adding them here to the migration guide for v12 as a follow up. I noticed some other color tokens were missing in the replacement map table so I added them in as well as a separate section for the manual replacement maps for hardcoded token values. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 9288f5b - Browse repository at this point
Copy the full SHA 9288f5bView commit details -
Remove deprecated v11 custom properties (#10674)
### WHY are these changes introduced? Part of #10661 ### WHAT is this pull request doing? Removes all deprecated v11 custom properties from polaris minus color tokens. --------- Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Laura Griffee <21976492+lgriffee@users.noreply.github.com> Co-authored-by: Sophie Schneider <20652326+sophschneider@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for a2aefd0 - Browse repository at this point
Copy the full SHA a2aefd0View commit details -
Remove legacy
color
tokens (#10779)### WHY are these changes introduced? Part of #10661 ### WHAT is this pull request doing? Removes all deprecated v11 `color` custom properties from Polaris. --------- Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Laura Griffee <laura@mailzone.com>
Configuration menu - View commit details
-
Copy full SHA for 2ce6c37 - Browse repository at this point
Copy the full SHA 2ce6c37View commit details -
Fix Patterns page TOC (#10812)
Closes #10752 <img width="1196" alt="Screenshot 2023-10-03 at 11 53 20 AM" src="https://github.com/Shopify/polaris/assets/11774595/2bf74428-37e7-4b39-b90e-c37aadb0ae4e">
Configuration menu - View commit details
-
Copy full SHA for 797bc49 - Browse repository at this point
Copy the full SHA 797bc49View commit details -
Set dark mode style for Icons page (#10814)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> <img width="2032" alt="Screenshot 2023-10-03 at 12 41 21 PM" src="https://github.com/Shopify/polaris/assets/4642404/dee0c315-4402-4ab2-88a7-914ef306cc66"> ### WHY are these changes introduced? Icons on dark mode were not showing up Fixes #10689 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 8e4f560 - Browse repository at this point
Copy the full SHA 8e4f560View commit details -
Configuration menu - View commit details
-
Copy full SHA for deba43d - Browse repository at this point
Copy the full SHA deba43dView commit details -
[IndexTable.Row] Fix
tone
interaction states; removesubdued
and ……`status` (#10705) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? This PR removes the deprecated `status` and `subdued` props. It also fixes the missing and buggy interaction states when `IndexTable.Row` has a `tone`. | Before | After | |--------|--------| |<video src="https://github.com/Shopify/polaris/assets/18447883/2f2e2f76-adbc-4bed-a18b-c09a23b7542e"/>|<video src="https://github.com/Shopify/polaris/assets/18447883/4b097d18-4c0c-4fec-b561-9fc9ba2c55b9"/>| ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Jess Telford <jess.telford@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for c7c2312 - Browse repository at this point
Copy the full SHA c7c2312View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05b1dcd - Browse repository at this point
Copy the full SHA 05b1dcdView commit details -
Polaris tokens major version upgrades (#10801)
This PR introduces breaking changes, including additions and deprecations, as part of the major version upgrade to `@shopify/polaris-tokens`. The key changes include: - Introduced `themeNameDefault` constant. - Deprecated `tokens` export (replace with `themeDefault`). - Introduced `themeDefault` export (convenience alias for `themes[themeNameDefault]`). - Deprecated all individual token group exports e.g. `color`, `space`, `motion`, etc... - Deprecated `metadata` export (replace with `metaThemeDefault`). - Introduced `metaThemeDefault` export (convenience alias for `metaThemes[themeNameDefault]`). - Introduced new theme types: * `ThemeName` * `MetaTheme` * `MetaThemeShape` * `MetaTokenGroupShape` * `MetaTokenProperties` * `Theme` - Renamed `MetadataGroup` to `MetaTokenGroupShape`. - Renamed `getCustomPropertyNames` to `getThemeVarNames`. - Introduced `isTokenName` type guard (ensure an unknown value is a valid theme token). - Updated `createVar` utility (now creates a complete CSS variable function e.g. ```ts // Before: createVar('token-name') //=> '--p-token-name' // After: createVar('token-name') //=> 'var(--p-token-name)' ``` - Renamed `createVar` to `createVarName`. - Introduced `createVarName` utility (behaves similar to the legacy `createVar` utility). - Exposed `metaThemes` object containing all meta theme objects (useful for low level integrations such as the Polaris site, Polaris for VS Code, etc...). - Deprecated a collection of unintentionally exposed Polaris utils and types: * `getUnit` * `toEm` * `rem` * `tokensToRems` * `getKeyframeNames` * `removeMetadata` * `MetaBreakpointsTokenGroup` * `BreakpointsAliasDirectionMediaConditions` * `BreakpointsMediaConditions` * `isKeyOf` * `createExact` * `createMetadata` - Deprecated `@shopify/polaris-tokens/json` entry point. --------- Co-authored-by: Sophie Schneider <thesophieschneider@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2cdc59f - Browse repository at this point
Copy the full SHA 2cdc59fView commit details -
Update stepped migration documentation (#10815)
### WHY are these changes introduced? Updates and aligns all stepped migration documentation. ### WHAT is this pull request doing? Improves documentation for stepped migrations to make them more clear and decrease scrolling between sections.
Configuration menu - View commit details
-
Copy full SHA for e2c1691 - Browse repository at this point
Copy the full SHA e2c1691View commit details -
[polaris.shopify.com] Add new
/design/icons
design guidance (#10672)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10694 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 15f70ce - Browse repository at this point
Copy the full SHA 15f70ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb2a131 - Browse repository at this point
Copy the full SHA eb2a131View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f1734 - Browse repository at this point
Copy the full SHA e4f1734View commit details -
Version Packages (beta) (#10718)
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.
⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @shopify/polaris@12.0.0-beta.2 ### Major Changes - [#10705](#10705) [`c7c2312f7`](c7c2312) Thanks [@chloerice](https://github.com/chloerice)! - - Removed the `subdued` and `status` props from `IndexTable.Row`. Use `tone` instead. - [#10778](#10778) [`b126f64e6`](b126f64) Thanks [@laurkim](https://github.com/laurkim)! - Migrated `shadow` custom properties from v11 to v12 - [#10762](#10762) [`1ef71164c`](1ef7116) Thanks [@laurkim](https://github.com/laurkim)! - Migrated `font` custom properties from v11 to v12 - [#10741](#10741) [`2c2bb0e09`](2c2bb0e) Thanks [@laurkim](https://github.com/laurkim)! - - Migrated `border` custom properties from v11 to v12 - Removed backwards compatibility for v11 border tokens on `Tooltip` component `BorderRadius` type - Updated JSDoc prop type descriptions to include updated `border` custom properties on `Divider` and `Tooltip` components - [#10744](#10744) [`a4f5e7df3`](a4f5e7d) Thanks [@mrcthms](https://github.com/mrcthms)! - Removed deprecated `disable1Password` prop from `TextField`. - [#10727](#10727) [`179b481d7`](179b481) Thanks [@laurkim](https://github.com/laurkim)! - Migrated `space` custom properties from v11 to v12 Removed backwards compatibility for v11 border tokens on `Tooltip` component `Padding` type Updated JSDoc prop type descriptions to include updated `padding` custom properties on `Box` component - [#10669](#10669) [`794d1f5e4`](794d1f5) Thanks [@lgriffee](https://github.com/lgriffee)! - Added `border-radius` semantic layer - [#10745](#10745) [`a4205eee1`](a4205ee) Thanks [@mrcthms](https://github.com/mrcthms)! - [IndexFilters] Remove IndexFiltersManager in AppProvider - [#10773](#10773) [`f6bc29ade`](f6bc29a) Thanks [@laurkim](https://github.com/laurkim)! - Removed support for `headingXs` and `heading4xl` variants and replaced usage with `headingSm` and `heading3xl` ### Minor Changes - [#10722](#10722) [`14a94967d`](14a9496) Thanks [@laurkim](https://github.com/laurkim)! - Added support for `emphasis` and `text` tones on `Icon` and migrated `primary` and `subdued` tone color tokens - [#10788](#10788) [`82f10e830`](82f10e8) Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the IndexFiltersManager component ### Patch Changes - Updated dependencies \[[`2a467249f`](2a46724), [`2cdc59f88`](2cdc59f), [`794d1f5e4`](794d1f5), [`08aaf11ec`](08aaf11)]: - @shopify/polaris-tokens@8.0.0-beta.1 ## @shopify/polaris-tokens@8.0.0-beta.1 ### Major Changes - [#10760](#10760) [`2a467249f`](2a46724) Thanks [@lgriffee](https://github.com/lgriffee)! - Updated `shadow` token values - [#10801](#10801) [`2cdc59f88`](2cdc59f) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Deprecated a collection of types, utils, and JSON exports - [#10673](#10673) [`08aaf11ec`](08aaf11) Thanks [@lgriffee](https://github.com/lgriffee)! - Updated `font-size` and `font-weight` token values ### Minor Changes - [#10669](#10669) [`794d1f5e4`](794d1f5) Thanks [@lgriffee](https://github.com/lgriffee)! - Added `border-radius` semantic layer ## @shopify/stylelint-polaris@14.1.2-beta.1 ### Patch Changes - Updated dependencies \[[`2a467249f`](2a46724), [`2cdc59f88`](2cdc59f), [`794d1f5e4`](794d1f5), [`08aaf11ec`](08aaf11)]: - @shopify/polaris-tokens@8.0.0-beta.1 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sophie Schneider <thesophieschneider@gmail.com>Configuration menu - View commit details
-
Copy full SHA for f00bdcd - Browse repository at this point
Copy the full SHA f00bdcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22d7e06 - Browse repository at this point
Copy the full SHA 22d7e06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ca11cb - Browse repository at this point
Copy the full SHA 5ca11cbView commit details -
[polaris.shopify.com] Add
Docs
depth pages (#10706)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10695 <!-- link to issue if one exists --> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Add grid-column values to DoDont component such that Do and Dont components always render in the correct grid-area. - Add "margin considered harmful" selector to gate margin styles in `DoDont` component. - Add depth/index page - Add depth/creating-depth page <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 43eb9c0 - Browse repository at this point
Copy the full SHA 43eb9c0View commit details -
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10692 <!-- link to issue if one exists --> <img width="2032" alt="Screenshot 2023-10-03 at 4 54 31 PM" src="https://github.com/Shopify/polaris/assets/4642404/11f35875-b33b-43c2-a186-4e1515dd7256"> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedOct 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 996b86f - Browse repository at this point
Copy the full SHA 996b86fView commit details -
[polaris.shopify.com] Update Colors content (#10657)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Closes #10020 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Updates `Color` and moves it to an `Overview` page - Adds `Palettes and roles` subpage - Adds `Using color` subpage - Adds images and layout for all three pages - Updates the `Colors` component in `mdx` to become an interactive color contrast checker. <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d2b2bfc - Browse repository at this point
Copy the full SHA d2b2bfcView commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 771422f - Browse repository at this point
Copy the full SHA 771422fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ecdfca - Browse repository at this point
Copy the full SHA 3ecdfcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2803bcb - Browse repository at this point
Copy the full SHA 2803bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42b2731 - Browse repository at this point
Copy the full SHA 42b2731View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51544ef - Browse repository at this point
Copy the full SHA 51544efView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4cde9c - Browse repository at this point
Copy the full SHA f4cde9cView commit details -
[polaris.shopify.com] Add Motion docs (#10862)
Closes #10696 --------- Co-authored-by: Charles Lee <charles.lee@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for e47ed01 - Browse repository at this point
Copy the full SHA e47ed01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 610ffd7 - Browse repository at this point
Copy the full SHA 610ffd7View commit details -
Add
Layout
Overview
andSpacial organization
pages (#10872)### WHY are these changes introduced? Part of #10693
Configuration menu - View commit details
-
Copy full SHA for b99a0b3 - Browse repository at this point
Copy the full SHA b99a0b3View commit details -
[InlineGrid] Fix typo in typedoc @example for
columns
prop (#10873)This PR fixes the typo in the `InlineGrid` `columns` prop typedoc description accidentally migrated to the spacing scale.
Configuration menu - View commit details
-
Copy full SHA for c306931 - Browse repository at this point
Copy the full SHA c306931View commit details -
Remove the `Space` page from the website --------- Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7c186c0 - Browse repository at this point
Copy the full SHA 7c186c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2843a43 - Browse repository at this point
Copy the full SHA 2843a43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 939d57b - Browse repository at this point
Copy the full SHA 939d57bView commit details -
[AppProvider] Disable calt font ligatures (#10871)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The Inter font has several configurable font settings. By default, `calt` ligatures are not disabled. This causes unwanted change in the presentation of letters to be symbols, e.g., "x" appearing as a multiply symbol when between numbers like `7x8`. This is a problem for automated unique identifiers, like Hydrogen deploy hashes in the `/custom-storefronts` section of the admin: https://github.com/Shopify/polaris/assets/18447883/e8c4d2a1-9d22-42a7-a585-a158e9dcb1b5 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR disables `calt` ligatures in the base styles of the `AppProvider`. | Before | After | |--------|--------| | <img width="239" alt="Screenshot 2023-10-04 at 2 25 05 PM" src="https://github.com/Shopify/polaris/assets/18447883/346bc486-866c-4d64-8fd2-1d13bcad8a0c">| <img width="237" alt="Screenshot 2023-10-04 at 2 24 50 PM" src="https://github.com/Shopify/polaris/assets/18447883/fc9f8cc4-d3bc-4d86-8ba4-dd466ed1f4ed"> | <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page, Text} from '../src'; export function Playground() { return ( <Page title="Discounts"> <Text as="p">xguxh880x9klaslojoffihghgthslohfijkl</Text> </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 77744cb - Browse repository at this point
Copy the full SHA 77744cbView commit details -
[polaris.shopify.com] Update design principles -> Pro design language…
… and add menu ordering (#10880) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10691 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? - Changes the page from `Design principles` to `Pro design language` - Updates images and videos - Updates content - Changes the ordering of menu elements, so updated pages are first. - Adds `New` tag to all updated pages - Removes `New` tag from `Patterns` page because that section is no longer considered `New` <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for bfea576 - Browse repository at this point
Copy the full SHA bfea576View commit details -
Configuration menu - View commit details
-
Copy full SHA for 006fdd9 - Browse repository at this point
Copy the full SHA 006fdd9View commit details -
Add
showTOC
to/design/motion
and/design/layout
(#10883)<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Table of contents was missing from the Motion and Layout `index.md` pages. Adding the `showTOC` property to both <img width="2032" alt="Screenshot 2023-10-04 at 4 57 36 PM" src="https://github.com/Shopify/polaris/assets/4642404/13c3d213-f565-41bf-a421-f6c9c2a0f5de"> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedOct 4, 2023 Configuration menu - View commit details
-
Copy full SHA for 28e90a8 - Browse repository at this point
Copy the full SHA 28e90a8View commit details -
Fix Banner hydration error (#10882)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes[ hydration error following next guidance](https://nextjs.org/docs/app/building-your-application/optimizing/lazy-loading#skipping-ssr). More info in the code comments <img width="2032" alt="Screenshot 2023-10-04 at 3 29 52 PM" src="https://github.com/Shopify/polaris/assets/4642404/5c1ce40e-2617-4d1c-8c27-a4fe9a20f5ea"> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Yuraima Estevez committedOct 4, 2023 Configuration menu - View commit details
-
Copy full SHA for e71df73 - Browse repository at this point
Copy the full SHA e71df73View commit details -
[polaris.shopify.com] DoDont remove dead code (#10884)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? The styles were removed in #10877 as they were conflicting with InlineGrid application. This PR removes the className application as well so that we don't have dead class references. Originally these were added to ensure Dos and Donts always render in the correct track (left for Dos and right for Donts), but the edge cases that this code accounted for no longer exist 👍, so this is safe to remove. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for d250c62 - Browse repository at this point
Copy the full SHA d250c62View commit details
Commits on Oct 5, 2023
-
Revert "Fix Banner hydration error (#10882)"
This reverts commit e71df73.
Configuration menu - View commit details
-
Copy full SHA for 611dd76 - Browse repository at this point
Copy the full SHA 611dd76View commit details -
[polaris.shopify.com] Load correct Inter variable font weights (#10895)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10894 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Load the correct font weights for regular ~`400`~ `450` and semibold ~`600`~ `650` tokens. Updates migration guide and any other documentation (like the readme) where the Inter font load string is present to include the correct weights, and removes unnecessary weights (`100`, `200`, `300` and `800`, `900`) Before: ![image](https://github.com/Shopify/polaris/assets/67433661/9755c831-1a1b-4ca0-883b-c225ef4f1161) After: ![image](https://github.com/Shopify/polaris/assets/67433661/045edf8b-cdbe-4c6c-97f7-f47b6182c705) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 7f1c924 - Browse repository at this point
Copy the full SHA 7f1c924View commit details -
Fixed typos, ordering and icons (#10901)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? - Fixes alignment issues between pages - Fixes some ordering issues in some sections - Adds icons for Motion pages - Fixes some typos <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? | Before | After | |--------|-------| | ![image](https://github.com/Shopify/polaris/assets/67433661/b5a55249-b0b5-4e4c-bd46-c93af5fc3897) | ![image](https://github.com/Shopify/polaris/assets/67433661/1dd2f8e7-54d3-49bf-940b-ac6e0e5dc0ca) | | ![image](https://github.com/Shopify/polaris/assets/67433661/ab6a82e3-16b6-4f73-89e7-c233fa333406) | ![image](https://github.com/Shopify/polaris/assets/67433661/de54cb8e-e8c6-4c0a-833d-b1329ea69b7c) | | ![image](https://github.com/Shopify/polaris/assets/67433661/ab02e689-99b4-49d7-8a6c-7f0e43cbd061) | ![image](https://github.com/Shopify/polaris/assets/67433661/0b6bc969-39e5-4703-971b-c94cfac05094) | | ![image](https://github.com/Shopify/polaris/assets/67433661/8e67dedc-503e-4e18-936c-362e037c580d) | ![image](https://github.com/Shopify/polaris/assets/67433661/74f6ce7e-55c7-4c2b-8fa2-9ea7dd96583c) | ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Configuration menu - View commit details
-
Copy full SHA for 953ebf2 - Browse repository at this point
Copy the full SHA 953ebf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d97815 - Browse repository at this point
Copy the full SHA 9d97815View commit details -
Update button migration examples (#10903)
### WHY are these changes introduced? Adds an example of what's to be expected when migrating a `<Button primary plain monochrome />` element. I don't think we don't want to default to a new style, like `plain monochrome` which might be the safest, because consumers may want to opt for the `plain` variant. So we just insert a comment and defer to the team / section responsible
Configuration menu - View commit details
-
Copy full SHA for 410b538 - Browse repository at this point
Copy the full SHA 410b538View commit details -
Migration guide polish and examples (#10889)
Fixes #10806 1. Added support for `<details>` toggles on markdown 2. Added support for `collabsibleTOC` pages (off by default) so you can quickly skip to the section you need. This isn't perfect yet (doesn't auto open when linking directly to an anchor) but is much better than what we currently have 3. Organized v11 to v12 styleguide into consistent steps 4. Put regex validation, mapping tables, and examples in details toggles to make the page less overwhelming and put migration commands at the forefront 5. Added introduction, glossary, and generalized the migration workflow section. Put these at the top to introduce builders to the migration 6. Added descriptive titles to all component migrations naming what they do 7. Added examples to each component migration and removed them from the "Whats new" page 8. Added regex validation snippets to all component migrations 9. Added alert text for stepped migrations that have to be run in order 10. Cleaned up copy and overall improved migration experience giving more context on how and why we are running the migrations. Aimed to make it clear enough that an intern could run a migration on their code base 11. Add padding to code blocks ![toc-demo](https://github.com/Shopify/polaris/assets/20652326/c1b012b6-b576-405f-a69e-f7cc085d66f2) ![Screen Recording 2023-10-05 at 3 09 18 PM](https://github.com/Shopify/polaris/assets/20652326/4999bcbe-960b-4718-ba73-04963eeed302) --------- Co-authored-by: Lo Kim <lo.kim@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for e8fab65 - Browse repository at this point
Copy the full SHA e8fab65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 521f033 - Browse repository at this point
Copy the full SHA 521f033View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47463a1 - Browse repository at this point
Copy the full SHA 47463a1View commit details
Commits on Oct 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e66c6ec - Browse repository at this point
Copy the full SHA e66c6ecView commit details -
[polaris.shopify.com][Migration guide] Replace <path> with default gl…
…ob path (#10913) Having a `<path>` placeholder on the migration commands can get pretty tedious to replace. I've added a default glob path so at least consumers with a ts/tsx/css/scss architecture can copy and paste the commands out of the box. I've also added a note that consumers can replace the default glob path if they need to
Configuration menu - View commit details
-
Copy full SHA for e735554 - Browse repository at this point
Copy the full SHA e735554View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac17f9 - Browse repository at this point
Copy the full SHA aac17f9View commit details -
Sort
color
tokens ascending (#10904)Co-authored-by: Sara Hill <sarashill22@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 12e1d90 - Browse repository at this point
Copy the full SHA 12e1d90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85880d8 - Browse repository at this point
Copy the full SHA 85880d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 099f304 - Browse repository at this point
Copy the full SHA 099f304View commit details -
Revert "Revert "Executing
useBreakpoints
isormophically no longer t… (#10918) …riggers a Hydration mismatch error or rendering bugs." (#10916)" This reverts #10916 to reapply #10886 cc @jesstelford
Configuration menu - View commit details
-
Copy full SHA for aaf61fe - Browse repository at this point
Copy the full SHA aaf61feView commit details -
[polaris.shopify.com] Add aspect ratios on thumbnail preview (#10924)
### WHY are these changes introduced? Fixes #10908 This PR adds the ability to be more specific about which aspect ratios need to be applied to specific images but the issue was sparse so I don't know of other places that need to be fixed. Let me know and I'll update with screenshots It also fixes a bg color mismatch between image bg and thumbnail bg color ### WHAT is this pull request doing? Before: ![image](https://github.com/Shopify/polaris/assets/6844391/fee88088-066c-4907-b3f5-af4d89dc3148) After: ![specific-aspect-ratios](https://github.com/Shopify/polaris/assets/6844391/bb54e847-c554-4637-96b0-46acf9d69f9d) ![localhost_3000_design_colors (1)](https://github.com/Shopify/polaris/assets/6844391/693283fe-b7c0-4ddb-b22c-3b139fb75a7d) ![localhost_3000_design_colors (2)](https://github.com/Shopify/polaris/assets/6844391/81f4b922-26c5-4fb1-a399-d0e588e032f3)
Configuration menu - View commit details
-
Copy full SHA for de45d86 - Browse repository at this point
Copy the full SHA de45d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe291f - Browse repository at this point
Copy the full SHA 1fe291fView commit details