Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polaris.shopify.com] Update design principles -> Pro design language and add menu ordering #10880

Merged
merged 2 commits into from
Oct 4, 2023
Merged

[polaris.shopify.com] Update design principles -> Pro design language and add menu ordering #10880

merged 2 commits into from
Oct 4, 2023

Conversation

tjonx
Copy link
Contributor

@tjonx tjonx commented Oct 4, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes #10691

WHAT is this pull request doing?

  • Changes the page from Design principles to Pro design language
  • Updates images and videos
  • Updates content
  • Changes the ordering of menu elements, so updated pages are first.
  • Adds New tag to all updated pages
  • Removes New tag from Patterns page because that section is no longer considered New

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@tjonx tjonx self-assigned this Oct 4, 2023
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Oct 4, 2023
@tjonx tjonx added 🤖Skip Changelog Causes CI to ignore changelog update check. #gsd:36550 and removed cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. labels Oct 4, 2023
@tjonx tjonx changed the base branch from main to next October 4, 2023 20:09
@tjonx tjonx marked this pull request as ready for review October 4, 2023 20:09
@tjonx tjonx requested review from sam-b-rose, aveline and a team and removed request for aveline and sam-b-rose October 4, 2023 20:11
@tjonx
Copy link
Contributor Author

tjonx commented Oct 4, 2023

I have signed the CLA!

@tjonx tjonx merged commit bfea576 into next Oct 4, 2023
3 checks passed
@tjonx tjonx deleted the tjonx/update-design-principles branch October 4, 2023 20:25
mrcthms pushed a commit that referenced this pull request Oct 12, 2023
@tjonx @mrcthms
[polaris.shopify.com] Update design principles -> Pro design language…
4f4707e 
… and add menu ordering (#10880)

<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10691

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

- Changes the page from `Design principles` to `Pro design language`
- Updates images and videos
- Updates content
- Changes the ordering of menu elements, so updated pages are first.
- Adds `New` tag to all updated pages
- Removes `New` tag from `Patterns` page because that section is no
longer considered `New`

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
mrcthms pushed a commit that referenced this pull request Oct 12, 2023
@tjonx @mrcthms
[polaris.shopify.com] Update design principles -> Pro design language…
d5da641 
… and add menu ordering (#10880)

<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10691

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

- Changes the page from `Design principles` to `Pro design language`
- Updates images and videos
- Updates content
- Changes the ordering of menu elements, so updated pages are first.
- Adds `New` tag to all updated pages
- Removes `New` tag from `Patterns` page because that section is no
longer considered `New`

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@tjonx
[polaris.shopify.com] Update design principles -> Pro design language…
4aa29fe 
… and add menu ordering (Shopify#10880)

<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes Shopify#10691

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

- Changes the page from `Design principles` to `Pro design language`
- Updates images and videos
- Updates content
- Changes the ordering of menu elements, so updated pages are first.
- Adds `New` tag to all updated pages
- Removes `New` tag from `Patterns` page because that section is no
longer considered `New`

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurm04 yurm04 yurm04 approved these changes

Assignees

@tjonx tjonx

Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Markdown] Transfer Design Principles
2 participants
@tjonx @yurm04