[Badge] Update props and tokens #10307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
badge_update-props
branch
3 times, most recently
from
3b96587
to
7743e25
Compare
kyledurand
force-pushed
the
badge_update-props
branch
from
7743e25
to
711dd9a
Compare
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| @@ -29,7 +29,7 @@ | |||
| "partiallyComplete": "Partially complete", | |||
| "complete": "Complete" | |||
| }, | |||
| "STATUS_LABELS": { | |||
| "TONE_LABELS": { | |||
| "info": "Info", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Infofor keyPolaris.Badge.TONE_LABELS.infois very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -29,7 +29,7 @@ | |||
| "partiallyComplete": "Partially complete", | |||
| "complete": "Complete" | |||
| }, | |||
| "STATUS_LABELS": { | |||
| "TONE_LABELS": { | |||
| "info": "Info", | |||
| "success": "Success", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Successfor keyPolaris.Badge.TONE_LABELS.successis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -29,7 +29,7 @@ | |||
| "partiallyComplete": "Partially complete", | |||
| "complete": "Complete" | |||
| }, | |||
| "STATUS_LABELS": { | |||
| "TONE_LABELS": { | |||
| "info": "Info", | |||
| "success": "Success", | |||
| "warning": "Warning", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Warningfor keyPolaris.Badge.TONE_LABELS.warningis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
kyledurand
force-pushed
the
badge_update-props
branch
from
4a479c0
to
ad7e612
Compare
kyledurand
force-pushed
the
badge_update-props
branch
from
ad7e612
to
f23f455
Compare
kyledurand
force-pushed
the
badge_update-props
branch
from
f23f455
to
6660c18
Compare
kyledurand
pushed a commit
that referenced
this pull request
Sep 6, 2023
This PR adds async translations requested in #10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
kyledurand
pushed a commit
that referenced
this pull request
Sep 7, 2023
This PR adds async translations requested in #10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes https://github.com/Shopify/polaris/issues/10277ds <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Replaces status prop with tone Removes experimental prefix from values
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
This PR adds async translations requested in #10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
This PR adds async translations requested in #10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes https://github.com/Shopify/polaris/issues/10277ds <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Replaces status prop with tone Removes experimental prefix from values
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
This PR adds async translations requested in Shopify#10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
This PR adds async translations requested in Shopify#10307, which was opened by @kyledurand. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/10307/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` Translation Platform command will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=10307` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris/issues/10277ds
WHAT is this pull request doing?
Replaces status prop with tone
Removes experimental prefix from values