-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v12 #10060
v12 #10060
Conversation
5d459f8
to
700a72f
Compare
Should get ci to 🟢
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Part of #9984 Documentation improvement will be done in a follow up <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9963 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> - Change control-height to be 32px - `Select` consolidate se23 styles ### How to 🎩 * [Storybook](https://5d559397bae39100201eedc1-oiuqenxfoy.chromatic.com/?path=/story/all-components-select--all) * [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-select--all) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10033 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Deprecates `borderless` prop in favor of `variant='borderless'`
### WHY are these changes introduced? Fixes #9943 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `Layout` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-layout--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-afpqefhquh.chromatic.com/?path=/story/all-components-layout--annotated)
### WHY are these changes introduced? Fixes #9935 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `FormLayout` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-formlayout--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-uozkfkbgfn.chromatic.com/?path=/story/all-components-formlayout--all)
### WHY are these changes introduced? Resolves #9949 . ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Listbox`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-dojywcrcgy.chromatic.com/?path=/story/all-components-listbox--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-listbox--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
### WHY are these changes introduced? Fixes #9932 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `DropZone` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-dropzone--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-qvidvpjgoo.chromatic.com/?path=/story/all-components-dropzone--default)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Part of #9985 <!-- Context about the problem that’s being addressed. -->
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #9947 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> - consolidate se23 styles ### How to 🎩 * [Storybook](https://5d559397bae39100201eedc1-vcnbnkugpz.chromatic.com/?path=/story/all-components-link--default) * [Prod storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-link--default&globals=polarisSummerEditions2023:true) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
### WHY are these changes introduced? Resolves #9948. ### WHAT is this pull request doing? Consolidates se23 beta styles for `List`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-yvvnglksbe.chromatic.com/?path=/story/all-components-list--bulleted) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-list--bulleted&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
### WHY are these changes introduced? Fixes #9931 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `DatePicker` Component Add story delay for datepicker since the "All" test hasn't been rendering in time on some PRs ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datepicker--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-pxozkstezh.chromatic.com/?path=/story/all-components-datepicker--all)
### WHY are these changes introduced? Fixes #9950 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `MediaCard` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-mediacard--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-tugvkbzhsc.chromatic.com/?path=/story/all-components-mediacard--default)
### WHY are these changes introduced? Fixes #9942 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `Labelled` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-textfield--with-help-text&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-spdehluzut.chromatic.com/?path=/story/all-components-textfield--with-help-text)
### WHY are these changes introduced? Fixes #9940 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `InlineError` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-inlineerror--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-aqogixplqr.chromatic.com/?path=/story/all-components-inlineerror--default)
### WHY are these changes introduced? Fixes #9955 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `PageActions` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-pageactions--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-ddfrdxnifw.chromatic.com/?path=/story/all-components-pageactions--default)
### WHY are these changes introduced? Fixes #9959 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `PageActions` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-progressbar--default&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-lasqorkejk.chromatic.com/?path=/story/all-components-progressbar--default)
### WHY are these changes introduced? Fixes #9964 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `SettingAction` Component ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-settingtoggle--with-deprecated-component&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-iqwftdxoka.chromatic.com/?path=/story/all-components-settingtoggle--with-deprecated-component)
### WHY are these changes introduced? Resolves #9951. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Modal`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-tqhardweqn.chromatic.com/?path=/story/all-components-modal--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-modal--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
…ob path (#10913) Having a `<path>` placeholder on the migration commands can get pretty tedious to replace. I've added a default glob path so at least consumers with a ts/tsx/css/scss architecture can copy and paste the commands out of the box. I've also added a note that consumers can replace the default glob path if they need to
/stageit |
|
#10918) …riggers a Hydration mismatch error or rendering bugs." (#10916)" This reverts #10916 to reapply #10886 cc @jesstelford
### WHY are these changes introduced? Fixes #10908 This PR adds the ability to be more specific about which aspect ratios need to be applied to specific images but the issue was sparse so I don't know of other places that need to be fixed. Let me know and I'll update with screenshots It also fixes a bg color mismatch between image bg and thumbnail bg color ### WHAT is this pull request doing? Before: ![image](https://github.com/Shopify/polaris/assets/6844391/fee88088-066c-4907-b3f5-af4d89dc3148) After: ![specific-aspect-ratios](https://github.com/Shopify/polaris/assets/6844391/bb54e847-c554-4637-96b0-46acf9d69f9d) ![localhost_3000_design_colors (1)](https://github.com/Shopify/polaris/assets/6844391/693283fe-b7c0-4ddb-b22c-3b139fb75a7d) ![localhost_3000_design_colors (2)](https://github.com/Shopify/polaris/assets/6844391/81f4b922-26c5-4fb1-a399-d0e588e032f3)
/stageit |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Polaris v12
Polaris v12