Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polaris.shopify.com][Migration guide] Replace <path> with default glob path #10913

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

sophschneider
Copy link
Contributor

Having a <path> placeholder on the migration commands can get pretty tedious to replace. I've added a default glob path so at least consumers with a ts/tsx/css/scss architecture can copy and paste the commands out of the box. I've also added a note that consumers can replace the default glob path if they need to

Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@sophschneider sophschneider merged commit e735554 into next Oct 6, 2023
7 checks passed
@sophschneider sophschneider deleted the sophie/replace-path branch October 6, 2023 14:11
mrcthms pushed a commit that referenced this pull request Oct 12, 2023
…ob path (#10913)

Having a `<path>` placeholder on the migration commands can get pretty
tedious to replace. I've added a default glob path so at least consumers
with a ts/tsx/css/scss architecture can copy and paste the commands out
of the box. I've also added a note that consumers can replace the
default glob path if they need to
mrcthms pushed a commit that referenced this pull request Oct 12, 2023
…ob path (#10913)

Having a `<path>` placeholder on the migration commands can get pretty
tedious to replace. I've added a default glob path so at least consumers
with a ts/tsx/css/scss architecture can copy and paste the commands out
of the box. I've also added a note that consumers can replace the
default glob path if they need to
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
…ob path (Shopify#10913)

Having a `<path>` placeholder on the migration commands can get pretty
tedious to replace. I've added a default glob path so at least consumers
with a ts/tsx/css/scss architecture can copy and paste the commands out
of the box. I've also added a note that consumers can replace the
default glob path if they need to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants