-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc site token pages #10719
Merged
Merged
Update doc site token pages #10719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgriffee
requested review from
chloerice,
sophschneider,
laurkim and
aaronccasanova
September 28, 2023 23:26
laurkim
approved these changes
Sep 28, 2023
chloerice
approved these changes
Sep 28, 2023
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#10660 ### WHAT is this pull request doing? - Removes truncation of token table cell data - Removes logic to filter out experimental tokens - Temporarily hides Figma token table column until we have Figma vars listed - Updates table column headers - Aligns `—` symbols so they are consistent across token groups - Converts token table values to px - Adds new token groups to doc site - Removes legacy token group page on doc site - Adds token previews for new token groups - Adds new token groups to token tabs - Updates tab styling to accommodate more tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #10660
WHAT is this pull request doing?
—
symbols so they are consistent across token groups