Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc site token pages #10719

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Update doc site token pages #10719

merged 11 commits into from
Sep 28, 2023

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Sep 27, 2023

WHY are these changes introduced?

Fixes #10660

WHAT is this pull request doing?

  • Removes truncation of token table cell data
  • Removes logic to filter out experimental tokens
  • Temporarily hides Figma token table column until we have Figma vars listed
  • Updates table column headers
  • Aligns symbols so they are consistent across token groups
  • Converts token table values to px
  • Adds new token groups to doc site
  • Removes legacy token group page on doc site
  • Adds token previews for new token groups
  • Adds new token groups to token tabs
  • Updates tab styling to accommodate more tabs

@lgriffee lgriffee marked this pull request as ready for review September 28, 2023 23:31
@lgriffee lgriffee requested review from a team as code owners September 28, 2023 23:31
@lgriffee lgriffee merged commit cf26411 into next Sep 28, 2023
11 checks passed
@lgriffee lgriffee deleted the token-pages-doc-site-updates branch September 28, 2023 23:46
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Fixes Shopify#10660 


### WHAT is this pull request doing?

- Removes truncation of token table cell data
- Removes logic to filter out experimental tokens
- Temporarily hides Figma token table column until we have Figma vars
listed
- Updates table column headers
- Aligns `—` symbols so they are consistent across token groups
- Converts token table values to px
- Adds new token groups to doc site
- Removes legacy token group page on doc site
- Adds token previews for new token groups
- Adds new token groups to token tabs
- Updates tab styling to accommodate more tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants