Move level 3 nav items to page subnav #10509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurm04
approved these changes
Sep 18, 2023
tjonx
approved these changes
Sep 18, 2023
sam-b-rose
force-pushed
the
10151-docs-subnav
branch
from
11de971
to
ac6902b
Compare
sam-b-rose
force-pushed
the
10151-docs-subnav
branch
from
ac6902b
to
070855f
Compare
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
Closes #10151 Creates a `Subnav` component that will inject subnav items into the MDX. We could also probably add this to the `Lede` component, but it is currently a standalone component. > [!Note] > The styles aren't updated, but are scaffolded to be quickly updated with the Uplift colors and Figma spec ```mdx <Lede>{title}</Ledel> <Subnav /> ``` ### Screenshot example using Typography <img width="1471" alt="subnav-proto" src="https://github.com/Shopify/polaris/assets/11774595/270a00d8-15f9-484b-a5d5-de8fd162eb6f">
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Closes Shopify#10151 Creates a `Subnav` component that will inject subnav items into the MDX. We could also probably add this to the `Lede` component, but it is currently a standalone component. > [!Note] > The styles aren't updated, but are scaffolded to be quickly updated with the Uplift colors and Figma spec ```mdx <Lede>{title}</Ledel> <Subnav /> ``` ### Screenshot example using Typography <img width="1471" alt="subnav-proto" src="https://github.com/Shopify/polaris/assets/11774595/270a00d8-15f9-484b-a5d5-de8fd162eb6f">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10151
Creates a
Subnavcomponent that will inject subnav items into the MDX. We could also probably add this to theLedecomponent, but it is currently a standalone component.Note
The styles aren't updated, but are scaffolded to be quickly updated with the Uplift colors and Figma spec
Screenshot example using Typography