Remove shadow-bevel opt out logic #10234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
commented
Aug 25, 2023
| $border: var(--pc-app-provider-shadow-bevel-border), | ||
| $content: var(--pc-app-provider-shadow-bevel-content), | ||
| $border: null, | ||
| $content: '', |
There was a problem hiding this comment.
Had to keep content as '' to preserve bevel styles.
sophschneider
approved these changes
Aug 25, 2023
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Resolves #10194. Removes shadow bevel opt out logic (except for storybook as that's a separate issue). ### How to 🎩 [Banner Storybook](https://5d559397bae39100201eedc1-tnqlfybcue.chromatic.com/?path=/story/all-components-banner--all) [Banner Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-banner--all&globals=polarisSummerEditions2023:true) [AppProvider Storybook](https://5d559397bae39100201eedc1-tnqlfybcue.chromatic.com/?path=/story/all-components-appprovider--default) [AppProvider Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-appprovider--default&globals=polarisSummerEditions2023:true) > Note: small spacing diff in Banner all story is expected because it was updated in `next`. Story matches what's in `next`. 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#10194. Removes shadow bevel opt out logic (except for storybook as that's a separate issue). ### How to 🎩 [Banner Storybook](https://5d559397bae39100201eedc1-tnqlfybcue.chromatic.com/?path=/story/all-components-banner--all) [Banner Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-banner--all&globals=polarisSummerEditions2023:true) [AppProvider Storybook](https://5d559397bae39100201eedc1-tnqlfybcue.chromatic.com/?path=/story/all-components-appprovider--default) [AppProvider Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-appprovider--default&globals=polarisSummerEditions2023:true) > Note: small spacing diff in Banner all story is expected because it was updated in `next`. Story matches what's in `next`. 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #10194.
Removes shadow bevel opt out logic (except for storybook as that's a separate issue).
How to 🎩
Banner Storybook
Banner Prod Storybook
AppProvider Storybook
AppProvider Prod Storybook
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes