New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`ExceptionList` color update #10392

Closed

Tracked by

sarahill opened this issue Sep 9, 2023 · 0 comments · Fixed by #10713

Closed

Tracked by

`ExceptionList` color update #10392

sarahill opened this issue Sep 9, 2023 · 0 comments · Fixed by #10713

Assignees

Contributor

sarahill commented Sep 9, 2023 •

edited

Loading

Update icon color for warning and critical

Old token	New token
icon-critical	text-critical
icon-caution	text-caution

sarahill mentioned this issue

Manual color token updates (epic) #10351

Closed

github-actions bot added the untriaged label

sarahill added #gsd:36565 and removed untriaged labels

laurkim self-assigned this

laurkim mentioned this issue

[ExceptionList] Manually migrate color custom properties for v11 to v12 #10713

Merged

5 tasks

laurkim linked a pull request

that will close this issue

[ExceptionList] Manually migrate color custom properties for v11 to v12 #10713

Merged

5 tasks

laurkim added a commit that referenced this issue


          [ExceptionList] Manually migrate color custom properties for v11 to…

a3c9bfa

… v12 (#10713)

### WHY are these changes introduced?

Resolves #10392.

### WHAT is this pull request doing?

Manually migrates `ExceptionList` component `color` custom properties.
    <details>
      <summary>ExceptionList — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/4f99eaa5-4471-4a7b-9940-d4b6f742215b"
alt="ExceptionList — before">
    </details>
    <details>
      <summary>ExceptionList — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/18de7848-25a8-4761-b848-779e6702ec3a"
alt="ExceptionList — after">
    </details>

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-vhfinvbqwa.chromatic.com/?path=/story/all-components-exceptionlist--all)
[Next branch
storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-exceptionlist--all)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

laurkim closed this as completed

AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue


          [ExceptionList] Manually migrate color custom properties for v11 to…

cfb7349

… v12 (Shopify#10713)

### WHY are these changes introduced?

Resolves Shopify#10392.

### WHAT is this pull request doing?

Manually migrates `ExceptionList` component `color` custom properties.
    <details>
      <summary>ExceptionList — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/4f99eaa5-4471-4a7b-9940-d4b6f742215b"
alt="ExceptionList — before">
    </details>
    <details>
      <summary>ExceptionList — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/18de7848-25a8-4761-b848-779e6702ec3a"
alt="ExceptionList — after">
    </details>

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-vhfinvbqwa.chromatic.com/?path=/story/all-components-exceptionlist--all)
[Next branch
storybook](https://5d559397bae39100201eedc1-iqlmktwkqx.chromatic.com/?path=/story/all-components-exceptionlist--all)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment