New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Page] Consolidate se23 logic and styles #9954

Closed

Tracked by

sophschneider opened this issue Aug 9, 2023 · 0 comments

Closed

Tracked by

[Page] Consolidate se23 logic and styles #9954

sophschneider opened this issue Aug 9, 2023 · 0 comments

Assignees

Contributor

sophschneider commented Aug 9, 2023

No description provided.

sophschneider mentioned this issue

[Epic] Remove conditional se23 logic from polaris-react components #9913

Closed

github-actions bot added the untriaged label

sophschneider added v12 and removed untriaged labels

sophschneider assigned sophschneider and unassigned sophschneider

laurkim self-assigned this

laurkim mentioned this issue

[Page] Consolidate se23 styles and logic #10187

Merged

5 tasks

laurkim added a commit that referenced this issue


          [Page] Consolidate se23 styles and logic (#10187)

8755b46

### WHY are these changes introduced?

Resolves #9954.

### WHAT is this pull request doing?

Consolidates se23 beta styles and logic for `Page`.
Removes `divider` prop as the styles were modified to reset pre-uplift
styles in an earlier [PR](#9537).

### How to 🎩

[Storybook](https://5d559397bae39100201eedc1-rojuobnovi.chromatic.com/?path=/story/all-components-page--default)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--default&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

laurkim closed this as completed

sophschneider pushed a commit that referenced this issue


          [Page] Consolidate se23 styles and logic (#10187)

752e372

Resolves #9954.

Consolidates se23 beta styles and logic for `Page`.
Removes `divider` prop as the styles were modified to reset pre-uplift
styles in an earlier [PR](#9537).

[Storybook](https://5d559397bae39100201eedc1-rojuobnovi.chromatic.com/?path=/story/all-components-page--default)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--default&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue


          [Page] Consolidate se23 styles and logic (Shopify#10187)

### WHY are these changes introduced?

Resolves Shopify#9954.

### WHAT is this pull request doing?

Consolidates se23 beta styles and logic for `Page`.
Removes `divider` prop as the styles were modified to reset pre-uplift
styles in an earlier [PR](Shopify#9537).

### How to 🎩

[Storybook](https://5d559397bae39100201eedc1-rojuobnovi.chromatic.com/?path=/story/all-components-page--default)
[Prod
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--default&globals=polarisSummerEditions2023:true)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment