Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextField - borderless to variant #10033

Closed
Tracked by #9914
kyledurand opened this issue Aug 11, 2023 · 0 comments · Fixed by #10036
Closed
Tracked by #9914

TextField - borderless to variant #10033

kyledurand opened this issue Aug 11, 2023 · 0 comments · Fixed by #10036
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Contributor

No description provided.

@kyledurand kyledurand mentioned this issue Aug 11, 2023
Closed
@kyledurand kyledurand self-assigned this Aug 11, 2023
@kyledurand kyledurand added v12 and removed untriaged labels Aug 11, 2023
@kyledurand kyledurand mentioned this issue Aug 11, 2023
Merged
@sam-b-rose sam-b-rose added #gsd:36573 Polaris API Alignment and removed v12 labels Aug 15, 2023
kyledurand added a commit that referenced this issue Aug 18, 2023
@kyledurand
Textfield add variant prop (#10036)
359614c 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10033

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Deprecates `borderless` prop in favor of `variant='borderless'`
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
Textfield add variant prop (#10036)
f217591 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

Fixes #10033

<!--
  Context about the problem that’s being addressed.
-->

Deprecates `borderless` prop in favor of `variant='borderless'`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Textfield add variant prop Shopify/polaris
2 participants
@kyledurand @sam-b-rose