Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page - Inspect subcomponents, delete additionalNavigation prop #10247

Closed
2 tasks done
Tracked by #9914
kyledurand opened this issue Aug 25, 2023 · 0 comments
Closed
2 tasks done
Tracked by #9914

Page - Inspect subcomponents, delete additionalNavigation prop #10247

kyledurand opened this issue Aug 25, 2023 · 0 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Contributor

kyledurand commented Aug 25, 2023 •
edited
Loading

  • Not many boolean props here, pretty straightforward
  • Remove additionlNavigation and the now unused slot in Page Header
@kyledurand kyledurand mentioned this issue Aug 25, 2023
Closed
@kyledurand kyledurand added #gsd:36573 Polaris API Alignment and removed untriaged labels Aug 25, 2023
@kyledurand kyledurand self-assigned this Aug 25, 2023
@kyledurand kyledurand mentioned this issue Aug 29, 2023
Merged
kyledurand added a commit that referenced this issue Aug 30, 2023
@kyledurand
[Page Header] Remove additionalNavigation prop (#10271)
1125087 
Closes #10247

Low hanging fruit, not used in web, not mentioned in coverage site
either
https://coverage.polaris.shopify.io/usage/component?repo=shopify%2Fweb&type=components&element=%3CPage%3E
@kyledurand kyledurand changed the title Page - Lots of subcomponents to inspect, delete additionalNavigation prop Page - Inspect subcomponents, delete additionalNavigation prop Aug 30, 2023
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
[Page Header] Remove additionalNavigation prop (#10271)
d963e84 
Closes #10247

Low hanging fruit, not used in web, not mentioned in coverage site
either
https://coverage.polaris.shopify.io/usage/component?repo=shopify%2Fweb&type=components&element=%3CPage%3E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyledurand