-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon - Delete backdrop
, change color to tone, fix warning => critical mapping
#10208
Closed
4 tasks done
Tracked by
#9914
Labels
#gsd:36573
Polaris API Alignment
Comments
Closed
Merged
kyledurand
added a commit
that referenced
this issue
Aug 24, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10208 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Removes `backdrop` * Replaces `color` with `tone` * Matches warning tone to warning icon color <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> --------- Co-authored-by: Sara Hill <sara.hill@shopify.com>
kyledurand
added a commit
that referenced
this issue
Aug 29, 2023
sophschneider
pushed a commit
that referenced
this issue
Sep 19, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10208 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Removes `backdrop` * Replaces `color` with `tone` * Matches warning tone to warning icon color <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> --------- Co-authored-by: Sara Hill <sara.hill@shopify.com>
sophschneider
pushed a commit
that referenced
this issue
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: