Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner - status to tone #10050

Closed
2 tasks done
Tracked by #9914
kyledurand opened this issue Aug 14, 2023 · 0 comments
Closed
2 tasks done
Tracked by #9914

Banner - status to tone #10050

kyledurand opened this issue Aug 14, 2023 · 0 comments
Assignees
@kyledurand
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Contributor

kyledurand commented Aug 14, 2023 •
edited
Loading

  • Pending se23 cleanup
  • Change status to tone
@kyledurand kyledurand mentioned this issue Aug 14, 2023
Closed
@kyledurand kyledurand self-assigned this Aug 14, 2023
@kyledurand kyledurand added v12 and removed untriaged labels Aug 14, 2023
@sam-b-rose sam-b-rose added the #gsd:36573 Polaris API Alignment label Aug 15, 2023
@kyledurand kyledurand mentioned this issue Aug 24, 2023
Merged
kyledurand added a commit that referenced this issue Aug 25, 2023
@kyledurand
[Banner] Change status prop to tone (#10206)
dad09bd 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10050

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Changes the status prop on banner to tone
@sarahill sarahill mentioned this issue Sep 11, 2023
Closed
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@kyledurand @sophschneider
[Banner] Change status prop to tone (#10206)
48a7f4d 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10050

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Changes the status prop on banner to tone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyledurand @sam-b-rose