[Tag] Consolidate se23 styles #10141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
force-pushed
the
lo/rm-uplift-tag
branch
from
b81ee8d
to
fea18a4
Compare
laurkim
commented
Aug 21, 2023
| } | ||
|
|
||
| @media #{$p-breakpoints-sm-up} { | ||
| padding: var(--p-space-05) var(--p-space-2); |
There was a problem hiding this comment.
Had to remove this due to specificity issues.
laurkim
commented
Aug 21, 2023
Comment on lines
-86
to
-87
| &.removable { | ||
| padding-right: 0; |
There was a problem hiding this comment.
Moved this to line 80 due to specificity issues.
laurkim
commented
Aug 21, 2023
| // stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY | ||
| font-size: 13px; | ||
| line-height: var(--p-font-line-height-2); | ||
| font-size: var(--p-font-size-80-experimental); |
There was a problem hiding this comment.
Updated font-size: 13px in this file to use the token so that we could clean up stylelint comments.
laurkim
commented
Aug 21, 2023
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| vertical-align: middle; | ||
|
|
||
| @media #{$p-breakpoints-sm-up} { | ||
| font-size: var(--p-font-size-75); | ||
| padding: var(--p-space-05) 0; |
There was a problem hiding this comment.
Removed due to specificity issues.
laurkim
commented
Aug 21, 2023
|
|
||
| svg { | ||
| fill: var(--p-color-icon); | ||
| fill: currentColor; |
There was a problem hiding this comment.
Had to change this to currentColor due to specificity issues on close button for disabled tags.
laurkim
requested review from
jesstelford,
sam-b-rose,
gwyneplaine and
sophschneider
sophschneider
approved these changes
Aug 21, 2023
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Resolves #9970. ### WHAT is this pull request doing? Consolidates se23 beta styles for `Tag`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-mobppokpoq.chromatic.com/?path=/story/all-components-tag--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tag--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#9970. ### WHAT is this pull request doing? Consolidates se23 beta styles for `Tag`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-mobppokpoq.chromatic.com/?path=/story/all-components-tag--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-tag--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #9970.
WHAT is this pull request doing?
Consolidates se23 beta styles for
Tag.How to 🎩
Storybook
Prod Storybook
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes