Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Button migrations #10161

Closed
10 of 11 tasks
Tracked by #9914
aveline opened this issue Aug 22, 2023 · 0 comments · Fixed by #10263
Closed
10 of 11 tasks
Tracked by #9914

Create Button migrations #10161

aveline opened this issue Aug 22, 2023 · 0 comments · Fixed by #10263
Assignees
@aveline
Labels
#gsd:36573 Polaris API Alignment

Comments

@aveline
Copy link
Contributor

aveline commented Aug 22, 2023 •
edited
Loading

  • rename primary prop to variant="primary"
  • rename plain prop to variant="plain"
  • rename primary plain props to variant="tertiary"
  • rename plain monochrome to variant="monochromePlain"
  • rename destructive prop to tone="critical" variant="primary"
  • rename outline destructive props to tone="critical"
  • remove outline prop
  • remove outline monochrome prop
  • remove monochrome prop
  • handle props in object in buttonFrom function
  • Update migration guide
@aveline aveline mentioned this issue Aug 22, 2023
Closed
@aveline aveline self-assigned this Aug 22, 2023
@aveline aveline added #gsd:36573 Polaris API Alignment and removed untriaged labels Aug 22, 2023
This was referenced Aug 28, 2023
Merged
Merged
aveline added a commit that referenced this issue Sep 6, 2023
@aveline @laurkim @aaronccasanova
Migration update button component (#10263)
67699cb 
### WHY are these changes introduced?

Fixes #10161

### WHAT is this pull request doing?

Migration updates `920` files in `web`
Adds comments to `1650` files to be updated manually

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
aveline added a commit that referenced this issue Sep 6, 2023
@aveline
Add Button migration instructions (#10295)
37670dd 
### WHY are these changes introduced?

Part of #10161

### WHAT is this pull request doing?

Adds instructions to run the `Button` migration
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@aveline @sophschneider
Add Button migration instructions (#10295)
adfac4c 
### WHY are these changes introduced?

Part of #10161

### WHAT is this pull request doing?

Adds instructions to run the `Button` migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aveline aveline

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migration update button component Shopify/polaris
1 participant
@aveline