[CI] Remove pre se23 CI checks (CI and a11y/vrt) and remove experimental name from new checks #10191
Assignees
Comments
This was referenced Aug 25, 2023
laurkim
pushed a commit
that referenced
this issue
Aug 28, 2023
### WHY are these changes introduced? Part of #10191 ### WHAT is this pull request doing? - Force test providers to `polarisSummerEditions2023: true`, this is temporary until we clean up the AppProvider - Delete `.github/workflows/ci.yml` - Rename `.github/workflows/ci-experimental.yml` to `.github/workflows/ci.yml` - Consolidate any tests that use the flag ### Tophat - Make sure there isn't an experimental CI check anymore and that CI passes
laurkim
pushed a commit
that referenced
this issue
Aug 28, 2023
### WHY are these changes introduced? Part of #10191 <img width="1276" alt="Screenshot 2023-08-25 at 1 28 07 PM" src="https://github.com/Shopify/polaris/assets/20652326/9e245dd7-ebab-4225-92c7-4438f2f986e2"> ### WHAT is this pull request doing? - Delete`.github/workflows/ci-a11y-vrt.yml` - Rename `.github/workflows/ci-a11y-vrt-experimental.yml` to `.github/workflows/ci-a11y-vrt.yml` - Removes feature toggles from storybook > Note: I kept the panel and features object so that we can easily add them back in the future ### Tophat - Make sure storybook on the PR is with the feature flag on - Make sure the toggles are not there anymore - Make sure there isn't an experimental Accessibility and visual regression check anymore and that CI passes
sophschneider
added a commit
that referenced
this issue
Sep 19, 2023
### WHY are these changes introduced? Part of #10191 ### WHAT is this pull request doing? - Force test providers to `polarisSummerEditions2023: true`, this is temporary until we clean up the AppProvider - Delete `.github/workflows/ci.yml` - Rename `.github/workflows/ci-experimental.yml` to `.github/workflows/ci.yml` - Consolidate any tests that use the flag ### Tophat - Make sure there isn't an experimental CI check anymore and that CI passes
sophschneider
added a commit
that referenced
this issue
Sep 19, 2023
### WHY are these changes introduced? Part of #10191 <img width="1276" alt="Screenshot 2023-08-25 at 1 28 07 PM" src="https://github.com/Shopify/polaris/assets/20652326/9e245dd7-ebab-4225-92c7-4438f2f986e2"> ### WHAT is this pull request doing? - Delete`.github/workflows/ci-a11y-vrt.yml` - Rename `.github/workflows/ci-a11y-vrt-experimental.yml` to `.github/workflows/ci-a11y-vrt.yml` - Removes feature toggles from storybook > Note: I kept the panel and features object so that we can easily add them back in the future ### Tophat - Make sure storybook on the PR is with the feature flag on - Make sure the toggles are not there anymore - Make sure there isn't an experimental Accessibility and visual regression check anymore and that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tasks
The text was updated successfully, but these errors were encountered: