Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionList, OptionList, Listbox color updates #10371

Closed
Tracked by #10351
sarahill opened this issue Sep 7, 2023 · 0 comments
Closed
Tracked by #10351

ActionList, OptionList, Listbox color updates #10371

sarahill opened this issue Sep 7, 2023 · 0 comments
Assignees
@aveline

Comments

@sarahill
Copy link
Contributor

sarahill commented Sep 7, 2023 •
edited
Loading

Specific color updates for ActionList, OptionList, Listbox

Destructive action:

image
Old token New token
icon-critical text-critical

Interaction states:

image

With the introduction of more selected token colors, we want to update polaris components to get the correct application of these tokens.

State Old token New token
hover bg-subdued-hover surface-secondary-hover
active/press bg-strong-active surface-secondary-active
selected bg-subdued-active surface-secondary-selected
selected icon-primary icon-active
@sarahill sarahill mentioned this issue Sep 7, 2023
Closed
@sarahill sarahill removed the untriaged label Sep 7, 2023
@aveline aveline self-assigned this Sep 27, 2023
@aveline aveline mentioned this issue Sep 27, 2023
Merged
aveline added a commit that referenced this issue Sep 28, 2023
@aveline
ActionList OptionList Listbox color updates (#10732)
52d98fd 
### WHY are these changes introduced?

Fixes #10371

### WHAT is this pull request doing?

Updates color values for selected, hover and active states for
`ActionList`, `OptionList` and `Listbox`

### How to 🎩

- Verify changes in Storybook
@aveline aveline closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aveline aveline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aveline @sarahill