Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Button examples with new variants #10543

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update Button examples with new variants #10543

merged 2 commits into from
Sep 20, 2023

Conversation

aveline
Copy link
Contributor

@aveline aveline commented Sep 18, 2023

WHY are these changes introduced?

Fixes #10165

WHAT is this pull request doing?

Removes Button examples for plain monochrome and destructive and adds examples for tertiary and primary critical.

@aveline aveline marked this pull request as ready for review September 18, 2023 21:00
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@aveline aveline merged commit b3c83f9 into next Sep 20, 2023
7 checks passed
@aveline aveline deleted the button-docs branch September 20, 2023 15:31
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
### WHY are these changes introduced?

Fixes Shopify#10165

### WHAT is this pull request doing?

Removes `Button` examples for `plain monochrome` and `destructive` and
adds examples for `tertiary` and `primary critical`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants