[Page] Consolidate se23 styles and logic #10187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
commented
Aug 23, 2023
Comment on lines
-18
to
-19
| /** Displays a divider between the page header and the page content */ | ||
| divider?: boolean; |
There was a problem hiding this comment.
Removed this prop as the styles were modified with uplift in a previous PR and the class is just overriding pre-uplift spacing back to 0.
There was a problem hiding this comment.
do you know if we are tracking prop deprecations for v12 anywhere?
There was a problem hiding this comment.
Added divider prop removal to tasklist here 👍
laurkim
commented
Aug 23, 2023
| &:hover, | ||
| &:active, | ||
| &:focus { | ||
| border: var(--p-border-width-1) solid var(--p-color-border-strong) !important; |
There was a problem hiding this comment.
Removed this due to specificity issues. Verified that without this, styles for interactive states look as expected.
laurkim
commented
Aug 23, 2023
Comment on lines
-63
to
-65
| - fileName: page-with-divider.tsx | ||
| title: With divider | ||
| description: Use when the page needs visual separation between the page header and the content. |
There was a problem hiding this comment.
@yurm04 I had to remove this example to resolve build issues with the removed prop
sophschneider
approved these changes
Aug 23, 2023
Closed
laurkim
added a commit
that referenced
this pull request
Aug 25, 2023
### WHY are these changes introduced? Resolves #10035. Updates existing `tall-chickens-repeat` changeset with all the component consolidation work (included any in progress/ready for review/up next/backlog PRs as well). Adds changesets for [OptionList](#10177) `optionRole` and [Page](#10187) `divider` prop removal.
sam-b-rose
added a commit
that referenced
this pull request
Aug 25, 2023
* next: (87 commits) [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant` (#9997) [LegacyTabs] Consolidate se23 styles and logic (#10231) [v12] Update changesets (#10232) [LegacyFilters] Consolidate se23 styles and logic (#10217) [Banner] Change status prop to tone (#10206) Replace icon highlight color in box stories (#10226) [TopBar] Consolidate se23 styles and logic (#10221) [Filters] consolidate se23 logic and styles (#10178) [Icon] Update props (#10220) [ButtonGroup] Update variant plain prop name (#10222) [Button] Remove connectedDisclosure (#10182) [LegacyCard] Consolidate se23 styles and logic (#10207) [Navigation] Consolidate se23 logic and styles (#10213) [Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196) [OptionList] consolidate se23 styles and logic (#10177) [Page] Consolidate se23 styles and logic (#10187) [DataTable] Consolidate conditional logic (#10169) [Thumbnail] Consolidate conditional logic (#10171) [ResourceItem] Consolidate conditional logic (#10172) [FullscreenBar] Consolidate conditional logic (#10173) ...
sam-b-rose
added a commit
that referenced
this pull request
Aug 25, 2023
* next: (87 commits) [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant` (#9997) [LegacyTabs] Consolidate se23 styles and logic (#10231) [v12] Update changesets (#10232) [LegacyFilters] Consolidate se23 styles and logic (#10217) [Banner] Change status prop to tone (#10206) Replace icon highlight color in box stories (#10226) [TopBar] Consolidate se23 styles and logic (#10221) [Filters] consolidate se23 logic and styles (#10178) [Icon] Update props (#10220) [ButtonGroup] Update variant plain prop name (#10222) [Button] Remove connectedDisclosure (#10182) [LegacyCard] Consolidate se23 styles and logic (#10207) [Navigation] Consolidate se23 logic and styles (#10213) [Frame][ContextualSaveBar] Consolidate se23 styles and logic (#10196) [OptionList] consolidate se23 styles and logic (#10177) [Page] Consolidate se23 styles and logic (#10187) [DataTable] Consolidate conditional logic (#10169) [Thumbnail] Consolidate conditional logic (#10171) [ResourceItem] Consolidate conditional logic (#10172) [FullscreenBar] Consolidate conditional logic (#10173) ...
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
Resolves #9954. Consolidates se23 beta styles and logic for `Page`. Removes `divider` prop as the styles were modified to reset pre-uplift styles in an earlier [PR](#9537). [Storybook](https://5d559397bae39100201eedc1-rojuobnovi.chromatic.com/?path=/story/all-components-page--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Resolves #10035. Updates existing `tall-chickens-repeat` changeset with all the component consolidation work (included any in progress/ready for review/up next/backlog PRs as well). Adds changesets for [OptionList](#10177) `optionRole` and [Page](#10187) `divider` prop removal.
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#9954. ### WHAT is this pull request doing? Consolidates se23 beta styles and logic for `Page`. Removes `divider` prop as the styles were modified to reset pre-uplift styles in an earlier [PR](Shopify#9537). ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-rojuobnovi.chromatic.com/?path=/story/all-components-page--default) [Prod Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-page--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #9954, #10202.
WHAT is this pull request doing?
Consolidates se23 beta styles and logic for
Page.Removes
dividerprop as the styles were modified to reset pre-uplift styles in an earlier PR.How to 🎩
Storybook
Prod Storybook
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes