[SkeletonThumbnail][SkeletonPage] Consolidate se23 conditional logic #10143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
added a commit
that referenced
this pull request
Sep 19, 2023
…10143) ### WHY are these changes introduced? Fixes #9966 Fixes #9967 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for `SkeletonThumbnail` Component * Consolidate se23 logic and styles for `SkeletonPage` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production skeleton page](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonpage--with-dynamic-content&globals=polarisSummerEditions2023:true) [This PR skeleton page](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonpage--with-dynamic-content) [Production skeleton thumbnail](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonthumbnail--all&globals=polarisSummerEditions2023:true) [This PR skeleton thumbnail](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonthumbnail--all)
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…hopify#10143) ### WHY are these changes introduced? Fixes Shopify#9966 Fixes Shopify#9967 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for `SkeletonThumbnail` Component * Consolidate se23 logic and styles for `SkeletonPage` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production skeleton page](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonpage--with-dynamic-content&globals=polarisSummerEditions2023:true) [This PR skeleton page](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonpage--with-dynamic-content) [Production skeleton thumbnail](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonthumbnail--all&globals=polarisSummerEditions2023:true) [This PR skeleton thumbnail](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonthumbnail--all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #9966
Fixes #9967
WHAT is this pull request doing?
SkeletonThumbnailComponentSkeletonPageComponentHow to 🎩
Production skeleton page
This PR skeleton page
Production skeleton thumbnail
This PR skeleton thumbnail