[Styles] Consolidate remaining se23 scss logic #10254
Assignees
Comments
This was referenced Aug 28, 2023
laurkim
added a commit
that referenced
this issue
Aug 29, 2023
### WHY are these changes introduced? Resolves #10254. ### WHAT is this pull request doing? Clean up .scss files that were still referencing se23 in stylelint comments. Clean up old variables in ResourceItem that were created for se23 but we can just use the values directly now. Consolidate se23 logic for **new ActionList subcomponent SearchField** (didn't exist when we previously consolidated ActionList): - Clean up se23 logic in SearchField.scss - Add new story to show ActionList with search field - Fix focus-ring issue on SearchField ### How to 🎩 [New ActionList with Search story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-actionlist--with-search) [ResourceItem story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-resourceitem--default) [ResourceItem story prod](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
sophschneider
pushed a commit
that referenced
this issue
Sep 19, 2023
Resolves #10254. Clean up .scss files that were still referencing se23 in stylelint comments. Clean up old variables in ResourceItem that were created for se23 but we can just use the values directly now. Consolidate se23 logic for **new ActionList subcomponent SearchField** (didn't exist when we previously consolidated ActionList): - Clean up se23 logic in SearchField.scss - Add new story to show ActionList with search field - Fix focus-ring issue on SearchField [New ActionList with Search story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-actionlist--with-search) [ResourceItem story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-resourceitem--default) [ResourceItem story prod](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this issue
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#10254. ### WHAT is this pull request doing? Clean up .scss files that were still referencing se23 in stylelint comments. Clean up old variables in ResourceItem that were created for se23 but we can just use the values directly now. Consolidate se23 logic for **new ActionList subcomponent SearchField** (didn't exist when we previously consolidated ActionList): - Clean up se23 logic in SearchField.scss - Add new story to show ActionList with search field - Fix focus-ring issue on SearchField ### How to 🎩 [New ActionList with Search story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-actionlist--with-search) [ResourceItem story](https://5d559397bae39100201eedc1-okwxqlsbwm.chromatic.com/?path=/story/all-components-resourceitem--default) [ResourceItem story prod](https://storybook.polaris.shopify.com/?path=/story/all-components-resourceitem--default&globals=polarisSummerEditions2023:true) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Excluding
IndexTable.scsswhich has an existing issue andAppProvider.scss(issue), there are some scss files that are still using these23flag that need to be cleaned up.Tasks
The text was updated successfully, but these errors were encountered: