-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SkeletonThumbnail] Consolidate se23 logic and styles #9967
Comments
sophschneider
added a commit
that referenced
this issue
Aug 25, 2023
…10143) ### WHY are these changes introduced? Fixes #9966 Fixes #9967 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for `SkeletonThumbnail` Component * Consolidate se23 logic and styles for `SkeletonPage` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production skeleton page](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonpage--with-dynamic-content&globals=polarisSummerEditions2023:true) [This PR skeleton page](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonpage--with-dynamic-content) [Production skeleton thumbnail](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonthumbnail--all&globals=polarisSummerEditions2023:true) [This PR skeleton thumbnail](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonthumbnail--all)
sophschneider
added a commit
that referenced
this issue
Sep 19, 2023
…10143) ### WHY are these changes introduced? Fixes #9966 Fixes #9967 ### WHAT is this pull request doing? * Consolidate se23 logic and styles for `SkeletonThumbnail` Component * Consolidate se23 logic and styles for `SkeletonPage` Component ### How to 🎩 * Compare production and this PR's chromatic storybook to make sure styles are the same [Production skeleton page](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonpage--with-dynamic-content&globals=polarisSummerEditions2023:true) [This PR skeleton page](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonpage--with-dynamic-content) [Production skeleton thumbnail](https://storybook.polaris.shopify.com/?path=/story/all-components-skeletonthumbnail--all&globals=polarisSummerEditions2023:true) [This PR skeleton thumbnail](https://5d559397bae39100201eedc1-zxhtnbvnuu.chromatic.com/?path=/story/all-components-skeletonthumbnail--all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: