Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update semantic border-radius token layer #10421

Closed
2 tasks done
Tracked by #10301
lgriffee opened this issue Sep 12, 2023 · 0 comments · Fixed by #10669
Closed
2 tasks done
Tracked by #10301

Update semantic border-radius token layer #10421

lgriffee opened this issue Sep 12, 2023 · 0 comments · Fixed by #10669
Assignees
@lgriffee

Comments

@lgriffee
Copy link
Member

lgriffee commented Sep 12, 2023 •
edited
Loading

Tasks
Beta Give feedback
@lgriffee lgriffee mentioned this issue Sep 12, 2023
Closed
@lgriffee lgriffee self-assigned this Sep 12, 2023
@lgriffee lgriffee mentioned this issue Sep 25, 2023
Merged
@lgriffee lgriffee linked a pull request Sep 25, 2023 that will close this issue
Update semantic border-radius token layer #10669
Merged
lgriffee added a commit that referenced this issue Sep 28, 2023
@lgriffee
Update semantic border-radius token layer (#10669)
794d1f5 
### WHY are these changes introduced?

Fixes #10421


### WHAT is this pull request doing?

- Added `border-radius-full` to a new `BorderRadiusAlias` type
- Created `BorderRadiusAliasOrScale` combining `BorderRadiusScale` and
`BorderRadiusAlias`
- Updated component token prop types to `BorderWidthAliasOrScale`
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@lgriffee
Update semantic border-radius token layer (Shopify#10669)
f6d22f6 
### WHY are these changes introduced?

Fixes Shopify#10421


### WHAT is this pull request doing?

- Added `border-radius-full` to a new `BorderRadiusAlias` type
- Created `BorderRadiusAliasOrScale` combining `BorderRadiusScale` and
`BorderRadiusAlias`
- Updated component token prop types to `BorderWidthAliasOrScale`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgriffee lgriffee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update semantic border-radius token layer Shopify/polaris
1 participant
@lgriffee