Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button - Replace variant booleans with a new prop #10047

Closed
1 task done
Tracked by #9914
kyledurand opened this issue Aug 14, 2023 · 0 comments
Closed
1 task done
Tracked by #9914

Button - Replace variant booleans with a new prop #10047

kyledurand opened this issue Aug 14, 2023 · 0 comments
Assignees
@aveline
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Contributor

kyledurand commented Aug 14, 2023 •
edited by aveline
Loading

  • Update Button component props
@kyledurand kyledurand mentioned this issue Aug 14, 2023
Closed
@aveline aveline self-assigned this Aug 14, 2023
@aveline aveline added the #gsd:36573 Polaris API Alignment label Aug 14, 2023
@aveline aveline changed the title Button - Replace booleans with new props Button - Replace variant booleans with a new prop Aug 15, 2023
@aveline aveline mentioned this issue Aug 16, 2023
Merged
5 tasks
aveline added a commit that referenced this issue Aug 22, 2023
@aveline
[Button] Replace booleans with new props (#10090)
4caed28 
### WHY are these changes introduced?

Fixes #10047

### WHAT is this pull request doing?

- Adds `variant` and `tone` props
- Removes `primary`, `outline`, `plain`, `monochrome`, and
`primarySuccess` booleans
- Updates props on usages of `Button`
- Renames `primaryPlain` variant to `tertiary`
@aveline aveline closed this as completed Aug 22, 2023
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@aveline @sophschneider
[Button] Replace booleans with new props (#10090)
9e0b0fc 
Fixes #10047

- Adds `variant` and `tone` props
- Removes `primary`, `outline`, `plain`, `monochrome`, and
`primarySuccess` booleans
- Updates props on usages of `Button`
- Renames `primaryPlain` variant to `tertiary`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aveline aveline

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aveline @kyledurand