Text - headingXs to headingSm and heading4xl to heading3xl
#10770
Assignees
Labels
#gsd:36573
Polaris API Alignment
Comments
This was referenced Sep 28, 2023
Closed
laurkim
added a commit
that referenced
this issue
Sep 28, 2023
### WHY are these changes introduced? Resolves #10770. With the recent changes to `Text` to use the composite text tokens, we are removing the `headingXs` and `heading4xl` variants. ### Mapping | Old `variant` Prop Value | Replacement Value | | ------------------------ | ----------------- | | `headingXs` | `headingSm` | | `heading4xl` | `heading3xl` | ### WHAT is this pull request doing? Removes `headingXs` and `heading4xl` and manually migrates usage. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this issue
Apr 22, 2024
…#10771) ### WHY are these changes introduced? Resolves Shopify#10770. With the recent changes to `Text` to use the composite text tokens, we are removing the `headingXs` and `heading4xl` variants. ### Mapping | Old `variant` Prop Value | Replacement Value | | ------------------------ | ----------------- | | `headingXs` | `headingSm` | | `heading4xl` | `heading3xl` | ### WHAT is this pull request doing? Removes `headingXs` and `heading4xl` and manually migrates usage. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the
fonttoken updates, the styles forheadingXsis redundant withheadingSm. The same applies forheading4xlwhere the styles are redundant withheading3xl.These variant types and styles should be removed and all usage of
headingXsandheading4xlmapped to their replacement values.The text was updated successfully, but these errors were encountered: