Update button migration examples #10903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
### WHY are these changes introduced? Adds an example of what's to be expected when migrating a `<Button primary plain monochrome />` element. I don't think we don't want to default to a new style, like `plain monochrome` which might be the safest, because consumers may want to opt for the `plain` variant. So we just insert a comment and defer to the team / section responsible
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
### WHY are these changes introduced? Adds an example of what's to be expected when migrating a `<Button primary plain monochrome />` element. I don't think we don't want to default to a new style, like `plain monochrome` which might be the safest, because consumers may want to opt for the `plain` variant. So we just insert a comment and defer to the team / section responsible
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Adds an example of what's to be expected when migrating a `<Button primary plain monochrome />` element. I don't think we don't want to default to a new style, like `plain monochrome` which might be the safest, because consumers may want to opt for the `plain` variant. So we just insert a comment and defer to the team / section responsible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adds an example of what's to be expected when migrating a
<Button primary plain monochrome />element. I don't think we don't want to default to a new style, likeplain monochromewhich might be the safest, because consumers may want to opt for theplainvariant.So we just insert a comment and defer to the team / section responsible