Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make breaking changes to font-size token values #10476

Closed
Tracked by #10439
lgriffee opened this issue Sep 14, 2023 · 0 comments · Fixed by #10673
Closed
Tracked by #10439

Make breaking changes to font-size token values #10476

lgriffee opened this issue Sep 14, 2023 · 0 comments · Fixed by #10673
Assignees

Comments

@lgriffee
Copy link
Member

lgriffee commented Sep 14, 2023

On the next branch update the follow token values:

New Token Value Value (in px)
--p-font-size-300 size[300] 12px
--p-font-size-400 size[400] 16px
--p-font-size-500 size[500] 20px
--p-font-size-600 size[600] 24px
@lgriffee lgriffee self-assigned this Sep 14, 2023
@lgriffee lgriffee linked a pull request Sep 25, 2023 that will close this issue
lgriffee added a commit that referenced this issue Sep 27, 2023
### WHY are these changes introduced?

Fixes #10476
Fixes #10516

### WHAT is this pull request doing?

This pull request is making breaking change updates to font token
values:

| Token          |  New Value        | 
| ------------------------- | ------------------------ | 
| `--p-font-size-300` | `size[300]`  | 
| `--p-font-size-400` | `size[400]`  | 
| `--p-font-size-500` | `size[500]`  | 
| `--p-font-size-600` | `size[600]`  | 
| `--p-font-weight-regular` | `450` | 
| `--p-font-weight-medium` | `550` | 
| `--p-font-weight-semibold` | `650` |
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
### WHY are these changes introduced?

Fixes Shopify#10476
Fixes Shopify#10516

### WHAT is this pull request doing?

This pull request is making breaking change updates to font token
values:

| Token          |  New Value        | 
| ------------------------- | ------------------------ | 
| `--p-font-size-300` | `size[300]`  | 
| `--p-font-size-400` | `size[400]`  | 
| `--p-font-size-500` | `size[500]`  | 
| `--p-font-size-600` | `size[600]`  | 
| `--p-font-weight-regular` | `450` | 
| `--p-font-weight-medium` | `550` | 
| `--p-font-weight-semibold` | `650` |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant