[CI][Tests] Consolidate se23 tests #10243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
commented
Aug 25, 2023
| @@ -67,7 +67,7 @@ export function PolarisTestProvider({ | |||
|
|
|||
| const featuresConfig = useMemo( | |||
| () => ({ | |||
| polarisSummerEditions2023: false, | |||
| polarisSummerEditions2023: true, | |||
There was a problem hiding this comment.
Temp, we should remove this property in #10189!
| @@ -27,7 +27,7 @@ export const mountWithApp = createMount< | |||
| <PolarisTestProvider | |||
| i18n={translations} | |||
| features={{ | |||
| polarisSummerEditions2023: process.env.SE23 === 'on', | |||
| polarisSummerEditions2023: true, | |||
There was a problem hiding this comment.
Temp, we should remove this property in #10189!
sam-b-rose
approved these changes
Aug 28, 2023
sophschneider
added a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Part of #10191 ### WHAT is this pull request doing? - Force test providers to `polarisSummerEditions2023: true`, this is temporary until we clean up the AppProvider - Delete `.github/workflows/ci.yml` - Rename `.github/workflows/ci-experimental.yml` to `.github/workflows/ci.yml` - Consolidate any tests that use the flag ### Tophat - Make sure there isn't an experimental CI check anymore and that CI passes
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Part of Shopify#10191 ### WHAT is this pull request doing? - Force test providers to `polarisSummerEditions2023: true`, this is temporary until we clean up the AppProvider - Delete `.github/workflows/ci.yml` - Rename `.github/workflows/ci-experimental.yml` to `.github/workflows/ci.yml` - Consolidate any tests that use the flag ### Tophat - Make sure there isn't an experimental CI check anymore and that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of #10191
WHAT is this pull request doing?
polarisSummerEditions2023: true, this is temporary until we clean up the AppProvider.github/workflows/ci.yml.github/workflows/ci-experimental.ymlto.github/workflows/ci.ymlTophat