Update Index table colors #10755
Merged
Update Index table colors #10755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahill
approved these changes
Sep 28, 2023
|
@sarahill I just noticed there are some visual diffs in Chromatic for the Navigation component because of the update to the token. Can you take a look and confirm whether Navigation is rendering as expected? It doesn't look right to me and I wonder if we need to update that selected background color. |
|
Nav color will be fixed in this PR #10358 |
sophschneider
approved these changes
Sep 29, 2023
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#10362 ### WHAT is this pull request doing? This updates some Index table row colors as well as the color value for the `color-bg-surface-selected` token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #10362
WHAT is this pull request doing?
This updates some Index table row colors as well as the color value for the
color-bg-surface-selectedtoken