-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/content/error-messages
multiple Dont
cards should not stack
#10624
Labels
Priority: Medium
Non-blocking regression, noticable inconcistency, or important feature
Comments
yurm04
added
#gsd:36550
Priority: Medium
Non-blocking regression, noticable inconcistency, or important feature
labels
Sep 21, 2023
5 tasks
yurm04
pushed a commit
that referenced
this issue
Sep 25, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10624 ### WHAT is this pull request doing? * Antipattern `dont` components now render in a 2x2 Grid * Adjsuted content on the anti-pattern section such that don't text content matches the corresponding img. Before: ![Screenshot 2023-09-25 at 11 00 41 am](https://github.com/Shopify/polaris/assets/12119389/aad8a616-34a0-43b2-8082-2712368635ae) After: ![Screenshot 2023-09-25 at 11 00 48 am](https://github.com/Shopify/polaris/assets/12119389/641df9d5-6aa7-4827-8167-19bb43cd2366) ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this issue
Apr 22, 2024
…y#10651) <!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes Shopify#10624 ### WHAT is this pull request doing? * Antipattern `dont` components now render in a 2x2 Grid * Adjsuted content on the anti-pattern section such that don't text content matches the corresponding img. Before: ![Screenshot 2023-09-25 at 11 00 41 am](https://github.com/Shopify/polaris/assets/12119389/aad8a616-34a0-43b2-8082-2712368635ae) After: ![Screenshot 2023-09-25 at 11 00 48 am](https://github.com/Shopify/polaris/assets/12119389/641df9d5-6aa7-4827-8167-19bb43cd2366) ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you have a bunch of Do OR Dont cards (not the pairs) they should be using the individual
<Dont>
component in a layout component instead of the<DoDont>
Change these Donts to use the new
<Dont>
component in a gridScreen.Recording.2023-09-21.at.2.31.58.PM.mov
The text was updated successfully, but these errors were encountered: