Release 1.9.0 #1933

katspaugh · 2023-05-03T12:50:14Z

Features

Approval editor – warn about token approvals and allow editing the amount (Approval editor #1763)
Import and export – save your entire Safe Wallet data as JSON and import in another browser (feat: import/export data #1816)
Decoded transaction info – show native transfers and multisend sub-transactions (Feat: decode native transfers + show Multisend in the tx info block #1899)
Relaying – the option to execute transactions and Safe creations with the connected wallet (feat: execution method selector in transaction modal #1919 + feat: execution method for creation + batches #1924)
Cookie banner – an improved design with more transparency about our cookies (Fix: a better cookie banner layout #1849)

Bug fixes

fix: wrong message in safe creation relay (fix: wrong message in safe creation relay #1922)
fix: improve relay error (fix: improve relay error #1921)
Fix: isValidMasterCopy params
fix: Multiple transactions when creating a safe (fix: Multiple transactions when creating a safe #1883)
fix: Over-initialization of the safe core sdk (fix: Over-initialization of the safe core sdk #1843)
fix: fetch all balances if chain does not support default tokens (fix: fetch all balances if chain does not support default tokens #1928)
fix: don't scroll wrap in transaction list (fix: don't scroll wrap in transaction list #1915)
Fix: useTxActions should accept origin (Fix: useTxActions should accept origin #1926)
fix: Dashboard layout with relaying widget (fix: Dashboard layout with relaying widget #1911)
fix: replaced safe_token with new icon (fix: replaced safe_token with new icon #1917)
fix: Add fallback for empty data in ApprovalEditor (fix: Add fallback for empty data in ApprovalEditor #1892)
Update safe-deployments to latest version to support Neon contracts (Update safe-deployments to latest version to support Neon contracts #1877)
fix: brand alignment inconsistencies (fix: brand alignment inconsistencies #1910)
fix: remove slash from end of CLA links (fix: remove slash from end of CLA links #1907)
fix: tweak wording of Safe Account/{Wallet} (fix: tweak wording of Safe Account/{Wallet} #1901)
fix: balance pagination test (fix: balance pagination test #1895)
fix: allow using the injected wallet on mobile (fix: allow using the injected wallet on mobile #1880)
fix: refresh remaining relays after relay (fix: refresh remaining relays after relay #1885)
fix: rename Safe Apps to Safe{Apps} (fix: rename Safe Apps to Safe{Apps} #1888)
fix: Unhandled error for pending txs in queue (fix: Unhandled error for pending txs in queue #1862)
fix: check simulation call trace for reversion (fix: check simulation call trace for reversion #1861)
fix: Unhandled exception in the Copy button Unhandled exception in the Copy button #1782 (fix: Unhandled exception in the Copy button #1782 #1851)
Fix: a better cookie banner layout (Fix: a better cookie banner layout #1849)
Fix: filter pending txs by safe address (Fix: filter pending txs by safe address #1836)
fix: Dashboard widgets do not align correctly (fix: Dashboard widgets do not align correctly #1867)
Fix: redirect old tx id URLs (Fix: redirect old tx id URLs #1870)
fix: create Safe App share URL in useEffect (fix: create Safe App share URL in useEffect #1866)
fix: remove unnecessary dependency (fix: remove unnecessary dependency #1841)
fix: Unhandled exception in useOnboard (fix: Unhandled exception in useOnboard #1868)
fix: Spending limits: Table header is displayed when no records Spending limits: Table header is displayed when no records #1703 (fix: Spending limits: Table header is displayed when no records #1703 #1852)
fix: Navigation tabs break the layout on mobile viewports (fix: Navigation tabs break the layout on mobile viewports #1865)
fix: Track most searched safe apps (fix: Track most searched safe apps #1827)
fix(safe-apps): Add new Safe apps domain (fix(safe-apps): Add new Safe apps domain #1765)
Fix: track QR button in address inputs (Fix: track QR button in address inputs #1935)

Other improvements

Chore: fix e2e tests (Chore: fix e2e tests #1929)
chore(deps-dev): bump @openzeppelin/contracts from 4.8.2 to 4.8.3 (chore(deps-dev): bump @openzeppelin/contracts from 4.8.2 to 4.8.3 #1873)
app store button - replaced with next image (app store button - replaced with next image #1906)
NFTs page: better select-all UI (NFTs page: better select-all UI #1904)
Chore: repace http-server with serve (Chore: repace http-server with serve #1905)
refactor: SignOrExecute elements (refactor: SignOrExecute elements #1842)
[e2e] Collapse expand all actions ([e2e] Collapse expand all actions #1801)
refactor: remove getWeb3 (refactor: remove getWeb3 #1837)

* refactor: remove `getWeb3` * refactor: remove unnecessary `web3` instance * fix: update relayer

* fix: Track most searched safe apps * fix: Increase search debounce to 2s

New component in transaction modals if approval txs were found. Offers a way for the user to adjust the approval amount(s) before submitting the transaction.

* fix: Align header actions on mobile * fix: Connect wallet word wrap on mobile * fix: Remove sticky from tx filter form on mobile * fix: Address feedback

…#1852)

* fix: Unhandled exception in useOnboard * fix: added logger message and added test case for error in getAddress * Update src/hooks/wallets/useOnboard.test.ts Co-authored-by: Aaron Cook <aaron@safe.global> --------- Co-authored-by: Aaron Cook <aaron@safe.global>

* fix: Dashboard widgets do not align correctly * fix: added test case for error in getAddress function and added logger message * Update ErrorCodes.ts * Update ErrorCodes.ts * Update ErrorCodes.ts * Update ErrorCodes.ts * Update ErrorCodes.ts * Update ErrorCodes.ts * fix: Updated FeaturedApps * Update useOnboard.test.ts * added new lines * Delete useOnboard.test.ts * Delete ErrorCodes.ts * Delete useOnboard.ts * fix: added flex direction instead of min-width

* Fix: filter pending txs by safe address * Fix tests * Add pending slice tests * fix: track pending processed txs with correct safe address --------- Co-authored-by: schmanu <manu@safe.global>

* Fix: a better cookie banner layout * e2e tests * fix: Move cookie banner to the corner * Restore necessary checkbox + fix styles * Fix tests * Left -> right --------- Co-authored-by: Usame Algan <usame@safe.global>

* fix: Unhandled exception in the Copy button #1782 * Capitalize tooltip --------- Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>

* feat: buttons to expand/collapse all actions * fix: set state in `useEffect` * fix: improve clarity of code * fix: add test for expand collapse * fix: Lint issues --------- Co-authored-by: iamacook <aaron@safe.global> Co-authored-by: Usame Algan <usame@safe.global>

* fix: check simulation call trace for reversion * fix: adjust error message for call trace * fix: error message priority * fix: generalise error

* fix: align Safe brand map * fix: tests * fix: add missing renames * Update src/components/common/CookieBanner/index.tsx Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com> * fix: use "Account" in creation + code style * fix: smoke * fix: italicise project * fix: rename "My Safes" * fix: change logo --------- Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>

* fix: align Safe brand map * fix: tests * fix: add missing renames * Update src/components/common/CookieBanner/index.tsx Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com> * fix: use "Account" in creation + code style * fix: smoke * fix: italicise project * fix: rename "My Safes" * fix: rename Safe Apps to Safe{Apps} * fix: tests * fix: tests --------- Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>

* fix: refresh remaining relays after relay * fix: tests * fix: add tests

* fix: no autoconnect when injected is present * fix: code style

* Add goerli safe for "pagination should work" test and update it according to the test data * fix: change 26 tokens to 27

* Refactor: extract SignOrExecute logic into hooks (#1830) * Refactor: extract SignOrExecute logic into hooks * isExecutionLoop * Fix isExecutionLoop * Add hook tests * PR comments * Create asserts * Use isValidMasterCopy * Track relayed executions * Tests * Refactor: move getRemainingRelays to a service (#1839) * Refactor: move getRemainingRelays to a service * Rename relaying service and constants * Rm component library draft * refactor: address relaying review comments (#1848) * refactor: address relaying review comments * fix: revert type error expectation * fix: add help article link * fix: spelling mistake * Relaying: propose signed tx * Fix tests and add more cases * Fix test --------- Co-authored-by: iamacook <aaron@safe.global>

* fix: tweak wording of Safe Account/{Wallet} * fix: E2E tests

* NFTs page: better select-all UI * Controlled checkbox + textAlign

Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>

* feat: execution method for creation + batches * fix: extract helper, update comment + grammar * fix: code structure * fix: variable * fix: add sponsor logo for Goerli * fix: smoke test --------- Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>

github-actions · 2023-05-03T12:50:28Z

Branch preview

✅ Deploy successful!

https://release_1_9_0--webcore.review-web-core.5afe.dev

github-actions · 2023-05-03T12:52:03Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica · 2023-05-04T10:03:12Z

is the ticket #1921 merged properly? I don't see its effects in the RC

iamacook · 2023-05-04T10:36:17Z

is the ticket #1921 merged properly? I don't see its effects in the RC

Yes, #1921 was a small tweak on the frontend. Here's how it looked prior:

This still needs to be tackled on the backend.

* Fix: track QR button in address inputs * Fix e2e test

francovenica · 2023-05-04T12:28:45Z

For the 1921 I was expecting for the error to say "unprocessable entity", will that be changed in the backend?

iamacook · 2023-05-04T14:23:17Z

For the 1921 I was expecting for the error to say "unprocessable entity", will that be changed in the backend?

Yes, there is an open issue to improve the error responses.

francovenica · 2023-05-04T15:25:58Z

with the revert of the change logo, the old logo is back, but is too smal. A comparison between the RC and current prod build

francovenica · 2023-05-05T02:50:38Z

I'm seeing this error in the console by just standing in the /welcome page
EDIT: This happens after accepting all cookies in the "preferences" modal

https://release_1_9_0--webcore.review-web-core.5afe.dev/welcome

francovenica · 2023-05-05T04:08:32Z

I have an issue where a pending tx keeps disappearing from the queue tab and reappearing constantly.
The tx is a removal of a spending limit and is taking its time to be fully executed. Still I'd expect for the tx to not disappear while is being processed
Tomorrow I'll keep debugging to see if it happens with other types of tx

katspaugh · 2023-05-05T04:51:24Z

@francovenica does it do that on prod too?

katspaugh · 2023-05-05T05:21:58Z

I'm seeing this error in the console by just standing in the /welcome page
EDIT: This happens after accepting all cookies in the "preferences" modal

@francovenica this is from Beamer. Let's ignore it for now, we're in contact with their support.

francovenica · 2023-05-05T13:39:08Z

@katspaugh no, I tried the same tx in prod and the tx doesn't go off and goes back like that. I'll keep trying to see if it happens all the time or not

katspaugh · 2023-05-05T14:31:44Z

In any case please file it as a separate bug report. Please mention there if it's a 1/X Safe or more.

francovenica · 2023-05-05T16:36:24Z

#1956 Here

francovenica · 2023-05-08T01:55:17Z

Besides that last issue I mentioned in the previous comment the RC is fine. Once that is fixed we can deploy

iamacook and others added 30 commits April 5, 2023 15:21

refactor: remove getWeb3 (#1837)

c41d622

* refactor: remove `getWeb3` * refactor: remove unnecessary `web3` instance * fix: update relayer

fix(safe-apps): Add new Safe apps domain (#1765)

87f13e5

fix: Track most searched safe apps (#1827)

51289c4

* fix: Track most searched safe apps * fix: Increase search debounce to 2s

Merge branch 'main' of github.com:5afe/web-core into dev

c8f82af

feat: approval editor (#1763)

71645cc

New component in transaction modals if approval txs were found. Offers a way for the user to adjust the approval amount(s) before submitting the transaction.

fix: Navigation tabs break the layout on mobile viewports (#1865)

4969452

* fix: Align header actions on mobile * fix: Connect wallet word wrap on mobile * fix: Remove sticky from tx filter form on mobile * fix: Address feedback

fix: Spending limits: Table header is displayed when no records #1703 (…

5a8140d

…#1852)

fix: remove unnecessary dependency (#1841)

d60c412

fix: create Safe App share URL in useEffect (#1866)

35fa598

Merge branch 'main' of github.com:safe-global/web-core into dev

4b2fe0e

Fix: filter pending txs by safe address (#1836)

a5b1aed

* Fix: filter pending txs by safe address * Fix tests * Add pending slice tests * fix: track pending processed txs with correct safe address --------- Co-authored-by: schmanu <manu@safe.global>

Fix prettier

d3be0de

Fix: a better cookie banner layout (#1849)

a46e774

* Fix: a better cookie banner layout * e2e tests * fix: Move cookie banner to the corner * Restore necessary checkbox + fix styles * Fix tests * Left -> right --------- Co-authored-by: Usame Algan <usame@safe.global>

fix: Unhandled exception in the Copy button #1782 (#1851)

fb39829

* fix: Unhandled exception in the Copy button #1782 * Capitalize tooltip --------- Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>

fix: check simulation call trace for reversion (#1861)

3f06859

* fix: check simulation call trace for reversion * fix: adjust error message for call trace * fix: error message priority * fix: generalise error

fix: Unhandled error for pending txs in queue (#1862)

a62b968

fix: refresh remaining relays after relay (#1885)

edd8f7d

* fix: refresh remaining relays after relay * fix: tests * fix: add tests

fix: allow using the injected wallet on mobile (#1880)

271e95a

* fix: no autoconnect when injected is present * fix: code style

fix: balance pagination test (#1895)

d1f39c0

* Add goerli safe for "pagination should work" test and update it according to the test data * fix: change 26 tokens to 27

fix: tweak wording of Safe Account/{Wallet} (#1901)

8f5cf7e

* fix: tweak wording of Safe Account/{Wallet} * fix: E2E tests

Chore: repace http-server with serve (#1905)

26b2e13

NFTs page: better select-all UI (#1904)

dfbcf9e

* NFTs page: better select-all UI * Controlled checkbox + textAlign

app store button - replaced with next image (#1906)

86d28dc

Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>

fix: remove slash from end of CLA links (#1907)

1a97d23

iamacook and others added 2 commits May 3, 2023 12:44

v1.9.0

330caaa

katspaugh requested a review from usame-algan May 3, 2023 12:50

katspaugh requested a review from francovenica May 3, 2023 13:23

usame-algan approved these changes May 3, 2023

View reviewed changes

schmanu and others added 3 commits May 4, 2023 12:45

fix: decoding txs without parameters (#1938)

3e59c5c

Fix: track QR button in address inputs (#1935)

8de279a

* Fix: track QR button in address inputs * Fix e2e test

fix: revert rebranding (#1939)

8f84ccd

katspaugh force-pushed the release/1.9.0 branch from f63989c to 8f84ccd Compare May 4, 2023 11:11

fix: remove logo height (#1951)

5e2b78c

francovenica mentioned this pull request May 5, 2023

Pending tx fade out and come back while in pending status #1956

Closed

Fix: don't clear pending queue when polling (#1957)

52bb601

katspaugh merged commit 52bb601 into main May 8, 2023

katspaugh deleted the release/1.9.0 branch May 8, 2023 08:28

github-actions bot locked and limited conversation to collaborators May 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.9.0 #1933

Release 1.9.0 #1933

katspaugh commented May 3, 2023 •

edited

Loading

github-actions bot commented May 3, 2023 •

edited

Loading

github-actions bot commented May 3, 2023 •

edited

Loading

francovenica commented May 4, 2023

iamacook commented May 4, 2023

francovenica commented May 4, 2023

iamacook commented May 4, 2023

francovenica commented May 4, 2023

francovenica commented May 5, 2023 •

edited

Loading

francovenica commented May 5, 2023

katspaugh commented May 5, 2023

katspaugh commented May 5, 2023

francovenica commented May 5, 2023

katspaugh commented May 5, 2023

francovenica commented May 5, 2023

francovenica commented May 8, 2023

Release 1.9.0 #1933

Release 1.9.0 #1933

Conversation

katspaugh commented May 3, 2023 • edited Loading

Features

Bug fixes

Other improvements

github-actions bot commented May 3, 2023 • edited Loading

Branch preview

github-actions bot commented May 3, 2023 • edited Loading

ESLint Summary View Full Report

francovenica commented May 4, 2023

iamacook commented May 4, 2023

francovenica commented May 4, 2023

iamacook commented May 4, 2023

francovenica commented May 4, 2023

francovenica commented May 5, 2023 • edited Loading

francovenica commented May 5, 2023

katspaugh commented May 5, 2023

katspaugh commented May 5, 2023

francovenica commented May 5, 2023

katspaugh commented May 5, 2023

francovenica commented May 5, 2023

francovenica commented May 8, 2023

katspaugh commented May 3, 2023 •

edited

Loading

github-actions bot commented May 3, 2023 •

edited

Loading

github-actions bot commented May 3, 2023 •

edited

Loading

francovenica commented May 5, 2023 •

edited

Loading