app store button - replaced with next image #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
The CLA page links are both redirecting to 404. The one present here and the one present in |
|
Yeah, sorry about that. The link should be https://safe.global/cla |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
3 tasks
iamacook
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Thank you for the contribution, @GermaVinsmoke!
I've tested this working locally, LGTM!
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Safe Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
A tiny part of PR #1389
How this PR fixes it
Replaced
<img>tag with<Image>component bynext/imageHow to test it
Visible on Connect wallet dropdown and in the footer of settings page
Checklist
Note - I think PR #1389 is quite big and can be converted into either a milestone or smaller issues. For example, an issue which will target the images, other issue can target npm modules which can be optimized, and so on.