-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove getWeb3
#1837
refactor: remove getWeb3
#1837
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I have issues with goerli. I don't know if this ticket deals with networks or not but I want to point it out still With the stg CGW I cannot create safes in goerli once the sponsored tx run out and I have to use my own funds, I can create the safe and execute the tx with the tx builder just fine. I didn't have this issues with the GNO chain (I could only test with the prod CGW tho) |
Our 1Balance pool was empty and transactions could not be relayed. If you encounter transactions not relaying, be sure to check the network tab for Gelato requests. We have since topped up the pool and transactions are succeeding. I have managed to create Safes/execute transactions successfully.
There was an issue with the Gnosis Chain RPC yesterday which may have played a role. If the relay succeeded, it leads me to believe that Gelato are likely using a different RPC to us. I checked this myself and was not shown a warning: Could you try the above again today and let me know if you continue to experience issues? |
I've checked Goerli again and now it works. I didn't thought about the balance pool since I was able to execute normal tx (but those are like a 1/10th of what a safe creation cost, so maybe there was just enough for regular tx's 🤷 ) I tried The safe update and I still see the warning that the tx might fail, but I just bumped the gas up in the adv parameters and the warning is gone, so is not a relayer thing. |
We've noticed RPC issues again today. Taking that into consideration, are you ok if we merge this? |
Yes, merge it |
What it solves
Resolves #1799
How this PR fixes it
getWeb3
has been removed and theprovider
is now drilled accordingly.How to test it
Checklist