Refactor: move getRemainingRelays to a service #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
approved these changes
Apr 4, 2023
src/services/tx/sponsoredCall.ts
Outdated
| throw new Error(`${res.status} - ${res.statusText}: ${errorData?.error?.message}`) | ||
| } | ||
|
|
||
| export const getRemainingRelays = async (chainId: string, address: string): Promise<number> => { |
There was a problem hiding this comment.
Nit: now this is here, can we rename this file to relaying.ts or something similar?
|
I just noticed that the tests are also failing. |
katspaugh
commented
Apr 4, 2023
Comment on lines
+65
to
+68
| export const SAFE_RELAY_SERVICE_URL_PRODUCTION = | ||
| process.env.NEXT_PUBLIC_SAFE_RELAY_SERVICE_URL_PRODUCTION || 'https://safe-client-nest.safe.global/v1/relay' | ||
| export const SAFE_RELAY_SERVICE_URL_STAGING = | ||
| process.env.NEXT_PUBLIC_SAFE_RELAY_SERVICE_URL_STAGING || 'https://safe-client-nest.staging.5afe.dev/v1/relay' |
There was a problem hiding this comment.
I'll rename them in the Github secrets after the release.
iamacook
approved these changes
Apr 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Part of #1838.
How this PR fixes it
I've moved the remaining relays call to the service.