fix: Spending limits: Table header is displayed when no records #1703 #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi, @katspaugh do I need to make any changes from my side for the failed checks? |
|
No, it’s all good, they fail because of missing permissions. We’re just waiting for our QA now. |
|
Ok, Thank you for informing. |
usame-algan
approved these changes
Apr 13, 2023
|
Looks good. In this repo I'm not able to execute tx so I can't create a spending limit to see if they table header pops up again. So I'll re check it when merged into dev |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Safe Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This solves the issue where Table header is displayed even when there are no records
Resolves #1703
I have added a conditonal statement which renders table only when data is avilable.
How this PR fixes it
table is displayed only when it's not empty
How to test it
Go to the spending limits page in the safe without the spending limits module enabled or to the Base network ( no support for spending limits). Now the table would not be rendered if there is no data in table.
Checklist