Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: balance pagination test #1895

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

liliya-soroka
Copy link
Member

@liliya-soroka liliya-soroka commented Apr 21, 2023

What it solves

Add a safe with many tokens and update the Balance tests accordingly to test pagination on the Assets tab

Rinkeby safe was replaced with the Goerli test safe

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@iamacook iamacook changed the base branch from main to dev April 21, 2023 14:43
@liliya-soroka
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@iamacook iamacook changed the title Merge branch 'dev' into balance-test-update fix: balance pagination test Apr 21, 2023
@iamacook iamacook self-requested a review April 21, 2023 15:04
@iamacook
Copy link
Member

I'm going to merge this as we've tested it working locally.

@iamacook iamacook merged commit d1f39c0 into safe-global:dev Apr 21, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Apr 21, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Safe Contributor:

GitPOAP: 2023 Safe Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants