fix: Dashboard widgets do not align correctly #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usame-algan
reviewed
Apr 14, 2023
usame-algan
approved these changes
Apr 17, 2023
|
Thank you @deepaksing! 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR fixes the issue: fixes #1863 Dashboard widgets do not align correctly. Previously The "Connect & transact" widgets do not always stack/span the height of the "New in Safe" widget. This happened because FeatureApps Component was not able to take the full height of its parent component.
Resolves #
How this PR fixes it
In this PR I gave 100% height to child component so that fixed the issue for medium sized screens.
For large Sized screens the issue was with the min-width of the component. Due to this components were getting stacked horizontally. So increasing min-width to 500px for larger screen size solved the issue
How to test it
Open the Safe on Gnosis Chain. Observe the "Connect & transact" widgets
Connect & transact widget will span properly on larger resolutions and span with the height of the "New in Safe" on medium resolutions,
Screenshots
For Medium Sized Screens
For large Sized Screens
Checklist