Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove logo height #1951

Merged
merged 1 commit into from
May 5, 2023
Merged

fix: remove logo height #1951

merged 1 commit into from
May 5, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented May 5, 2023

What it solves

Resolves small logo after rebrand reversion.

How this PR fixes it

The logo height has been removed.

How to test it

Open the app and observe the correctly sized logo.

Screenshots

PR:

image

image

Prod:

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh May 5, 2023 09:53
@iamacook iamacook self-assigned this May 5, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

Branch preview

✅ Deploy successful!

https://fix_logo--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented May 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook
Copy link
Member Author

iamacook commented May 5, 2023

I'm going to merge this directly as it only touches the height of the image.

@iamacook iamacook merged commit 5e2b78c into release/1.9.0 May 5, 2023
@iamacook iamacook deleted the fix-logo branch May 5, 2023 10:08
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants