-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: decode native transfers + show Multisend in the tx info block #1899
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
src/components/transactions/TxDetails/TxData/DecodedData/Multisend/index.tsx
Outdated
Show resolved
Hide resolved
We show Expand/Collapse only in the details in the queue/history for space reasons. Regarding the batch modal, it uses a different component with its own logic, so it's normal. We should eventually refactor it to use the regular SignOrExecute component, I'll make a tech debt issue for that. Update: issue: #1909 |
So is correct that the expand/collapse all was removed and the batch tx modal will be tackled in another ticket. LGTM then. |
What it solves
Enhances the "Transaction details" block in SignOrExecuteForm:
How this PR fixes it
I've removed from custom Review modals, and it's now shown in Transaction details instead.
How to test it
Test native token transfers, NFT batches, Safe App batches.
Screenshots