-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update safe-deployments to latest version to support Neon contracts #1877
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
The Safe Core SDK also needs to be updated to the version that has the updated safe-deployments. |
I see, that is a collection of multiple codependent packages. Should I create a PR for that too? @katspaugh, can you please provide some guidance with safe-core-sdk PR? |
Exactly, and they did some restructuring there which we haven't migrated to yet. In that monorepo, there were previously packages called safe-core-sdk and safe-core-sdk-utils which this repo depends on. It's now renamed to protocol-kit, I believe. |
Hey @germartinez , Can you please help update the safe-core-sdk to the latest one? |
Looks like @germartinez already updated safe-deployments in safe-core-sdk. So you just need to bump its version to 3.3.3 in this PR. |
Please check the release of the Safe Core SDK here: https://github.com/safe-global/safe-core-sdk/releases/tag/r27.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
What it solves
Added latest version of safe-deployments, that contains Neon EVM Devnet safe-contract addresses.
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist