Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safe-deployments to latest version to support Neon contracts #1877

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

Sj-001
Copy link
Contributor

@Sj-001 Sj-001 commented Apr 18, 2023

What it solves

Added latest version of safe-deployments, that contains Neon EVM Devnet safe-contract addresses.
Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sj-001
Copy link
Contributor Author

Sj-001 commented Apr 18, 2023

I have read the CLA Document and I hereby sign the CLA

@Sj-001
Copy link
Contributor Author

Sj-001 commented Apr 18, 2023

recheck

@katspaugh
Copy link
Member

The Safe Core SDK also needs to be updated to the version that has the updated safe-deployments.

@Sj-001
Copy link
Contributor Author

Sj-001 commented Apr 18, 2023

The Safe Core SDK also needs to be updated to the version that has the updated safe-deployments.

I see, that is a collection of multiple codependent packages. Should I create a PR for that too? @katspaugh, can you please provide some guidance with safe-core-sdk PR?

@katspaugh
Copy link
Member

Exactly, and they did some restructuring there which we haven't migrated to yet. In that monorepo, there were previously packages called safe-core-sdk and safe-core-sdk-utils which this repo depends on. It's now renamed to protocol-kit, I believe.
Maybe there's still a branch where these packages exist, @germartinez can tell you more.

@Sj-001
Copy link
Contributor Author

Sj-001 commented Apr 20, 2023

Exactly, and they did some restructuring there which we haven't migrated to yet. In that monorepo, there were previously packages called safe-core-sdk and safe-core-sdk-utils which this repo depends on. It's now renamed to protocol-kit, I believe. Maybe there's still a branch where these packages exist, @germartinez can tell you more.

Hey @germartinez , Can you please help update the safe-core-sdk to the latest one?

@katspaugh
Copy link
Member

Looks like @germartinez already updated safe-deployments in safe-core-sdk. So you just need to bump its version to 3.3.3 in this PR.

@germartinez
Copy link
Member

Please check the release of the Safe Core SDK here: https://github.com/safe-global/safe-core-sdk/releases/tag/r27.1
Also available on npm

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@katspaugh katspaugh closed this Apr 26, 2023
@katspaugh katspaugh reopened this Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
@katspaugh katspaugh merged commit 8ea2584 into safe-global:dev Apr 26, 2023
@safe-global safe-global unlocked this conversation Apr 26, 2023
@katspaugh katspaugh mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants