Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle invalid areas / lanelets #3000

Merged
merged 39 commits into from
Jun 7, 2023
Merged

feat: handle invalid areas / lanelets #3000

merged 39 commits into from
Jun 7, 2023

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Mar 3, 2023 •
edited
Loading

Description

This PR is one of group of PRs for providing a solution for the idea discussed here.

Related links

Discussion

Issue

Relevant PRs

Tests performed

  • Add a tag for a lenelet to mark it as invalid
  • Test the software using planning simulator with a vehicle approaching to this invalid lanelet to see that vehicle stops before entering the invalid lanelet area and ask the driver to take over
  • Test the software using planning simulator with a vehicle starts inside an invalid lanelet to see that vehicle does not drive in this area and ask the driver to take over

Notes for reviewers

For compiling and testing this PR, all PRs in related links section need to be taken into consideration.
❗ Merge sequence can be found here ❗

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Mar 3, 2023
This was referenced Mar 3, 2023
Merged
Closed
Merged
Merged
Closed
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/3308-feat-handle-invalid-lanelets branch 2 times, most recently from 57eb09c to 60699ef Compare March 6, 2023 08:32
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) and removed component:map Map creation, storage, and loading. (auto-assigned) labels Mar 20, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/3308-feat-handle-invalid-lanelets branch from 1a4f615 to bc7020b Compare March 21, 2023 09:23
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 21, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/3308-feat-handle-invalid-lanelets branch from e141fa7 to c64ddf3 Compare March 21, 2023 09:29
This was referenced Mar 21, 2023
Merged
Closed
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as ready for review March 21, 2023 14:54
ahmeddesokyebrahim and others added 21 commits June 6, 2023 11:50
@ahmeddesokyebrahim
feat: fix review comment - adding background and examples about inval…
9a3e9ed 
…id lanelet in the readme file

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@pre-commit-ci @ahmeddesokyebrahim
style(pre-commit): autofix
109f98a
@ahmeddesokyebrahim
feat: fixing typos in the readme file
fbe2fc0 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: rebase, fix merge conflicts
b416874 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: fixing invalid lanelet debug file for virtual wall visualization
3daec00 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@pre-commit-ci @ahmeddesokyebrahim
style(pre-commit): autofix
48a6860
@ahmeddesokyebrahim
feat: fixing review comment, implementation refactoring
f599030 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@pre-commit-ci @ahmeddesokyebrahim
style(pre-commit): autofix
d9767f1
@ahmeddesokyebrahim
feat: changing module name from invalid_lanelet to no_drivable_lane
66b5191 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@pre-commit-ci @ahmeddesokyebrahim
style(pre-commit): autofix
97fb860
@ahmeddesokyebrahim
feat: fixing merge mistakes
84e57f6 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: removing rtc handing
52a2aa4 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: updating design doc due to removing rtc handling
413beb5 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: applying refactoring changes in planning modules to the no_driv…
06307be 
…able_lane module

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: fixing mistake out of previous commit for applying planning ref…
df406d2 
…actoring changes

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat: fixing typo in the readme file
7d12746 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@pre-commit-ci @ahmeddesokyebrahim
style(pre-commit): autofix
f4970ba
@ahmeddesokyebrahim
feat(no-drivable-lane): fixing cppline errors
8c047a5 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@pre-commit-ci @ahmeddesokyebrahim
style(pre-commit): autofix
207eee2
@ahmeddesokyebrahim
feat(no_drivable_lane): reflecting refactoring changes of adding new …
23372a5 
…framework for virtual walls markers

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim
feat(no_drivable_lane): updating docs based on latest refactoring cha…
dbd3c04 
…nges

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/3308-feat-handle-invalid-lanelets branch from 803559c to dbd3c04 Compare June 6, 2023 08:51
mehmetdogru
mehmetdogru approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TakaHoribe
TakaHoribe approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TakaHoribe
TakaHoribe approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetdogru
Copy link
Contributor

@TakaHoribe thank you for the approval however the PR still waits for a code owner review could anybody from your team approve as well? If not @xmfcx could you approve it as global-codeowner?

@xmfcx xmfcx merged commit 35bc65a into autowarefoundation:main Jun 7, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 8, 2023
Merged
@ahmeddesokyebrahim ahmeddesokyebrahim deleted the autoware/universe/3308-feat-handle-invalid-lanelets branch June 14, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@mehmetdogru mehmetdogru mehmetdogru approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@kminoda kminoda Awaiting requested review from kminoda

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

Assignees

@ahmeddesokyebrahim ahmeddesokyebrahim

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ahmeddesokyebrahim @TakaHoribe @mehmetdogru @yukkysaito @xmfcx @satoshi-ota