Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_no_drivable_lane_module): relocate README file #3967

Conversation

mehmetdogru
Copy link
Contributor

Description

To be able to sync the README file under behavior_velocity_no_drivable_lane_module with github.io, this PR renames and relocates the README file for behavior_velocity_no_drivable_lane_module

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…file

Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
@mehmetdogru mehmetdogru self-assigned this Jun 13, 2023
@mehmetdogru mehmetdogru requested a review from a team as a code owner June 13, 2023 08:54
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d3bb389) 14.42% compared to head (7fe58da) 14.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3967      +/-   ##
==========================================
- Coverage   14.42%   14.42%   -0.01%     
==========================================
  Files        1456     1456              
  Lines      102581   102580       -1     
  Branches    29674    29673       -1     
==========================================
- Hits        14797    14796       -1     
  Misses      71645    71645              
  Partials    16139    16139              
Flag Coverage Δ *Carryforward flag
differential 21.65% <ø> (?)
total 14.42% <ø> (-0.01%) ⬇️ Carriedforward from d3bb389

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 18.48% <ø> (-0.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahmeddesokyebrahim
Copy link
Contributor

@xmfcx : may you please approve this PR ?
It is just for reflecting the recent refactoring changes regarding README.md (name and location) in behavior_velocity_planning modules into no_drivable_lane module.

@xmfcx
Copy link
Contributor

xmfcx commented Jun 13, 2023

@ahmeddesokyebrahim you seem to be a code owner for this package, your approval should be enough.

Can you make sure that you have ahmed.ebrahim@leodrive.ai under emails section in Github settings? https://github.com/settings/emails (it doesn't need to be the primary email, it just needs to be in the list)

@ahmeddesokyebrahim
Copy link
Contributor

@xmfcx : Thanks for this great advice!
It is working now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants