Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync upstream #561

Merged
merged 5 commits into from
Jun 8, 2023
Merged

chore: sync upstream #561

merged 5 commits into from
Jun 8, 2023

Conversation

tier4-autoware-public-bot[bot]
Copy link

Features

Code Refactoring

satoshi-ota and others added 5 commits June 7, 2023 13:16
@satoshi-ota
feat(avoidance): stop within current lane in unsafe situation (autowa…
b2f4517 
…refoundation#3785)

* refactor(avoidance): separate stop line calculation

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): don't cancel avoidance maneuver if the ego exceed yield stop line

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(utils): move common utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): stop within current lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): add some comments

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add module success condition

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(avoidance): clean up

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): add option for yield during shifting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@ahmeddesokyebrahim
feat: handle invalid areas / lanelets (autowarefoundation#3000)
35bc65a 
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@kosuke55
refactor(start_planner): rename pull out to start planner (autowarefo…
8c9f9e4 
…undation#3908)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@isamu-takagi
refactor(behavior_velocity_planner): update launch and parameter file…
8a44d44 
…s for plugin (autowarefoundation#3811)

* feat: move param files

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* WIP

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: use behavior velocity module param file list

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: update comment

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: change param load

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: update launch run out flag

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add disabled module as comment

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: remove unused argument

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix test

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* remove unused params

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* move param

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* add test depend

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@kosuke55
feat(pull_out): change pull out finish deviation threshold (autowaref…
68f6f2f 
…oundation#3917)

feat(pull_out): change pull out finish deviation threshould

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the common label Jun 8, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation launch perception planning system labels Jun 8, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 7.34% and project coverage change: +1.25 🎉

Comparison is base (1375cf5) 13.58% compared to head (68f6f2f) 14.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@              Coverage Diff               @@
##           tier4/main     #561      +/-   ##
==============================================
+ Coverage       13.58%   14.84%   +1.25%     
==============================================
  Files             249      341      +92     
  Lines           24012    31794    +7782     
  Branches         9334    15006    +5672     
==============================================
+ Hits             3263     4721    +1458     
- Misses          17110    21854    +4744     
- Partials         3639     5219    +1580
Flag Coverage Δ
differential 14.84% <7.34%> (+1.25%) ⬆️
Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <0.00%> (ø)
...viz_plugin/src/velocity_steering_factors_panel.cpp 0.00% <0.00%> (ø)
...anner/include/behavior_path_planner/parameters.hpp 50.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 50.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...planner/utils/start_planner/geometric_pull_out.hpp 0.00% <ø> (ø)
...path_planner/utils/start_planner/pull_out_path.hpp 0.00% <ø> (ø)
...ath_planner/utils/start_planner/shift_pull_out.hpp 0.00% <ø> (ø)
...r/utils/start_planner/start_planner_parameters.hpp 0.00% <0.00%> (ø)
... and 27 more

... and 201 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit c66a48a into tier4/main Jun 8, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the sync-upstream branch June 8, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@tkhmy tkhmy Awaiting requested review from tkhmy

@yabuta yabuta Awaiting requested review from yabuta

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@knzo25 knzo25 Awaiting requested review from knzo25

@yukke42 yukke42 Awaiting requested review from yukke42

@h-ohta h-ohta Awaiting requested review from h-ohta h-ohta is a code owner

Assignees
No one assigned
Labels
common documentation Improvements or additions to documentation launch perception planning system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codecov-commenter @satoshi-ota @ahmeddesokyebrahim @kosuke55 @isamu-takagi