Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first draft proposal implementation for handling invalid lanelets #235

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Mar 3, 2023

Description

This PR is one of group of PRs for providing a solution for the idea discussed here.

Related links

Discussion

Issue

Relevant PRs

Notes for reviewers

For compiling and testing this PR, all PRs in related links section need to be taken into consideration.
Merge sequence can be found here

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ahmeddesokyebrahim ahmeddesokyebrahim added the enhancement New feature or request label Mar 3, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Mar 3, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from d89ba2c to 2c9c2c9 Compare March 6, 2023 08:26
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from b80ceef to 8c0f7cc Compare March 21, 2023 09:25
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as ready for review March 21, 2023 14:55
kenji-miyake referenced this pull request in tier4/autoware_launch Mar 21, 2023
* fix: delete aip dependents

* Update package.xml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 23, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from 8c0f7cc to 74320cb Compare March 23, 2023 13:16
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from 74320cb to 7219b6a Compare March 27, 2023 14:44
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch 2 times, most recently from e9d8469 to 8c6a45a Compare April 12, 2023 11:30
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from 8c6a45a to 617cb0c Compare April 25, 2023 17:27
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from 617cb0c to a022b0b Compare May 5, 2023 09:19
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch 2 times, most recently from c6f0ed8 to 407e754 Compare May 16, 2023 14:36
@ahmeddesokyebrahim ahmeddesokyebrahim changed the title feat: first draft proposal implementation for handling invalid lanelets feat: first draft proposal implementation for handling invalid lanelets May 16, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from a16de95 to 93339b0 Compare May 24, 2023 10:33
ahmeddesokyebrahim and others added 10 commits May 29, 2023 11:15
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
…_lane

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/3308-feat-handle-invalid-lanelets branch from 93339b0 to 428fadf Compare May 29, 2023 08:21
Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetdogru
Copy link
Contributor

Since the related module disabled by default at the moment it won't do any harm to merge this PR. So I will go ahead and merge this and hopefully we can merge the main PR as well soon.

cc: @ahmeddesokyebrahim @TakaHoribe @mitsudome-r

@mehmetdogru mehmetdogru merged commit 402b2ff into autowarefoundation:main May 30, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim deleted the autoware/launch/3308-feat-handle-invalid-lanelets branch June 14, 2023 19:30
tkimura4 pushed a commit to tkimura4/autoware_launch that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants