Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

refactor(no_drivable_lane): updating no_drivable_lane doc link after refactoring updates #188

Conversation

ahmeddesokyebrahim
Copy link
Contributor

Description

This PR is to update the link of no_drivable_lane module document link after changing its name and location in univerise.

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Jun 13, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim added the type:documentation Creating or refining documentation. label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (268a8c8) 10.37% compared to head (0addc77) 10.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   10.37%   10.37%           
=======================================
  Files          35       35           
  Lines        2613     2613           
  Branches     1366     1366           
=======================================
  Hits          271      271           
  Misses       1897     1897           
  Partials      445      445           
Flag Coverage Δ *Carryforward flag
differential 8.59% <ø> (?)
total 10.37% <ø> (ø) Carriedforward from 268a8c8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahmeddesokyebrahim
Copy link
Contributor Author

@mitsudome-r san : May you please review this change and if you do not have any comments approve it ?
It is just a change in doc link of no_drivable_lane module due to a refactoring change.

Thanks :)

…refeactoring updates

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/common/refactor_no_drivable_lane_doc branch from b1a3b33 to 0addc77 Compare June 19, 2023 21:33
@ahmeddesokyebrahim
Copy link
Contributor Author

ahmeddesokyebrahim commented Jun 19, 2023

@mitsudome-r san : May you please have a look to this PR and let me know if any changes needed ?
This is the last remaining open PR for this phase regarding the no_drivable_lane feature (Group of PRs).

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit d65a738 into autowarefoundation:main Jun 20, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim deleted the autoware/common/refactor_no_drivable_lane_doc branch June 20, 2023 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants