Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Gatsby v2 #1

Merged
merged 3,178 commits into from
Nov 26, 2018
Merged

Migrate to Gatsby v2 #1

merged 3,178 commits into from
Nov 26, 2018

Conversation

v4iv
Copy link
Owner

@v4iv v4iv commented Nov 26, 2018

No description provided.

DSchau and others added 30 commits November 1, 2018 15:28
 - gatsby@2.0.37
* add hacktoberfest wrapup blog post

* fix link, rm emojis

* edits from @DSchau
Recently I tried to run the instance of gatsby's website locally. 
By using `gatsby develop` in /www, unfortunately, it got stuck. Refer #9640 for more info.
Thanks to @DSchau he suggested trying `GATSBY_SCREENSHOT_PLACEHOLDER=true` to run the dev server. But for a new contributor, it's hard for him to figure this out. 

So I made some changes in the `how-to-contribute` docs.
…93) (#9623)

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

Fixes #9593
Mostly edited punctuation. Also, changed an abbreviation to match the style guide.
* Updates Page Not Found UX with Link

* Adds Link to 404.js

* Updates code indentation

Co-Authored-By: pranshuchittora <pranshuchittora17@gmail.com>

* Updates routes from './' to '/'

Co-Authored-By: pranshuchittora <pranshuchittora17@gmail.com>
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
The copy was implying the link is to the Gatsby-Link package but was actually redirecting to the general packages page.
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
…ot onRouteUpdate (#9657)

* use shouldUpdateScroll api to not battle with builtin scrollbehaviour on scroll handling

* use passed hash, doh
Added Kentico Cloud to the list of supported CMSes
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

Fixes issue at the end of #9559, e.g.:
```javascript
module.exports = {
    plugins: [
        {
            resolve: 'gatsby-plugin-react-helmet'
        }
    ]
}
```
where the plugin is loaded using object syntax but no `options` object is defined.

This wasn't caught by the unit test because the issue was occurring after the early out when it's the `___TEST___` plugin.
 - gatsby-remark-autolink-headers@2.0.10
 - gatsby@2.0.38
removed extra 'to' from the docs

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
* add gatsby-plugin-cxs

* fix cr: add gitignore and uppercase some text

* add babel-preset-gatsby-package devDependencies
 - gatsby-plugin-cxs@1.0.1
* chore: use last published version as base version

* chore: bump to 2.0.0
 - gatsby-plugin-cxs@2.0.1
…th) (#9653)

Hi @jlengstorf and @shannonbux,
I added Documentation, Official Plugins and Starters section (Next Steps) to the end of the tutorial, at the end of part 8 under section https://www.gatsbyjs.org/tutorial/part-eight/#keep-making-it-better.
In accordance with the issue #9375 and pull request #9646
I hope it might help : )
@LekoArts just updated this with a few grammar / punctuation edits. It is structured very smoothly! Thank you for working so hard on this!
* chore: tweak readme for various plugins that use secrets/keys

This PR adds some boilerplate text for plugins that have secret data,
access tokens, etc. Open to tweaking language here, this is a decent
first pass, so certainly open to suggestions or other approaches.

cc @jlengstorf @KyleAMathews

* Update packages/gatsby-source-contentful/README.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update packages/gatsby-source-contentful/README.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update packages/gatsby-source-graphql/README.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>

* Update packages/gatsby-source-wordpress/README.md

Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
I noticed that a couple of the demo links for starters were returning as not found. The GitHub links were still valid but had different demo links. I updated to reflect the demo links listed on their respective GitHub repository.
## Done 🙌🏻

While I was doing some digging for #9655, I noticed the tutorial folders contained redundant image files that were no longer being used anywhere in the codebase. I have removed them.

## Why? 🧐

- This is a huge codebase, cloning it to my machine took ten minutes. Removing any redundant files will help, albeit only a little. But every little helps, right? 👍🏻

- It easier to maintain a site which only contains files that are being used as there is less cognitive overload.

## How to QA this change 🤓

- Grep the codebase for each file I have deleted
- You should return 0 results for each file.
seems like those aren't accessible anymore and it breaks www build
We built this site using Gatsby v2 and Prismic and would love to add it to your showcase.
alexandernanberg and others added 29 commits November 21, 2018 14:53
Closes: #7143 #9731
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
 - gatsby@2.0.54
BREAKING CHANGE: html markup has been changed, high resolution image (img.gatsby-resp-image-image) is no longer nested inside span with low resolution placeholder  (span.gatsby-resp-image-wrapper) - it's sibling of that span now. This might affect any custom styling that is applied to inline images
 - gatsby-remark-images@3.0.0
…it's not defiened (#10069)

Not really sure how I go about submitting a PR here. This addition references issue #9977

Any guidance would be greatly appreciated.
 - gatsby-plugin-manifest@2.0.10
 - gatsby-plugin-offline@2.0.17
 - gatsby-source-faker@2.0.2
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

Hello the Gatsby Team,
First of all, thanks for the great product you're building, and the community around it.
At [Monbanquet.fr](https://monbanquet.fr) we're using it for our main production website and it's been great so far, both in terms of user and developer experience.

As it's my first PR here, hit me up if I did something wrong :)
Cheers
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Clicking the link below results in a not found page. Updated with the correct url
<img width="733" alt="screen shot 2018-11-22 at 09 53 12" src="https://user-images.githubusercontent.com/1019869/48906947-7ac55000-ee3c-11e8-8ae9-45e88b5d733b.png">

<img width="1514" alt="screen shot 2018-11-22 at 09 52 22" src="https://user-images.githubusercontent.com/1019869/48906903-59646400-ee3c-11e8-9cac-cef544a127dc.png">
Needed to specify additional changes to serve production-optimized build and bind to correct port.

These were the changes I needed to make in order to make a deployment work with Heroku, please let me know if this is helpful or not! 😄 🙏
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
* Update starters.yml

* Update starters.yml
While working on loki (#9919), I've run into lots of fun edge cases to do with sorting. One is that some connection queries specify a sort order, but some returned fields have the same value for the sort field. The behavior here is undefined, but by default sift will order by the order they were added to Gatsby. While that's not a terrible default, it makes testing sift and loki compatibility hard, since loki has undefined ordering for this case.

So this PR adds a specific secondary sort key to various `www` queries, mainly for the purpose of testing sift/loki compatibility, but also because it makes sense.
…evelop mode for easier debugging (#10083)

Closes #6278

Sourcemaps are not currently working on gatsby v2. This fixes that on 1 string.
 - gatsby@2.0.55
…tem section (#10096)

Instead by `slug` we sort the starters by `stars` (DESC) - solving #10085 (comment)
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->

**What kind of change does this PR introduce?**
<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->
This PR is related to the issue #10103 
The PR helps to publish test results for reporting in Azure Pipelines.

**Summary**
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
<!-- Try to link to an open issue for more information. -->
Azure Pipelines provides excellent reporting capabilities that can be leveraged by this PR.
An example report is shown in the image below.
![image](https://user-images.githubusercontent.com/13175100/48767951-e8a73580-ecdd-11e8-8e6a-20d7767d7c1b.png)
A screenshot for code coverage : 
![image](https://user-images.githubusercontent.com/13175100/48795657-938e1280-ed23-11e8-88d0-bf94f610d774.png)


**Does this PR introduce a breaking change?**
No
…10123)

fixes #6643

I also fell for this error before, sinc the original errors are swallowed (and fairly unclear too, because of the indirection). Adding validation was suggested in linked issue, so I went for this, since I didn't see any already used object validation like "ow" in use here.

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

The spacing in the dependency grid looked off to me, so I improved it a bit.

Before: 
<img width="1064" alt="screenshot 2018-11-26 at 13 58 19" src="https://user-images.githubusercontent.com/541628/49015578-cbfa7a00-f183-11e8-9ee0-2452f8c1c83d.png">

After: 
<img width="1079" alt="screenshot 2018-11-26 at 13 58 07" src="https://user-images.githubusercontent.com/541628/49015584-d157c480-f183-11e8-86de-b7c20bee71f8.png">
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Add licensing information to the `README` file which is a usual practice being followed 👍
* fix(www): Remove multiple entries from sites tags

* Forgot the Paving tag

* Update sites.yml
The bridge dependency for Babel 7's `babel-core` is `babel-core@7.0.0-bridge.0`
 - gatsby-source-drupal@3.0.11
 - gatsby-source-filesystem@2.0.9
 - gatsby-source-wordpress@3.0.15
…y line highlighting (#9696)

* feat: allow highlight directives in prismjs plugin

Heavily inspired by DSchau#2

* fix: Fix multiline plain-text for directives

* tests: test highlight-range directive

* Add built version

* feat: rely on prismjs plugin for embed-snippet directive highlighting

* Add console.warn if invalid range is specified

* docs: document highlight directives

* fix: fix endless loop when multiple highlight-start/end directives

* Add kitchen sink directive test

* Remove built version

* docs: better directive example

* fix: existing highlight ranges behavior now working again

* fix: JSX directive not removed after highlight

* fix: highlight-range directive removing a line

* Add comment explaining priority between top-level declaration and directives

* fix lint error

* Add more explicit example in README

* Fix HTML opening comment not being stripped

* Add `./highlight-line-range.js to .gitignore

* Remove extraneous <span> tags

* Add comment for big regex
 - gatsby-remark-embed-snippet@3.1.0
 - gatsby-remark-prismjs@3.1.0
Closes #10135 
Added license to `What's in this document section` linking it to corresponding section within the `README` file.
@v4iv v4iv merged commit c7b298b into v4iv:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment