Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): add proper sorting for featured starters in Homepage Ecosystem section #10096

Merged
merged 1 commit into from
Nov 22, 2018
Merged

fix(www): add proper sorting for featured starters in Homepage Ecosystem section #10096

merged 1 commit into from
Nov 22, 2018

Conversation

greglobinski
Copy link
Contributor

@greglobinski greglobinski commented Nov 22, 2018 •
edited
Loading

Instead by slug we sort the starters by stars (DESC) - solving #10085 (comment)

@greglobinski greglobinski requested a review from a team as a code owner November 22, 2018 18:15
pieh
pieh approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @greglobinski!

@pieh pieh merged commit bafdfec into gatsbyjs:master Nov 22, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@greglobinski @gpetrioli
fix(www): add proper sorting for featured starters in Homepage Ecosys…
0cf250d 
…tem section (gatsbyjs#10096)

Instead by `slug` we sort the starters by `stars` (DESC) - solving gatsbyjs#10085 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greglobinski @pieh