fix(gatsby-remark-autolink-headers): use shouldUpdateScroll api and not onRouteUpdate #9657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on scroll handling
| window.scrollTo(0, offset - offsetY) | ||
| } | ||
| const getTargetOffset = hash => { | ||
| const id = window.decodeURI(window.location.hash.replace(`#`, ``)) |
There was a problem hiding this comment.
Might be missing something – but shouldn't this be hash instead of window.location.hash here?
There was a problem hiding this comment.
Seems reasonable! window.location.hash is already being passed here, so seems like you're right!
|
Also @pieh you're probably aware, but it seems like that pathPrefix test has one flaky test that sometimes fails with:
Definitely unrelated to this PR, I'd think. |
This was referenced Nov 3, 2018
jayphelps
added a commit
to eclipse-iofog/iofog.org
that referenced
this pull request
Nov 14, 2018
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…ot onRouteUpdate (gatsbyjs#9657) * use shouldUpdateScroll api to not battle with builtin scrollbehaviour on scroll handling * use passed hash, doh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now autolink-headers scroll is battling with scrollbehaviour and which should handle scroll to
#elementId. This allowautolink-headersplugin to hook into scrollbehaviour to override default behaviour.Potential problems:
shouldUpdateScrollis API that handles only one instance of this hook, so using it in autolink-headers plugin will discard results of this hook in user code (if it's used there)closes #9638