Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add gatsby-plugin-cxs #8878

Merged
merged 3 commits into from
Nov 2, 2018
Merged

add gatsby-plugin-cxs #8878

merged 3 commits into from
Nov 2, 2018

Conversation

ctxhou
Copy link
Contributor

@ctxhou ctxhou commented Oct 6, 2018 •
edited
Loading

Add support cxs ssr.

Related to #8710

The example is altered from styled-component example.

It seems like gatsby-plugin-cxs has been published, so right now the version is temporary.

DSchau
DSchau suggested changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, left a few comments! Thank you!

packages/gatsby-plugin-cxs/gatsby-ssr.js Outdated Show resolved Hide resolved
packages/gatsby-plugin-cxs/package.json Outdated Show resolved Hide resolved
packages/gatsby-plugin-cxs/.npmignore Show resolved Hide resolved
packages/gatsby-plugin-cxs/src/gatsby-ssr.js Show resolved Hide resolved
hugovk
hugovk reviewed Oct 16, 2018
View reviewed changes
examples/using-cxs/README.md Outdated Show resolved Hide resolved
packages/gatsby-plugin-cxs/.npmignore Outdated Show resolved Hide resolved
packages/gatsby-plugin-cxs/README.md Outdated Show resolved Hide resolved
@ctxhou
Copy link
Contributor Author

ctxhou commented Oct 30, 2018

hey @DSchau , I've send the new cr. Please review it when you have a minute 😄

@DSchau DSchau merged commit 913fabe into gatsbyjs:master Nov 2, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 2, 2018

Holy buckets, @ctxhou — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@DSchau
Copy link
Contributor

DSchau commented Nov 2, 2018 

Successfully published:
 - gatsby-plugin-cxs@2.0.1

We were apparently already on 2.0.0, so had to bump the version. Thanks for the PR!

@DSchau DSchau mentioned this pull request Nov 6, 2018
Closed
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@ctxhou @gpetrioli
add gatsby-plugin-cxs (gatsbyjs#8878)
c008809 
* add gatsby-plugin-cxs

* fix cr: add gitignore and uppercase some text

* add babel-preset-gatsby-package devDependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctxhou @DSchau @hugovk